Make runOnTransactionIdleCallbacks() handle dangling transactions

This avoids "Got COMMIT while atomic sections X are still open"
if the this DB had active transactions when an error occurred.

Change-Id: I1e2eb3a3382537108ecb269c483d2e62a218b656

diff --git a/includes/db/Database.php b/includes/db/Database.php
index 531086b..943667e 100644 (file)
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -3314,6 +3314,11 @@ abstract class DatabaseBase implements IDatabase {
                                                MWExceptionHandler::logException( $ePrior );
                                        }
                                        $ePrior = $e;
+                                       // Some callbacks may use startAtomic/endAtomic, so make sure
+                                       // their transactions are ended so other callbacks don't fail
+                                       if ( $this->trxLevel() ) {
+                                               $this->rollback( __METHOD__ );
+                                       }
                                }
                        }
                } while ( count( $this->mTrxIdleCallbacks ) );