bug 19305 rev_deleted link consistency (greyed-out)

diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php
index f5da505..c258051 100644 (file)
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -522,7 +522,7 @@ class ContribsPager extends ReverseChronologicalPager {
                        }
                }
                # Is there a visible previous revision?
-               if( $rev->userCan(Revision::DELETED_TEXT) ) {
+               if( !$rev->isDeleted(Revision::DELETED_TEXT) ) {
                        $difftext = '(' . $sk->linkKnown(
                                $page,
                                $this->messages['diff'],
@@ -544,12 +544,16 @@ class ContribsPager extends ReverseChronologicalPager {
 
                $comment = $wgContLang->getDirMark() . $sk->revComment( $rev, false, true );
                $date = $wgLang->timeanddate( wfTimestamp( TS_MW, $row->rev_timestamp ), true );
-               $d = $sk->linkKnown(
-                       $page,
-                       htmlspecialchars($date),
-                       array(),
-                       array( 'oldid' => intval( $row->rev_id ) )
-               );
+               if( $rev->isDeleted( Revision::DELETED_TEXT ) ) {
+                       $d = '<span class="history-deleted">' . $date . '</span>';
+               } else {
+                       $d = $sk->linkKnown(
+                               $page,
+                               htmlspecialchars($date),
+                               array(),
+                               array( 'oldid' => intval( $row->rev_id ) )
+                       );
+               }
 
                if( $this->target == 'newbies' ) {
                        $userlink = ' . . ' . $sk->userLink( $row->rev_user, $row->rev_user_text );
@@ -558,10 +562,6 @@ class ContribsPager extends ReverseChronologicalPager {
                        $userlink = '';
                }
 
-               if( $rev->isDeleted( Revision::DELETED_TEXT ) ) {
-                       $d = '<span class="history-deleted">' . $d . '</span>';
-               }
-
                if( $rev->getParentId() === 0 ) {
                        $nflag = '<span class="newpage">' . $this->messages['newpageletter'] . '</span>';
                } else {