Don't allow reverting of images if the image page is protected. Fixes BUG 996920.
authorJens Frank <jeluf@users.mediawiki.org>
Thu, 5 Aug 2004 04:30:29 +0000 (04:30 +0000)
committerJens Frank <jeluf@users.mediawiki.org>
Thu, 5 Aug 2004 04:30:29 +0000 (04:30 +0000)
includes/ImagePage.php
includes/Skin.php

index d06f06a..0394473 100644 (file)
@@ -261,6 +261,10 @@ class ImagePage extends Article {
                        $wgOut->readOnlyPage();
                        return;
                }
+               if ( ! $this->mTitle->userCanEdit() ) {
+                       $wgOut->sysopRequired();
+                       return;
+               }
                $name = substr( $oldimage, 15 );
 
                $dest = wfImageDir( $name );
index d7119e3..dbff5d6 100644 (file)
@@ -2533,7 +2533,7 @@ class Skin {
                        }
                } else {
                        $url = wfEscapeHTML( wfImageArchiveUrl( $img ) );
-                       if( $wgUser->getID() != 0 ) {
+                       if( $wgUser->getID() != 0 && $wgTitle->userCanEdit() ) {
                                $rlink = $this->makeKnownLink( $wgTitle->getPrefixedText(),
                                           wfMsg( 'revertimg' ), 'action=revert&oldimage=' .
                                           urlencode( $img ) );