Merge "Declare visibility for class properties in DatabaseMssql"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Sun, 29 Dec 2013 19:30:35 +0000 (19:30 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sun, 29 Dec 2013 19:30:35 +0000 (19:30 +0000)
1  2 
includes/db/DatabaseMssql.php

   * @ingroup Database
   */
  class DatabaseMssql extends DatabaseBase {
-       var $mInsertId = null;
-       var $mLastResult = null;
-       var $mAffectedRows = null;
+       /** @var resource */
+       protected $mLastResult = null;
  
-       var $mPort;
+       /** @var int The number of rows affected as an integer */
+       protected $mAffectedRows = null;
+       /**
+        * @var int Post number for database
+        * @todo Unused and can be removed?
+        */
+       protected $mPort;
+       /** @var int */
+       private $mInsertId = null;
  
        function cascadingDeletes() {
                return true;
@@@ -88,7 -97,7 +97,7 @@@
  
                # e.g. the class is being loaded
                if ( !strlen( $user ) ) {
 -                      return;
 +                      return null;
                }
  
                $this->close();
  
        /**
         * This must be called after nextSequenceVal
-        * @return null
+        * @return int|null
         */
        function insertId() {
                return $this->mInsertId;