May as well use the master for start/end points
authorAaron Schulz <aaron@users.mediawiki.org>
Tue, 1 Sep 2009 22:37:37 +0000 (22:37 +0000)
committerAaron Schulz <aaron@users.mediawiki.org>
Tue, 1 Sep 2009 22:37:37 +0000 (22:37 +0000)
maintenance/migrateUserGroup.php

index 9ac70d1..ed9cd03 100644 (file)
@@ -35,10 +35,10 @@ class MigrateUserGroup extends Maintenance {
                $count = 0;\r
                $oldGroup = $this->getArg( 0 );\r
                $newGroup = $this->getArg( 1 );\r
-               $dbr = wfGetDB( DB_SLAVE );\r
-               $start = $dbr->selectField( 'user_groups', 'MIN(ug_user)',\r
+               $dbw = wfGetDB( DB_MASTER );\r
+               $start = $dbw->selectField( 'user_groups', 'MIN(ug_user)',\r
                        array('ug_group' => $oldGroup), __FUNCTION__ );\r
-               $end = $dbr->selectField( 'user_groups', 'MAX(ug_user)',\r
+               $end = $dbw->selectField( 'user_groups', 'MAX(ug_user)',\r
                        array('ug_group' => $oldGroup), __FUNCTION__ );\r
                if( $start === null ) {\r
                        $this->error( "Nothing to do - no users in the '$oldGroup' group", true );\r
@@ -48,7 +48,6 @@ class MigrateUserGroup extends Maintenance {
                $blockStart = $start;\r
                $blockEnd = $start + $this->mBatchSize - 1;\r
                // Migrate users over in batches...\r
-               $dbw = wfGetDB( DB_MASTER );\r
                while( $blockEnd <= $end ) {\r
                        $this->output( "Doing users $blockStart to $blockEnd\n" );\r
                        $dbw->begin();\r