API: Another diff problem, var name mix-up.
authorDaniel Cannon <amidaniel@users.mediawiki.org>
Tue, 27 Nov 2007 20:43:29 +0000 (20:43 +0000)
committerDaniel Cannon <amidaniel@users.mediawiki.org>
Tue, 27 Nov 2007 20:43:29 +0000 (20:43 +0000)
includes/api/ApiQueryRevisions.php

index 51191d4..d32afc9 100644 (file)
@@ -253,19 +253,21 @@ class ApiQueryRevisions extends ApiQueryBase {
                                $diff = new Diff($oldText, $newText);
                                $r['from'] = $previousRevID;
                                ApiResult::setContent($r, $wgContLang->unsegmentForDiff($this->formatter->format($diff)));
-                               $diffArr[$revid] = $r;
+                               $this->diffArr[$revid] = $r;
                                                                
                                $previousRevID = $revid;
                                $oldText = $newText;
                        }
 
-                       # Populate the query result with the contents of $diffArr.
-                       $knownrevs = array_keys($diffArr);
-                       $i = count($knownrevs) - 1;
-                       foreach($data['query']['pages'][$pageID]['revisions'] as &$rev) {
-                               if ( $i >= 0 && isset ( $diffArr[$knownrevs[$i]] ) )
-                                       $rev['difftoprev'] = $diffArr[$knownrevs[$i]];
-                               $i --;
+                       if ( $this->diffArr ) {
+                               # Populate the query result with the contents of $this->diffArr.
+                               $knownrevs = array_keys($this->diffArr);
+                               $i = count($knownrevs) - 1;
+                               foreach($data['query']['pages'][$pageID]['revisions'] as &$rev) {
+                                       if ( $i >= 0 && isset ( $this->diffArr[$knownrevs[$i]] ) )
+                                               $rev['difftoprev'] = $this->diffArr[$knownrevs[$i]];
+                                       $i --;
+                               }
                        }
                }