Generalize Installer::showStatusMessage()

Folds functionality from child classes back into a
concrete implementation in the parent class, reducing code duplication.

Change-Id: I697fe697dbd59d5db6fc77aba20af322e6011782

diff --git a/includes/installer/CliInstaller.php b/includes/installer/CliInstaller.php
index 1c7762b..c6939a8 100644 (file)
--- a/includes/installer/CliInstaller.php
+++ b/includes/installer/CliInstaller.php
@@ -179,16 +179,11 @@ class CliInstaller extends Installer {
        public function showHelpBox( $msg /*, ... */ ) {
        }
 
+       /**
+        * @param Status $status
+        */
        public function showStatusMessage( Status $status ) {
-               $warnings = array_merge( $status->getWarningsArray(),
-                       $status->getErrorsArray() );
-
-               if ( count( $warnings ) !== 0 ) {
-                       foreach ( $warnings as $w ) {
-                               call_user_func_array( array( $this, 'showMessage' ), $w );
-                       }
-               }
-
+               parent::showStatusMessage( $status );
                if ( !$status->isOk() ) {
                        echo "\n";
                        exit( 1 );

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 015ac53..7c67ee8 100644 (file)
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -351,10 +351,17 @@ abstract class Installer {
        abstract public function showError( $msg /*, ... */ );
 
        /**
-        * Show a message to the installing user by using a Status object
+        * Shows messages to the user through a Status object
         * @param Status $status
         */
-       abstract public function showStatusMessage( Status $status );
+       public function showStatusMessage( Status $status ) {
+               $errors = array_merge( $status->getErrorsArray(), $status->getWarningsArray() );
+               if ( $errors ) {
+                       foreach ( $errors as $error ) {
+                               call_user_func( 'showMessage', $error );
+                       }
+               }
+       }
 
        /**
         * Constructor, always call this from child classes.

diff --git a/includes/installer/WebInstaller.php b/includes/installer/WebInstaller.php
index f62470e..ea86231 100644 (file)
--- a/includes/installer/WebInstaller.php
+++ b/includes/installer/WebInstaller.php
@@ -729,16 +729,6 @@ class WebInstaller extends Installer {
                $this->output->addHTML( $html );
        }
 
-       /**
-        * @param Status $status
-        */
-       public function showStatusMessage( Status $status ) {
-               $errors = array_merge( $status->getErrorsArray(), $status->getWarningsArray() );
-               foreach ( $errors as $error ) {
-                       call_user_func_array( array( $this, 'showMessage' ), $error );
-               }
-       }
-
        /**
         * Label a control by wrapping a config-input div around it and putting a
         * label before it.