(bug 29567) mw.util.addPortletLink should only wrap link in <span> for "vectorTabs...

* Patch by Erwin Dokter
* This unbreaks test introduced in r90728

diff --git a/resources/mediawiki/mediawiki.util.js b/resources/mediawiki/mediawiki.util.js
index 1f4d95f..189046f 100644 (file)
--- a/resources/mediawiki/mediawiki.util.js
+++ b/resources/mediawiki/mediawiki.util.js
@@ -374,9 +374,14 @@
                                // Unhide portlet if it was hidden before
                                $portlet.removeClass( 'emptyPortlet' );
 
-                               // Wrap the anchor tag in a <span> and create a list item for it
+                               // Wrap the anchor tag in a list item (and a span if $portlet is a Vector tab)
                                // and back up the selector to the list item
-                               var $item = $link.wrap( '<li><span></span></li>' ).parent().parent();
+                               var $item;
+                               if ( $portlet.hasClass( 'vectorTabs' ) ) {
+                                       $item = $link.wrap( '<li><span></span></li>' ).parent().parent();
+                               } else {
+                                       $item = $link.wrap( '<li></li>' ).parent();
+                               }
 
                                // Implement the properties passed to the function
                                if ( id ) {