Kill the oldtimeout stuff, with minimum PHP being 5.2.3
authorSam Reed <reedy@users.mediawiki.org>
Tue, 15 Mar 2011 12:24:05 +0000 (12:24 +0000)
committerSam Reed <reedy@users.mediawiki.org>
Tue, 15 Mar 2011 12:24:05 +0000 (12:24 +0000)
includes/HttpFunctions.php

index ecf2277..cd919b4 100644 (file)
@@ -732,12 +732,7 @@ class PhpHttpRequest extends MWHttpRequest {
                        $options['content'] = $this->postData;
                }
 
-               $oldTimeout = false;
-               if ( version_compare( '5.2.1', phpversion(), '>' ) ) {
-                       $oldTimeout = ini_set( 'default_socket_timeout', $this->timeout );
-               } else {
-                       $options['timeout'] = $this->timeout;
-               }
+               $options['timeout'] = $this->timeout;
 
                $context = stream_context_create( array( 'http' => $options ) );
 
@@ -778,10 +773,6 @@ class PhpHttpRequest extends MWHttpRequest {
                        }
                } while ( true );
 
-               if ( $oldTimeout !== false ) {
-                       ini_set( 'default_socket_timeout', $oldTimeout );
-               }
-
                $this->setStatus();
 
                if ( $fh === false ) {