Fixed BloomCache handling of network partitions
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 20 Nov 2014 09:04:53 +0000 (01:04 -0800)
committerOri.livneh <ori@wikimedia.org>
Thu, 20 Nov 2014 09:11:09 +0000 (09:11 +0000)
* As documented, it should return true on error, so that DB is
  checked if the filter is down.

Change-Id: I883fafc9f5f3a84f85207de6e916f1630c78d1a4

includes/cache/bloom/BloomCache.php

index a15b461..627f4f0 100644 (file)
@@ -102,7 +102,7 @@ abstract class BloomCache {
                                $status = $this->getStatus( $virtualKey );
                                if ( $status == false ) {
                                        wfDebug( "Could not query virtual bloom filter '$virtualKey'." );
-                                       return null;
+                                       return true;
                                }
 
                                $useFilter = call_user_func_array(