[JobQueue] Improved de-duplication stat calls.
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 9 Jan 2013 18:29:23 +0000 (10:29 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 9 Jan 2013 18:29:49 +0000 (10:29 -0800)
Change-Id: Ib8e3452c9e42b20389c515e7dd8e030b0900497d

includes/job/JobQueueDB.php

index 7f4300c..8c81cf0 100644 (file)
@@ -181,6 +181,8 @@ class JobQueueDB extends JobQueue {
                                                $dbw->insert( 'job', $rowBatch, __METHOD__ );
                                        }
                                        wfIncrStats( 'job-insert', count( $rows ) );
+                                       wfIncrStats( 'job-insert-duplicate',
+                                               count( $rowSet ) + count( $rowList ) - count( $rows ) );
                                } catch ( DBError $e ) {
                                        if ( $atomic ) {
                                                $dbw->rollback( __METHOD__ );
@@ -245,7 +247,7 @@ class JobQueueDB extends JobQueue {
                        $job->id = $row->job_id; // XXX: work around broken subclasses
                        // Flag this job as an old duplicate based on its "root" job...
                        if ( $this->isRootJobOldDuplicate( $job ) ) {
-                               wfIncrStats( 'job-duplicate' );
+                               wfIncrStats( 'job-pop-duplicate' );
                                $job = DuplicateJob::newFromJob( $job ); // convert to a no-op
                        }
                        break; // done