It is good practice to specifiy the fields in a select
Change-Id: I3faa568ed6311a585da9161eccd8da3d065da250
foreach( $this->ids as $timestamp ) {
$archiveNames[] = $timestamp . '!' . $this->title->getDBkey();
}
foreach( $this->ids as $timestamp ) {
$archiveNames[] = $timestamp . '!' . $this->title->getDBkey();
}
- return $db->select( 'oldimage', '*',
+ return $db->select(
+ 'oldimage',
+ OldLocalFile::selectFields(),
array(
'oi_name' => $this->title->getDBkey(),
'oi_archive_name' => $archiveNames
array(
'oi_name' => $this->title->getDBkey(),
'oi_archive_name' => $archiveNames