Deprecate overriding SearchEngine::search*
authorErik Bernhardson <ebernhardson@wikimedia.org>
Thu, 10 May 2018 20:52:47 +0000 (13:52 -0700)
committerErik Bernhardson <ebernhardson@wikimedia.org>
Tue, 15 May 2018 15:28:28 +0000 (08:28 -0700)
commitfdc133ef1a249568f69df6b83d7e154c2103e10e
tree7d4a75c21343338e75be4a3222f1094c7efae2ff
parent8eb6cf585c5fb3d7dd5f014bac27518959512b98
Deprecate overriding SearchEngine::search*

The plan is to convert these methods into final, considering
it a removal under the deprecation policy. By making entry
points into the search engine final we provide a guaranteed
point where generic handling can be applied to all search engines.

The first use case for this generic handling is pushing pagination
via overfetch into the SearchEngine class instead of re-implementing
an overfetch in individual parts of the code that perform searches.

Change-Id: I3426d6a2f32d8b368b044b154e1cb70dac007c62
RELEASE-NOTES-1.32
includes/search/SearchEngine.php
includes/search/SearchMssql.php
includes/search/SearchMySQL.php
includes/search/SearchOracle.php
includes/search/SearchPostgres.php
includes/search/SearchResultSet.php
includes/search/SearchSqlite.php