Introduce SkinFactory
authorKunal Mehta <legoktm@gmail.com>
Sat, 9 Aug 2014 12:36:35 +0000 (13:36 +0100)
committerKunal Mehta <legoktm@gmail.com>
Sat, 9 Aug 2014 20:40:54 +0000 (21:40 +0100)
commiteb37e9d1ffb2ebf3e847ae948b8f30455b1f3176
tree8b3f3dba43b4d41ee1c2e10370082c25e822102b
parentcccd402c41af6822e56d9db5ea6893c83a47ca18
Introduce SkinFactory

Modeled similar to ConfigFactory, this lets skins
register themselves via a callback, allowing for
proper dependency injection.

Loading via $wgValidSkinNames is still supported,
but considered "legacy", not deprecated though.

Skin::newFromKey is now deprecated (and had only
one caller in an extension, which I'll update
afterwards).

Change-Id: I1960483f87c2ef55c994545239b728fa376f17f4
16 files changed:
includes/AutoLoader.php
includes/Skin.php [deleted file]
includes/SkinFallback.php [deleted file]
includes/SkinFallbackTemplate.php [deleted file]
includes/SkinTemplate.php [deleted file]
includes/context/RequestContext.php
includes/skins/Skin.php [new file with mode: 0644]
includes/skins/SkinException.php [new file with mode: 0644]
includes/skins/SkinFactory.php [new file with mode: 0644]
includes/skins/SkinFallback.php [new file with mode: 0644]
includes/skins/SkinFallbackTemplate.php [new file with mode: 0644]
includes/skins/SkinTemplate.php [new file with mode: 0644]
tests/phpunit/includes/OutputPageTest.php
tests/phpunit/includes/SkinTemplateTest.php [deleted file]
tests/phpunit/includes/skins/SkinFactoryTest.php [new file with mode: 0644]
tests/phpunit/includes/skins/SkinTemplateTest.php [new file with mode: 0644]