Actually, Sanitizer::encodeAttribute() was broken, so my last fix didn't actually...
authorAryeh Gregor <simetrical@users.mediawiki.org>
Mon, 24 Sep 2007 12:54:00 +0000 (12:54 +0000)
committerAryeh Gregor <simetrical@users.mediawiki.org>
Mon, 24 Sep 2007 12:54:00 +0000 (12:54 +0000)
commitdbbc637a52ff2c9dd37bfbf3f1d132fa01271446
tree0947cff5ddc72cc0231a019479fc552c5953f257
parent5cdf3c787340847aab3b722e730b660e2c47ea9e
Actually, Sanitizer::encodeAttribute() was broken, so my last fix didn't actually work, there was still HTML injection.  Fixed it so it encodes single quotes too.  The only other things in core that used it (or its friend safeEncodeAttribute) appear to be utility functions in Xml and Sanitizer::fixTagAttributes, all of which use double quotes.  However, it's possible that the SemanticForms extension may be affected -- I didn't look closely, but it seems to safely use double-quotes.
includes/Sanitizer.php