Fix a bug in the installer caused by r77487 creating installer sql statements like...
authorDaniel Friesen <dantman@users.mediawiki.org>
Sat, 4 Dec 2010 09:27:02 +0000 (09:27 +0000)
committerDaniel Friesen <dantman@users.mediawiki.org>
Sat, 4 Dec 2010 09:27:02 +0000 (09:27 +0000)
commitda469e3abe8a5824e02605e0393dcf4f2354490a
treed020eb35a0e013bd151790a5e4dc3de1eda404f8
parent9fdd07b82d106eb0f931f103bd3442654aee69c0
Fix a bug in the installer caused by r77487 creating installer sql statements like "GRANT ALL PRIVILEGES ON `'dbname'`.* TO ''tablename''@'%" while improving the database independence of replaceVars.

* Drop unused and likely broken /*$var*/` -> `$var syntax
* Replace {$var} with '{$var}' and `{$var}` handling that uses relevant database independent quoting ({$var} without surrouding quotes are never used)
* Give the generic/mysql class a proper quote_ident implementation
* Fix the unused Oracle and Sqlite quote_ident implementations which are potential sql injections if used
* Split common variable replacemnt code off to a replaceGlobalVars and make the generic and oracle code use it instead of duplicating the same code as each other
includes/db/Database.php
includes/db/DatabaseOracle.php
includes/db/DatabasePostgres.php
includes/db/DatabaseSqlite.php