Fix INSERT options for PostgreSQL for INSERT+SELECT
authorsaper <saper@saper.info>
Mon, 18 Jun 2012 18:39:08 +0000 (20:39 +0200)
committersaper <saper@saper.info>
Mon, 18 Jun 2012 18:39:08 +0000 (20:39 +0200)
commitc3fe42d1c3c07be748a12427f22cd8ba503a1aeb
treede4e9856d049922d21642146885043f2b16285b2
parent8a84f7a20e6ed29341e0c45178646ba177a7eee3
Fix INSERT options for PostgreSQL for INSERT+SELECT

Fix handling of $insertOptions in
DatabasePostgres::insertSelect

Looks like this change:

https://gerrit.wikimedia.org/r/#/c/3962/
(or 646a9490f74f3841803299a4e4d2d5677c5f1bba)

mishandled badly INSERT IGNORE (instead of
silently broken support for it it introduced
PHP error).

Looks like we have no unit test to cover
the use of Database::insertSelect in the code.

Change-Id: I4f7d8c9bd9e413d8ffa23c1d0c0628a25c28d45c
includes/db/DatabasePostgres.php