X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=blobdiff_plain;f=img_auth.php;h=9b330ce2d4543bf124e60a08a36b167e746208a7;hb=8148f72d4cfebb1cdef2783dc96220cf7bdbc0ae;hp=02240ceea9e124084831f7fb8befe27bf2148bbc;hpb=24babf696a57e7828522c7d5c9e4cdcada5433ad;p=lhc%2Fweb%2Fwiklou.git diff --git a/img_auth.php b/img_auth.php index 02240ceea9..9b330ce2d4 100644 --- a/img_auth.php +++ b/img_auth.php @@ -1,173 +1,127 @@ getNsText( NS_IMAGE ) . ":" . basename( $_SERVER['PATH_INFO'] ); - -# Check if the filename is in the correct directory -if ( substr( $filename, 0, strlen( $realUploadDirectory ) ) != $realUploadDirectory ) { - wfForbidden(); -} -if ( is_array( $wgWhitelistRead ) && !in_array( $imageName, $wgWhitelistRead ) && !$wgUser->getID() ) { - wfForbidden(); -} +/** + * Image authorisation script + * + * To use this, see http://www.mediawiki.org/wiki/Manual:Image_Authorization + * + * - Set $wgUploadDirectory to a non-public directory (not web accessible) + * - Set $wgUploadPath to point to this file + * + * Optional Parameters + * + * - Set $wgImgAuthDetails = true if you want the reason the access was denied messages to be displayed + * instead of just the 403 error (doesn't work on IE anyway), otherwise will only appear in error logs + * - Set $wgImgAuthPublicTest false if you don't want to just check and see if all are public + * must be set to false if using specific restrictions such as LockDown or NSFileRepo + * + * For security reasons, you usually don't want your user to know *why* access was denied, just that it was. + * If you want to change this, you can set $wgImgAuthDetails to 'true' in localsettings.php and it will give the user the reason + * why access was denied. + * + * Your server needs to support PATH_INFO; CGI-based configurations usually don't. + * + * @file + * + **/ -# Write file -$type = wfGetType( $filename ); -if ( $type ) { - header("Content-type: $type"); +define( 'MW_NO_OUTPUT_COMPRESSION', 1 ); +if ( isset( $_SERVER['MW_COMPILED'] ) ) { + require ( 'phase3/includes/WebStart.php' ); +} else { + require ( dirname( __FILE__ ) . '/includes/WebStart.php' ); } +wfProfileIn( 'img_auth.php' ); -readfile( $filename ); - -function wfGetType( $filename ) { - # There's probably a better way to do this - $types = << -

Access denied

-

You need to log in to access files on this server

-"; - exit; +$matches = WebRequest::getPathInfo(); +$path = $matches['title']; + +// Check for bug 28235: QUERY_STRING overriding the correct extension +$dotPos = strrpos( $path, '.' ); +$whitelist = array(); +if ( $dotPos !== false ) { + $whitelist[] = substr( $path, $dotPos + 1 ); +} +if ( !$wgRequest->checkUrlExtension( $whitelist ) ) +{ + return; } -?> +$filename = realpath( $wgUploadDirectory . $path ); +$realUpload = realpath( $wgUploadDirectory ); + +// Basic directory traversal check +if( substr( $filename, 0, strlen( $realUpload ) ) != $realUpload ) + wfForbidden('img-auth-accessdenied','img-auth-notindir'); + +// Extract the file name and chop off the size specifier +// (e.g. 120px-Foo.png => Foo.png) +$name = wfBaseName( $path ); +if( preg_match( '!\d+px-(.*)!i', $name, $m ) ) + $name = $m[1]; + +// Check to see if the file exists +if( !file_exists( $filename ) ) + wfForbidden('img-auth-accessdenied','img-auth-nofile',$filename); + +// Check to see if tried to access a directory +if( is_dir( $filename ) ) + wfForbidden('img-auth-accessdenied','img-auth-isdir',$filename); + + +$title = Title::makeTitleSafe( NS_FILE, $name ); + +// See if could create the title object +if( !$title instanceof Title ) + wfForbidden('img-auth-accessdenied','img-auth-badtitle',$name); + +// Run hook +if (!wfRunHooks( 'ImgAuthBeforeStream', array( &$title, &$path, &$name, &$result ) ) ) + wfForbidden($result[0],$result[1],array_slice($result,2)); + +// Check user authorization for this title +// UserCanRead Checks Whitelist too +if( !$title->userCanRead() ) + wfForbidden('img-auth-accessdenied','img-auth-noread',$name); + +// Stream the requested file +wfDebugLog( 'img_auth', "Streaming `".$filename."`." ); +StreamFile::stream( $filename, array( 'Cache-Control: private', 'Vary: Cookie' ) ); +wfLogProfilingData(); + +/** + * Issue a standard HTTP 403 Forbidden header ($msg1-a message index, not a message) and an + * error message ($msg2, also a message index), (both required) then end the script + * subsequent arguments to $msg2 will be passed as parameters only for replacing in $msg2 + */ +function wfForbidden($msg1,$msg2) { + global $wgImgAuthDetails; + $args = func_get_args(); + array_shift( $args ); + array_shift( $args ); + $MsgHdr = htmlspecialchars(wfMsg($msg1)); + $detailMsg = (htmlspecialchars(wfMsg(($wgImgAuthDetails ? $msg2 : 'badaccess-group0'),$args))); + wfDebugLog('img_auth', "wfForbidden Hdr:".wfMsgExt( $msg1, array('language' => 'en'))." Msg: ". + wfMsgExt($msg2,array('language' => 'en'),$args)); + header( 'HTTP/1.0 403 Forbidden' ); + header( 'Cache-Control: no-cache' ); + header( 'Content-Type: text/html; charset=utf-8' ); + echo << + +

$MsgHdr

+

$detailMsg

+ + +ENDS; + wfLogProfilingData(); + exit(); +}