revert r106095, fix apparently not this simple
[lhc/web/wiklou.git] / includes / specials / SpecialContributions.php
index 1d0eed7..aa97ad8 100644 (file)
@@ -36,85 +36,89 @@ class SpecialContributions extends SpecialPage {
        }
 
        public function execute( $par ) {
-               global $wgUser, $wgOut, $wgRequest;
-
                $this->setHeaders();
                $this->outputHeader();
-               $wgOut->addModuleStyles( 'mediawiki.special' );
+               $out = $this->getOutput();
+               $out->addModuleStyles( 'mediawiki.special' );
 
                $this->opts = array();
+               $request = $this->getRequest();
 
                if( $par == 'newbies' ) {
                        $target = 'newbies';
                        $this->opts['contribs'] = 'newbie';
-               } elseif( isset( $par ) ) {
+               } elseif( $par !== null ) {
                        $target = $par;
                } else {
-                       $target = $wgRequest->getVal( 'target' );
+                       $target = $request->getVal( 'target' );
                }
 
                // check for radiobox
-               if( $wgRequest->getVal( 'contribs' ) == 'newbie' ) {
+               if( $request->getVal( 'contribs' ) == 'newbie' ) {
                        $target = 'newbies';
                        $this->opts['contribs'] = 'newbie';
+               } else {
+                       $this->opts['contribs'] = 'user';
                }
 
-               $this->opts['deletedOnly'] = $wgRequest->getBool( 'deletedOnly' );
+               $this->opts['deletedOnly'] = $request->getBool( 'deletedOnly' );
 
                if( !strlen( $target ) ) {
-                       $wgOut->addHTML( $this->getForm() );
+                       $out->addHTML( $this->getForm() );
                        return;
                }
 
-               $this->opts['limit'] = $wgRequest->getInt( 'limit', $wgUser->getOption('rclimit') );
+               $user = $this->getUser();
+
+               $this->opts['limit'] = $request->getInt( 'limit', $user->getOption('rclimit') );
                $this->opts['target'] = $target;
-               $this->opts['topOnly'] = $wgRequest->getBool( 'topOnly' );
+               $this->opts['topOnly'] = $request->getBool( 'topOnly' );
 
-               $nt = Title::makeTitleSafe( NS_USER, $target );
-               if( !$nt ) {
-                       $wgOut->addHTML( $this->getForm() );
+               $userObj = User::newFromName( $target, false );
+               if( !$userObj ) {
+                       $out->addHTML( $this->getForm() );
                        return;
                }
-               $id = User::idFromName( $nt->getText() );
+               $nt = $userObj->getUserPage();
+               $id = $userObj->getID();
 
-               if( $target != 'newbies' ) {
+               if( $this->opts['contribs'] != 'newbie' ) {
                        $target = $nt->getText();
-                       $wgOut->setSubtitle( $this->contributionsSub( $nt, $id ) );
-                       $wgOut->setHTMLTitle( wfMsg( 'pagetitle', wfMsgExt( 'contributions-title', array( 'parsemag' ),$target ) ) );
-                       $user = User::newFromName( $target, false );
-                       if ( is_object( $user ) ) {
-                               $this->getSkin()->setRelevantUser( $user );
-                       }
+                       $out->addSubtitle( $this->contributionsSub( $userObj ) );
+                       $out->setHTMLTitle( $this->msg( 'pagetitle', wfMsgExt( 'contributions-title', array( 'parsemag' ), $target ) ) );
+                       $this->getSkin()->setRelevantUser( $userObj );
                } else {
-                       $wgOut->setSubtitle( wfMsgHtml( 'sp-contributions-newbies-sub') );
-                       $wgOut->setHTMLTitle( wfMsg( 'pagetitle', wfMsg( 'sp-contributions-newbies-title' ) ) );
+                       $out->addSubtitle( $this->msg( 'sp-contributions-newbies-sub') );
+                       $out->setHTMLTitle( $this->msg( 'pagetitle', wfMsg( 'sp-contributions-newbies-title' ) ) );
                }
 
-               if( ( $ns = $wgRequest->getVal( 'namespace', null ) ) !== null && $ns !== '' ) {
+               if( ( $ns = $request->getVal( 'namespace', null ) ) !== null && $ns !== '' ) {
                        $this->opts['namespace'] = intval( $ns );
                } else {
                        $this->opts['namespace'] = '';
                }
 
-               $this->opts['tagFilter'] = (string) $wgRequest->getVal( 'tagFilter' );
+               $this->opts['nsInvert'] = (bool) $request->getVal( 'nsInvert' );
+
+               $this->opts['tagfilter'] = (string) $request->getVal( 'tagfilter' );
 
                // Allows reverts to have the bot flag in recent changes. It is just here to
                // be passed in the form at the top of the page
-               if( $wgUser->isAllowed( 'markbotedits' ) && $wgRequest->getBool( 'bot' ) ) {
+               if( $user->isAllowed( 'markbotedits' ) && $request->getBool( 'bot' ) ) {
                        $this->opts['bot'] = '1';
                }
 
-               $skip = $wgRequest->getText( 'offset' ) || $wgRequest->getText( 'dir' ) == 'prev';
+               $skip = $request->getText( 'offset' ) || $request->getText( 'dir' ) == 'prev';
                # Offset overrides year/month selection
                if( $skip ) {
                        $this->opts['year'] = '';
                        $this->opts['month'] = '';
                } else {
-                       $this->opts['year'] = $wgRequest->getIntOrNull( 'year' );
-                       $this->opts['month'] = $wgRequest->getIntOrNull( 'month' );
+                       $this->opts['year'] = $request->getIntOrNull( 'year' );
+                       $this->opts['month'] = $request->getIntOrNull( 'month' );
                }
 
-               $feedType = $wgRequest->getVal( 'feed' );
+               $feedType = $request->getVal( 'feed' );
                if( $feedType ) {
                        // Maintain some level of backwards compatability
                        // If people request feeds using the old parameters, redirect to API
@@ -129,8 +133,8 @@ class SpecialContributions extends SpecialPage {
                        if ( $this->opts['deletedOnly'] ) {
                                $apiParams['deletedonly'] = true;
                        }
-                       if ( $this->opts['tagFilter'] !== '' ) {
-                               $apiParams['tagfilter'] = $this->opts['tagFilter'];
+                       if ( $this->opts['tagfilter'] !== '' ) {
+                               $apiParams['tagfilter'] = $this->opts['tagfilter'];
                        }
                        if ( $this->opts['namespace'] !== '' ) {
                                $apiParams['namespace'] = $this->opts['namespace'];
@@ -144,7 +148,7 @@ class SpecialContributions extends SpecialPage {
 
                        $url = wfScript( 'api' ) . '?' . wfArrayToCGI( $apiParams );
 
-                       $wgOut->redirect( $url, '301' );
+                       $out->redirect( $url, '301' );
                        return;
                }
 
@@ -153,47 +157,48 @@ class SpecialContributions extends SpecialPage {
 
                if ( wfRunHooks( 'SpecialContributionsBeforeMainOutput', array( $id ) ) ) {
 
-                       $wgOut->addHTML( $this->getForm() );
+                       $out->addHTML( $this->getForm() );
 
                        $pager = new ContribsPager( array(
                                'target' => $target,
+                               'contribs' => $this->opts['contribs'],
                                'namespace' => $this->opts['namespace'],
                                'year' => $this->opts['year'],
                                'month' => $this->opts['month'],
                                'deletedOnly' => $this->opts['deletedOnly'],
                                'topOnly' => $this->opts['topOnly'],
+                               'nsInvert' => $this->opts['nsInvert'],
                        ) );
                        if( !$pager->getNumRows() ) {
-                               $wgOut->addWikiMsg( 'nocontribs', $target );
+                               $out->addWikiMsg( 'nocontribs', $target );
                        } else {
                                # Show a message about slave lag, if applicable
                                $lag = wfGetLB()->safeGetLag( $pager->getDatabase() );
                                if( $lag > 0 )
-                                       $wgOut->showLagWarning( $lag );
+                                       $out->showLagWarning( $lag );
 
-                               $wgOut->addHTML(
+                               $out->addHTML(
                                        '<p>' . $pager->getNavigationBar() . '</p>' .
                                        $pager->getBody() .
                                        '<p>' . $pager->getNavigationBar() . '</p>'
                                );
                        }
-                       $wgOut->preventClickjacking( $pager->getPreventClickjacking() );
+                       $out->preventClickjacking( $pager->getPreventClickjacking() );
 
                        # Show the appropriate "footer" message - WHOIS tools, etc.
-                       if( $target != 'newbies' ) {
+                       if( $this->opts['contribs'] != 'newbie' ) {
                                $message = 'sp-contributions-footer';
                                if ( IP::isIPAddress( $target ) ) {
                                        $message = 'sp-contributions-footer-anon';
                                } else {
-                                       $user = User::newFromName( $target );
-                                       if ( !$user || $user->isAnon() ) {
+                                       if ( $userObj->isAnon() ) {
                                                // No message for non-existing users
                                                return;
                                        }
                                }
 
                                if( !wfMessage( $message, $target )->isDisabled() ) {
-                                       $wgOut->wrapWikiMsg(
+                                       $out->wrapWikiMsg(
                                                "<div class='mw-contributions-footer'>\n$1\n</div>",
                                                array( $message, $target ) );
                                }
@@ -203,33 +208,29 @@ class SpecialContributions extends SpecialPage {
 
        /**
         * Generates the subheading with links
-        * @param $nt Title object for the target
-        * @param $id Integer: User ID for the target
+        * @param $userObj User object for the target
         * @return String: appropriately-escaped HTML to be output literally
         * @todo FIXME: Almost the same as getSubTitle in SpecialDeletedContributions.php. Could be combined.
         */
-       protected function contributionsSub( $nt, $id ) {
-               global $wgLang, $wgUser, $wgOut;
-
-               $sk = $this->getSkin();
-
-               if ( $id === null ) {
-                       $user = htmlspecialchars( $nt->getText() );
+       protected function contributionsSub( $userObj ) {
+               if ( $userObj->isAnon() ) {
+                       $user = htmlspecialchars( $userObj->getName() );
                } else {
-                       $user = $sk->link( $nt, htmlspecialchars( $nt->getText() ) );
+                       $user = Linker::link( $userObj->getUserPage(), htmlspecialchars( $userObj->getName() ) );
                }
-               $userObj = User::newFromName( $nt->getText(), /* check for username validity not needed */ false );
-               $talk = $nt->getTalkPage();
+               $nt = $userObj->getUserPage();
+               $talk = $userObj->getTalkPage();
                if( $talk ) {
-                       $tools = self::getUserLinks( $nt, $talk, $userObj, $wgUser );
-                       $links = $wgLang->pipeList( $tools );
+                       $tools = self::getUserLinks( $nt, $talk, $userObj, $this->getUser() );
+                       $links = $this->getLanguage()->pipeList( $tools );
 
                        // Show a note if the user is blocked and display the last block log entry.
                        if ( $userObj->isBlocked() ) {
+                               $out = $this->getOutput(); // showLogExtract() wants first parameter by reference
                                LogEventsList::showLogExtract(
-                                       $wgOut,
+                                       $out,
                                        'block',
-                                       $nt->getPrefixedText(),
+                                       $nt,
                                        '',
                                        array(
                                                'lim' => 1,
@@ -238,9 +239,9 @@ class SpecialContributions extends SpecialPage {
                                                        $userObj->isAnon() ?
                                                                'sp-contributions-blocked-notice-anon' :
                                                                'sp-contributions-blocked-notice',
-                                                       $nt->getText() # Support GENDER in 'sp-contributions-blocked-notice'
+                                                       $userObj->getName() # Support GENDER in 'sp-contributions-blocked-notice'
                                                ),
-                                               'offset' => '' # don't use $wgRequest parameter offset
+                                               'offset' => '' # don't use WebRequest parameter offset
                                        )
                                );
                        }
@@ -250,10 +251,11 @@ class SpecialContributions extends SpecialPage {
                // languages that want to put the "for" bit right after $user but before
                // $links.  If 'contribsub' is around, use it for reverse compatibility,
                // otherwise use 'contribsub2'.
-               if( wfEmptyMsg( 'contribsub' ) ) {
-                       return wfMsgHtml( 'contribsub2', $user, $links );
+               $oldMsg = $this->msg( 'contribsub' );
+               if ( $oldMsg->exists() ) {
+                       return $oldMsg->rawParams( "$user ($links)" );
                } else {
-                       return wfMsgHtml( 'contribsub', "$user ($links)" );
+                       return $this->msg( 'contribsub2' )->rawParams( $user, $links );
                }
        }
 
@@ -262,36 +264,35 @@ class SpecialContributions extends SpecialPage {
         * @param $userpage Title: Target user page
         * @param $talkpage Title: Talk page
         * @param $target User: Target user object
-        * @param $subject User: The viewing user ($wgUser is still checked in some cases, like userrights page!!)
+        * @param $subject User: The viewing user ($wgUser might be still checked in some cases)
         */
        public static function getUserLinks( Title $userpage, Title $talkpage, User $target, User $subject ) {
 
-               $sk = $subject->getSkin();
                $id = $target->getId();
                $username = $target->getName();
 
-               $tools[] = $sk->link( $talkpage, wfMsgHtml( 'sp-contributions-talk' ) );
+               $tools[] = Linker::link( $talkpage, wfMsgHtml( 'sp-contributions-talk' ) );
 
                if( ( $id !== null ) || ( $id === null && IP::isIPAddress( $username ) ) ) {
                        if( $subject->isAllowed( 'block' ) ) { # Block / Change block / Unblock links
                                if ( $target->isBlocked() ) {
-                                       $tools[] = $sk->linkKnown( # Change block link
+                                       $tools[] = Linker::linkKnown( # Change block link
                                                SpecialPage::getTitleFor( 'Block', $username ),
                                                wfMsgHtml( 'change-blocklink' )
                                        );
-                                       $tools[] = $sk->linkKnown( # Unblock link
+                                       $tools[] = Linker::linkKnown( # Unblock link
                                                SpecialPage::getTitleFor( 'Unblock', $username ),
                                                wfMsgHtml( 'unblocklink' )
                                        );
                                } else { # User is not blocked
-                                       $tools[] = $sk->linkKnown( # Block link
+                                       $tools[] = Linker::linkKnown( # Block link
                                                SpecialPage::getTitleFor( 'Block', $username ),
                                                wfMsgHtml( 'blocklink' )
                                        );
                                }
                        }
                        # Block log link
-                       $tools[] = $sk->linkKnown(
+                       $tools[] = Linker::linkKnown(
                                SpecialPage::getTitleFor( 'Log', 'block' ),
                                wfMsgHtml( 'sp-contributions-blocklog' ),
                                array(),
@@ -301,20 +302,20 @@ class SpecialContributions extends SpecialPage {
                        );
                }
                # Uploads
-               $tools[] = $sk->linkKnown(
+               $tools[] = Linker::linkKnown(
                        SpecialPage::getTitleFor( 'Listfiles', $username ),
                        wfMsgHtml( 'sp-contributions-uploads' )
                );
 
                # Other logs link
-               $tools[] = $sk->linkKnown(
+               $tools[] = Linker::linkKnown(
                        SpecialPage::getTitleFor( 'Log', $username ),
                        wfMsgHtml( 'sp-contributions-logs' )
                );
 
                # Add link to deleted user contributions for priviledged users
-               if( $subject->isAllowed( 'deletedhistory' ) && !$subject->isBlocked() ) {
-                       $tools[] = $sk->linkKnown(
+               if( $subject->isAllowed( 'deletedhistory' ) ) {
+                       $tools[] = Linker::linkKnown(
                                SpecialPage::getTitleFor( 'DeletedContributions', $username ),
                                wfMsgHtml( 'sp-contributions-deleted' )
                        );
@@ -322,8 +323,9 @@ class SpecialContributions extends SpecialPage {
 
                # Add a link to change user rights for privileged users
                $userrightsPage = new UserrightsPage();
+               $userrightsPage->getContext()->setUser( $subject );
                if( $id !== null && $userrightsPage->userCanChangeRights( $target ) ) {
-                       $tools[] = $sk->linkKnown(
+                       $tools[] = Linker::linkKnown(
                                SpecialPage::getTitleFor( 'Userrights', $username ),
                                wfMsgHtml( 'sp-contributions-userrights' )
                        );
@@ -338,7 +340,7 @@ class SpecialContributions extends SpecialPage {
         * @return String: HTML fragment
         */
        protected function getForm() {
-               global $wgScript, $wgMiserMode;
+               global $wgScript;
 
                $this->opts['title'] = $this->getTitle()->getPrefixedText();
                if( !isset( $this->opts['target'] ) ) {
@@ -351,6 +353,10 @@ class SpecialContributions extends SpecialPage {
                        $this->opts['namespace'] = '';
                }
 
+               if( !isset( $this->opts['nsInvert'] ) ) {
+                       $this->opts['nsInvert'] = '';
+               }
+
                if( !isset( $this->opts['contribs'] ) ) {
                        $this->opts['contribs'] = 'user';
                }
@@ -367,8 +373,8 @@ class SpecialContributions extends SpecialPage {
                        $this->opts['target'] = '';
                }
 
-               if( !isset( $this->opts['tagFilter'] ) ) {
-                       $this->opts['tagFilter'] = '';
+               if( !isset( $this->opts['tagfilter'] ) ) {
+                       $this->opts['tagfilter'] = '';
                }
 
                if( !isset( $this->opts['topOnly'] ) ) {
@@ -378,7 +384,7 @@ class SpecialContributions extends SpecialPage {
                $f = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript, 'class' => 'mw-contributions-form' ) );
 
                # Add hidden params for tracking except for parameters in $skipParameters
-               $skipParameters = array( 'namespace', 'deletedOnly', 'target', 'contribs', 'year', 'month', 'topOnly' );
+               $skipParameters = array( 'namespace', 'nsInvert', 'deletedOnly', 'target', 'contribs', 'year', 'month', 'topOnly' );
                foreach ( $this->opts as $name => $value ) {
                        if( in_array( $name, $skipParameters ) ) {
                                continue;
@@ -386,14 +392,7 @@ class SpecialContributions extends SpecialPage {
                        $f .= "\t" . Html::hidden( $name, $value ) . "\n";
                }
 
-               $tagFilter = ChangeTags::buildTagFilterSelector( $this->opts['tagFilter'] );
-
-               $fNS = '';
-               if ( !$wgMiserMode ) {
-                       $fNS = Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
-                               Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' . Xml::namespaceSelector( $this->opts['namespace'], '' )
-                       );
-               }
+               $tagFilter = ChangeTags::buildTagFilterSelector( $this->opts['tagfilter'] );
 
                $f .=   Xml::fieldset( wfMsg( 'sp-contributions-search' ) ) .
                        Xml::radioLabel( wfMsgExt( 'sp-contributions-newbies', array( 'parsemag' ) ),
@@ -404,7 +403,11 @@ class SpecialContributions extends SpecialPage {
                                'size' => '20',
                                'required' => ''
                        ) + ( $this->opts['target'] ? array() : array( 'autofocus' ) ) ) . ' '.
-                       $fNS.
+                       Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
+                               Xml::label( wfMsg( 'namespace' ), 'namespace' ) . ' ' .
+                               Xml::namespaceSelector( $this->opts['namespace'], '' )
+                       ) .
+                       Xml::checkLabel( wfMsg('invert'), 'nsInvert', 'nsInvert', $this->opts['nsInvert'] ) . '&#160;' .
                        Xml::checkLabel( wfMsg( 'history-show-deleted' ),
                                'deletedOnly', 'mw-show-deleted-only', $this->opts['deletedOnly'] ) . '<br />' .
                        Xml::tags( 'p', null, Xml::checkLabel( wfMsg( 'sp-contributions-toponly' ),
@@ -444,8 +447,10 @@ class ContribsPager extends ReverseChronologicalPager {
                }
 
                $this->target = isset( $options['target'] ) ? $options['target'] : '';
+               $this->contribs = isset( $options['contribs'] ) ? $options['contribs'] : 'users';
                $this->namespace = isset( $options['namespace'] ) ? $options['namespace'] : '';
-               $this->tagFilter = isset( $options['tagFilter'] ) ? $options['tagFilter'] : false;
+               $this->tagFilter = isset( $options['tagfilter'] ) ? $options['tagfilter'] : false;
+               $this->nsInvert = isset( $options['nsInvert'] ) ? $options['nsInvert'] : false;
 
                $this->deletedOnly = !empty( $options['deletedOnly'] );
                $this->topOnly = !empty( $options['topOnly'] );
@@ -463,36 +468,38 @@ class ContribsPager extends ReverseChronologicalPager {
                return $query;
        }
 
-       function getTitle() {
-               return SpecialPage::getTitleFor( 'Contributions' );
-       }
-
        function getQueryInfo() {
-               global $wgUser;
                list( $tables, $index, $userCond, $join_cond ) = $this->getUserCond();
 
+               $user = $this->getUser();
                $conds = array_merge( $userCond, $this->getNamespaceCond() );
+
                // Paranoia: avoid brute force searches (bug 17342)
-               if( !$wgUser->isAllowed( 'deletedhistory' ) || $wgUser->isBlocked() ) {
+               if( !$user->isAllowed( 'deletedhistory' ) ) {
                        $conds[] = $this->mDb->bitAnd('rev_deleted',Revision::DELETED_USER) . ' = 0';
-               } elseif( !$wgUser->isAllowed( 'suppressrevision' ) ) {
+               } elseif( !$user->isAllowed( 'suppressrevision' ) ) {
                        $conds[] = $this->mDb->bitAnd('rev_deleted',Revision::SUPPRESSED_USER) .
                                ' != ' . Revision::SUPPRESSED_USER;
                }
-               $join_cond['page'] = array( 'INNER JOIN', 'page_id=rev_page' );
+
+               # Don't include orphaned revisions
+               $join_cond['page'] = Revision::pageJoinCond();
+               # Get the current user name for accounts
+               $join_cond['user'] = Revision::userJoinCond();
 
                $queryInfo = array(
-                       'tables' => $tables,
-                       'fields' => array(
-                               'page_namespace', 'page_title', 'page_is_new', 'page_latest', 'page_is_redirect',
-                               'page_len','rev_id', 'rev_page', 'rev_text_id', 'rev_timestamp', 'rev_comment',
-                               'rev_minor_edit', 'rev_user', 'rev_user_text', 'rev_parent_id', 'rev_deleted',
-                               'rc_old_len', 'rc_new_len'
+                       'tables'     => $tables,
+                       'fields'     => array_merge(
+                               Revision::selectFields(),
+                               Revision::selectUserFields(),
+                               array( 'page_namespace', 'page_title', 'page_is_new',
+                                       'page_latest', 'page_is_redirect', 'page_len' )
                        ),
-                       'conds' => $conds,
-                       'options' => array( 'USE INDEX' => array('revision' => $index) ),
+                       'conds'      => $conds,
+                       'options'    => array( 'USE INDEX' => array( 'revision' => $index ) ),
                        'join_conds' => $join_cond
                );
+
                ChangeTags::modifyDisplayQuery(
                        $queryInfo['tables'],
                        $queryInfo['fields'],
@@ -506,24 +513,26 @@ class ContribsPager extends ReverseChronologicalPager {
                return $queryInfo;
        }
 
-       function getUserCond() {
+       function getUserCond() {
                $condition = array();
                $join_conds = array();
-
-               if( $this->target == 'newbies' ) {
-                       $tables = array( 'recentchanges', 'user_groups', 'page', 'revision' );
+               $tables = array( 'revision', 'page', 'user' );
+               if( $this->contribs == 'newbie' ) {
+                       $tables[] = 'user_groups';
                        $max = $this->mDb->selectField( 'user', 'max(user_id)', false, __METHOD__ );
                        $condition[] = 'rev_user >' . (int)($max - $max / 100);
                        $condition[] = 'ug_group IS NULL';
                        $index = 'user_timestamp';
                        # @todo FIXME: Other groups may have 'bot' rights
                        $join_conds['user_groups'] = array( 'LEFT JOIN', "ug_user = rev_user AND ug_group = 'bot'" );
-                       $join_conds['recentchanges'] = array( 'INNER JOIN', "rev_id = rc_this_oldid AND rev_timestamp = rc_timestamp" );
                } else {
-                       $tables = array( 'recentchanges', 'page', 'revision' );
-                       $condition['rev_user_text'] = $this->target;
-                       $join_conds['recentchanges'] = array( 'INNER JOIN', "rev_id = rc_this_oldid AND rev_timestamp = rc_timestamp" );
-                       $index = 'usertext_timestamp';
+                       if ( IP::isIPAddress( $this->target ) ) {
+                               $condition['rev_user_text'] = $this->target;
+                               $index = 'usertext_timestamp';
+                       } else {
+                               $condition['rev_user'] = User::idFromName( $this->target );
+                               $index = 'user_timestamp';
+                       }
                }
                if( $this->deletedOnly ) {
                        $condition[] = "rev_deleted != '0'";
@@ -535,9 +544,12 @@ class ContribsPager extends ReverseChronologicalPager {
        }
 
        function getNamespaceCond() {
-               global $wgMiserMode;
-               if( $this->namespace !== '' && !$wgMiserMode ) {
-                       return array( 'page_namespace' => (int)$this->namespace );
+               if( $this->namespace !== '' ) {
+                       if ( $this->nsInvert ) {
+                               return array( 'page_namespace != ' . (int)$this->namespace );
+                       } else {
+                               return array( 'page_namespace' => (int)$this->namespace );
+                       }
                } else {
                        return array();
                }
@@ -547,6 +559,49 @@ class ContribsPager extends ReverseChronologicalPager {
                return 'rev_timestamp';
        }
 
+       function doBatchLookups() {
+               $this->mResult->rewind();
+               $revIds = array();
+               foreach ( $this->mResult as $row ) {
+                       $revIds[] = $row->rev_parent_id;
+               }
+               $this->mParentLens = $this->getParentLengths( $revIds );
+               $this->mResult->rewind(); // reset
+
+               if ( $this->contribs === 'newbie' ) { // multiple users
+                       # Do a link batch query
+                       $this->mResult->seek( 0 );
+                       $batch = new LinkBatch();
+                       # Give some pointers to make (last) links
+                       foreach ( $this->mResult as $row ) {
+                               $batch->addObj( Title::makeTitleSafe( NS_USER, $row->user_name ) );
+                               $batch->addObj( Title::makeTitleSafe( NS_USER_TALK, $row->user_name ) );
+                       }
+                       $batch->execute();
+                       $this->mResult->seek( 0 );
+               }
+       }
+
+       /**
+        * Do a batched query to get the parent revision lengths
+        */
+       private function getParentLengths( array $revIds ) {
+               $revLens = array();
+               if ( !$revIds ) {
+                       return $revLens; // empty
+               }
+               wfProfileIn( __METHOD__ );
+               $res = $this->getDatabase()->select( 'revision',
+                       array( 'rev_id', 'rev_len' ),
+                       array( 'rev_id' => $revIds ),
+                       __METHOD__ );
+               foreach( $res as $row ) {
+                       $revLens[$row->rev_id] = $row->rev_len;
+               }
+               wfProfileOut( __METHOD__ );
+               return $revLens;
+       }
+
        function getStartBody() {
                return "<ul>\n";
        }
@@ -566,15 +621,13 @@ class ContribsPager extends ReverseChronologicalPager {
         * @todo This would probably look a lot nicer in a table.
         */
        function formatRow( $row ) {
-               global $wgUser, $wgLang;
                wfProfileIn( __METHOD__ );
 
-               $sk = $this->getSkin();
                $rev = new Revision( $row );
                $classes = array();
 
                $page = Title::newFromRow( $row );
-               $link = $sk->link(
+               $link = Linker::link(
                        $page,
                        htmlspecialchars( $page->getPrefixedText() ),
                        array(),
@@ -589,12 +642,13 @@ class ContribsPager extends ReverseChronologicalPager {
                                && $page->quickUserCan( 'edit' ) )
                        {
                                $this->preventClickjacking();
-                               $topmarktext .= ' '.$sk->generateRollback( $rev );
+                               $topmarktext .= ' '.Linker::generateRollback( $rev );
                        }
                }
+               $user = $this->getUser();
                # Is there a visible previous revision?
-               if( $rev->userCan( Revision::DELETED_TEXT ) && $rev->getParentId() !== 0 ) {
-                       $difftext = $sk->linkKnown(
+               if( $rev->userCan( Revision::DELETED_TEXT, $user ) && $rev->getParentId() !== 0 ) {
+                       $difftext = Linker::linkKnown(
                                $page,
                                $this->messages['diff'],
                                array(),
@@ -606,17 +660,24 @@ class ContribsPager extends ReverseChronologicalPager {
                } else {
                        $difftext = $this->messages['diff'];
                }
-               $histlink = $sk->linkKnown(
+               $histlink = Linker::linkKnown(
                        $page,
                        $this->messages['hist'],
                        array(),
                        array( 'action' => 'history' )
                );
 
-               $comment = $wgLang->getDirMark() . $sk->revComment( $rev, false, true );
-               $date = $wgLang->timeanddate( wfTimestamp( TS_MW, $row->rev_timestamp ), true );
-               if( $rev->userCan( Revision::DELETED_TEXT ) ) {
-                       $d = $sk->linkKnown(
+               if ( isset( $this->mParentLens[$row->rev_parent_id] ) ) {
+                       $chardiff = ' . . ' . ChangesList::showCharacterDifference(
+                               $this->mParentLens[$row->rev_parent_id], $row->rev_len ) . ' . . ';
+               } else {
+                       $chardiff = ' ';
+               }
+
+               $comment = $this->getLanguage()->getDirMark() . Linker::revComment( $rev, false, true );
+               $date = $this->getLanguage()->timeanddate( wfTimestamp( TS_MW, $row->rev_timestamp ), true );
+               if( $rev->userCan( Revision::DELETED_TEXT, $user ) ) {
+                       $d = Linker::linkKnown(
                                $page,
                                htmlspecialchars($date),
                                array(),
@@ -629,9 +690,12 @@ class ContribsPager extends ReverseChronologicalPager {
                        $d = '<span class="history-deleted">' . $d . '</span>';
                }
 
-               if( $this->target == 'newbies' ) {
-                       $userlink = ' . . ' . $sk->userLink( $row->rev_user, $row->rev_user_text );
-                       $userlink .= ' ' . wfMsg( 'parentheses', $sk->userTalkLink( $row->rev_user, $row->rev_user_text ) ) . ' ';
+               # Show user names for /newbies as there may be different users.
+               # Note that we already excluded rows with hidden user names.
+               if( $this->contribs == 'newbie' ) {
+                       $userlink = ' . . ' . Linker::userLink( $rev->getUser(), $rev->getUserText() );
+                       $userlink .= ' ' . wfMsg( 'parentheses',
+                               Linker::userTalkLink( $rev->getUser(), $rev->getUserText() ) ) . ' ';
                } else {
                        $userlink = '';
                }
@@ -649,17 +713,17 @@ class ContribsPager extends ReverseChronologicalPager {
                }
 
                // Don't show useless link to people who cannot hide revisions
-               $canHide = $wgUser->isAllowed( 'deleterevision' );
-               if( $canHide || ($rev->getVisibility() && $wgUser->isAllowed('deletedhistory')) ) {
-                       if( !$rev->userCan( Revision::DELETED_RESTRICTED ) ) {
-                               $del = $this->mSkin->revDeleteLinkDisabled( $canHide ); // revision was hidden from sysops
+               $canHide = $user->isAllowed( 'deleterevision' );
+               if( $canHide || ($rev->getVisibility() && $user->isAllowed('deletedhistory')) ) {
+                       if( !$rev->userCan( Revision::DELETED_RESTRICTED, $user ) ) {
+                               $del = Linker::revDeleteLinkDisabled( $canHide ); // revision was hidden from sysops
                        } else {
                                $query = array(
                                        'type'   => 'revision',
                                        'target' => $page->getPrefixedDbkey(),
                                        'ids'    => $rev->getId()
                                );
-                               $del = $this->mSkin->revDeleteLink( $query,
+                               $del = Linker::revDeleteLink( $query,
                                        $rev->isDeleted( Revision::DELETED_RESTRICTED ), $canHide );
                        }
                        $del .= ' ';
@@ -668,11 +732,7 @@ class ContribsPager extends ReverseChronologicalPager {
                }
 
                $diffHistLinks = '(' . $difftext . $this->messages['pipe-separator'] . $histlink . ')';
-
-               $diffOut = ' . . ' . $wgLang->getDirMark() .
-                       ChangesList::showCharacterDifference( $row->rc_old_len, $row->rc_new_len );
-
-               $ret = "{$del}{$d} {$diffHistLinks} {$nflag}{$mflag} {$link}{$diffOut}{$userlink} {$comment} {$topmarktext}";
+               $ret = "{$del}{$d} {$diffHistLinks}{$chardiff}{$nflag}{$mflag} {$link}{$userlink} {$comment} {$topmarktext}";
 
                # Denote if username is redacted for this edit
                if( $rev->isDeleted( Revision::DELETED_USER ) ) {