BREAKING CHANGE: Require POST for patrolling revisions and salt the patrol token...

[lhc/web/wiklou.git] / includes / api / ApiPatrol.php

diff --git a/includes/api/ApiPatrol.php b/includes/api/ApiPatrol.php
index dc246ef..04afd1d 100644 (file)
--- a/includes/api/ApiPatrol.php
+++ b/includes/api/ApiPatrol.php
@@ -1,10 +1,9 @@
 <?php
-
 /**
- * Created on Sep 2, 2008
- *
  * API for MediaWiki 1.14+
  *
+ * Created on Sep 2, 2008
+ *
  * Copyright © 2008 Soxred93 soxred93@gmail.com,
  *
  * This program is free software; you can redistribute it and/or modify
@@ -19,8 +18,10 @@
  *
  * You should have received a copy of the GNU General Public License along
  * with this program; if not, write to the Free Software Foundation, Inc.,
- * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
  */
 
 if ( !defined( 'MEDIAWIKI' ) ) {
@@ -43,10 +44,6 @@ class ApiPatrol extends ApiBase {
        public function execute() {
                $params = $this->extractRequestParams();
 
-               if ( !isset( $params['rcid'] ) ) {
-                       $this->dieUsageMsg( array( 'missingparam', 'rcid' ) );
-               }
-
                $rc = RecentChange::newFromID( $params['rcid'] );
                if ( !$rc instanceof RecentChange ) {
                        $this->dieUsageMsg( array( 'nosuchrcid', $params['rcid'] ) );
@@ -62,6 +59,10 @@ class ApiPatrol extends ApiBase {
                $this->getResult()->addValue( null, $this->getModuleName(), $result );
        }
 
+       public function mustBePosted() {
+               return true;
+       }
+
        public function isWriteMode() {
                return true;
        }
@@ -70,7 +71,8 @@ class ApiPatrol extends ApiBase {
                return array(
                        'token' => null,
                        'rcid' => array(
-                               ApiBase::PARAM_TYPE => 'integer'
+                               ApiBase::PARAM_TYPE => 'integer',
+                               ApiBase::PARAM_REQUIRED => true
                        ),
                );
        }
@@ -83,20 +85,21 @@ class ApiPatrol extends ApiBase {
        }
 
        public function getDescription() {
-               return array(
-                       'Patrol a page or revision'
-               );
+               return 'Patrol a page or revision';
        }
 
        public function getPossibleErrors() {
                return array_merge( parent::getPossibleErrors(), array(
-                       array( 'missingparam', 'rcid' ),
                        array( 'nosuchrcid', 'rcid' ),
                ) );
        }
 
+       public function needsToken() {
+               return true;
+       }
+
        public function getTokenSalt() {
-               return '';
+               return 'patrol';
        }
 
        protected function getExamples() {
@@ -108,4 +111,4 @@ class ApiPatrol extends ApiBase {
        public function getVersion() {
                return __CLASS__ . ': $Id$';
        }
-}
\ No newline at end of file
+}