Make data loading a bit better in ApiDelete.
[lhc/web/wiklou.git] / includes / api / ApiDelete.php
index a80a43a..b8ffff9 100644 (file)
@@ -1,10 +1,10 @@
 <?php
-
-/*
+/**
+ *
+ *
  * Created on Jun 30, 2007
- * API for MediaWiki 1.8+
  *
- * Copyright (C) 2007 Roan Kattouw <Firstname>.<Lastname>@home.nl
+ * Copyright © 2007 Roan Kattouw <Firstname>.<Lastname>@gmail.com
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  *
  * You should have received a copy of the GNU General Public License along
  * with this program; if not, write to the Free Software Foundation, Inc.,
- * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
  */
 
-if (!defined('MEDIAWIKI')) {
-       // Eclipse helper - will be ignored in production
-       require_once ("ApiBase.php");
-}
-
-
 /**
- * API module that facilitates deleting pages. The API eqivalent of action=delete. 
+ * API module that facilitates deleting pages. The API equivalent of action=delete.
  * Requires API write mode to be enabled.
  *
- * @addtogroup API
+ * @ingroup API
  */
 class ApiDelete extends ApiBase {
 
-       public function __construct($main, $action) {
-               parent :: __construct($main, $action);
+       public function __construct( $main, $action ) {
+               parent::__construct( $main, $action );
        }
 
        /**
         * Extracts the title, token, and reason from the request parameters and invokes
-        * the local delete() function with these as arguments. It does not make use of 
-        * the delete function specified by Article.php. If the deletion succeeds, the 
-        * details of the article deleted and the reason for deletion are added to the 
+        * the local delete() function with these as arguments. It does not make use of
+        * the delete function specified by Article.php. If the deletion succeeds, the
+        * details of the article deleted and the reason for deletion are added to the
         * result object.
         */
        public function execute() {
-               global $wgUser;
-               $this->getMain()->requestWriteMode();
                $params = $this->extractRequestParams();
-               
-               $titleObj = NULL;
-               if(!isset($params['title']))
-                       $this->dieUsageMsg(array('missingparam', 'title'));
-               if(!isset($params['token']))
-                       $this->dieUsageMsg(array('missingparam', 'token'));
-
-               $titleObj = Title::newFromText($params['title']);
-               if(!$titleObj)
-                       $this->dieUsageMsg(array('invalidtitle', $params['title']));
-               if(!$titleObj->exists())
-                       $this->dieUsageMsg(array('notanarticle'));
-
-               $articleObj = new Article($titleObj);
-               $reason = (isset($params['reason']) ? $params['reason'] : NULL);
-               $dbw = wfGetDb(DB_MASTER);
-               $dbw->begin();
-               $retval = self::delete($articleObj, $params['token'],   $reason);
-               
-               if(!empty($retval))
-                       // We don't care about multiple errors, just report one of them
-                       $this->dieUsageMsg(current($retval));
-
-               $dbw->commit();
-               $r = array('title' => $titleObj->getPrefixedText(), 'reason' => $reason);
-               $this->getResult()->addValue(null, $this->getModuleName(), $r);
+
+               $this->requireOnlyOneParameter( $params, 'title', 'pageid' );
+
+               if ( isset( $params['title'] ) ) {
+                       $titleObj = Title::newFromText( $params['title'] );
+                       if ( !$titleObj ) {
+                               $this->dieUsageMsg( array( 'invalidtitle', $params['title'] ) );
+                       }
+                       $pageObj = WikiPage::factory( $titleObj );
+                       $pageObj->loadPageData( 'fromdbmaster' );
+                       if ( !$pageObj->exists() ) {
+                               $this->dieUsageMsg( 'notanarticle' );
+                       }
+               } elseif ( isset( $params['pageid'] ) ) {
+                       $pageObj = WikiPage::newFromID( $params['pageid'] );
+                       if ( !$pageObj ) {
+                               $this->dieUsageMsg( array( 'nosuchpageid', $params['pageid'] ) );
+                       }
+                       $titleObj = $pageObj->getTitle();
+               }
+
+               $reason = ( isset( $params['reason'] ) ? $params['reason'] : null );
+               $user = $this->getUser();
+
+               if ( $titleObj->getNamespace() == NS_FILE ) {
+                       $retval = self::deleteFile( $pageObj, $user, $params['token'], $params['oldimage'], $reason, false );
+               } else {
+                       $retval = self::delete( $pageObj, $user, $params['token'], $reason );
+               }
+
+               if ( count( $retval ) ) {
+                       $this->dieUsageMsg( reset( $retval ) ); // We don't care about multiple errors, just report one of them
+               }
+
+               // Deprecated parameters
+               if ( $params['watch'] ) {
+                       $watch = 'watch';
+               } elseif ( $params['unwatch'] ) {
+                       $watch = 'unwatch';
+               } else {
+                       $watch = $params['watchlist'];
+               }
+               $this->setWatch( $watch, $titleObj, 'watchdeletion' );
+
+               $r = array( 'title' => $titleObj->getPrefixedText(), 'reason' => $reason );
+               $this->getResult()->addValue( null, $this->getModuleName(), $r );
+       }
+
+       /**
+        * @param $title Title
+        * @param $user User doing the action
+        * @param $token String
+        * @return array
+        */
+       private static function getPermissionsError( $title, $user, $token ) {
+               // Check permissions
+               return $title->getUserPermissionsErrors( 'delete', $user );
        }
 
        /**
         * We have our own delete() function, since Article.php's implementation is split in two phases
         *
-        * @param Article $article - Article object to work on
-        * @param string $token - Delete token (same as edit token)
-        * @param string $reason - Reason for the deletion. Autogenerated if NULL
+        * @param $page WikiPage object to work on
+        * @param $user User doing the action
+        * @param $token String: delete token (same as edit token)
+        * @param $reason String: reason for the deletion. Autogenerated if NULL
         * @return Title::getUserPermissionsErrors()-like array
         */
-       public static function delete(&$article, $token, &$reason = NULL)
-       {
-               global $wgUser;
-
-               // Check permissions
-               $errors = $article->mTitle->getUserPermissionsErrors('delete', $wgUser);
-               if(!empty($errors))
+       public static function delete( Page $page, User $user, $token, &$reason = null ) {
+               $title = $page->getTitle();
+               $errors = self::getPermissionsError( $title, $user, $token );
+               if ( count( $errors ) ) {
                        return $errors;
-               if(wfReadOnly())
-                       return array(array('readonlytext'));
-               if($wgUser->isBlocked())
-                       return array(array('blocked'));
-
-               // Check token
-               if(!$wgUser->matchEditToken($token))
-                       return array(array('sessionfailure'));
+               }
 
                // Auto-generate a summary, if necessary
-               if(is_null($reason))
-               {
-                       $reason = $article->generateReason($hasHistory);
-                       if($reason === false)
-                               return array(array('cannotdelete'));
+               if ( is_null( $reason ) ) {
+                       // Need to pass a throwaway variable because generateReason expects
+                       // a reference
+                       $hasHistory = false;
+                       $reason = $page->getAutoDeleteReason( $hasHistory );
+                       if ( $reason === false ) {
+                               return array( array( 'cannotdelete', $title->getPrefixedText() ) );
+                       }
                }
 
+               $error = '';
                // Luckily, Article.php provides a reusable delete function that does the hard work for us
-               if($article->doDeleteArticle($reason))
+               if ( $page->doDeleteArticle( $reason, false, 0, true, $error ) ) {
                        return array();
-               return array(array('cannotdelete', $article->mTitle->getPrefixedText()));
+               } else {
+                       return array( array( 'cannotdelete', $title->getPrefixedText() ) );
+               }
+       }
+
+       /**
+        * @param $page WikiPage object to work on
+        * @param $user User doing the action
+        * @param $token
+        * @param $oldimage
+        * @param $reason
+        * @param $suppress bool
+        * @return array|Title
+        */
+       public static function deleteFile( Page $page, User $user, $token, $oldimage, &$reason = null, $suppress = false ) {
+               $title = $page->getTitle();
+               $errors = self::getPermissionsError( $title, $user, $token );
+               if ( count( $errors ) ) {
+                       return $errors;
+               }
+
+               $file = $page->getFile();
+               if ( !$file->exists() || !$file->isLocal() || $file->getRedirected() ) {
+                       return self::delete( $page, $user, $token, $reason );
+               }
+
+               if ( $oldimage ) {
+                       if ( !FileDeleteForm::isValidOldSpec( $oldimage ) ) {
+                               return array( array( 'invalidoldimage' ) );
+                       }
+                       $oldfile = RepoGroup::singleton()->getLocalRepo()->newFromArchiveName( $title, $oldimage );
+                       if ( !$oldfile->exists() || !$oldfile->isLocal() || $oldfile->getRedirected() ) {
+                               return array( array( 'nodeleteablefile' ) );
+                       }
+               } else {
+                       $oldfile = false;
+               }
+
+               if ( is_null( $reason ) ) { // Log and RC don't like null reasons
+                       $reason = '';
+               }
+               $status = FileDeleteForm::doDelete( $title, $file, $oldimage, $reason, $suppress );
+               if ( !$status->isGood() ) {
+                       return array( array( 'cannotdelete', $title->getPrefixedText() ) );
+               }
+
+               return array();
+       }
+
+       public function mustBePosted() {
+               return true;
        }
-       
-       public function mustBePosted() { return true; }
-       
+
+       public function isWriteMode() {
+               return true;
+       }
+
        public function getAllowedParams() {
-               return array (
+               return array(
                        'title' => null,
+                       'pageid' => array(
+                               ApiBase::PARAM_TYPE => 'integer'
+                       ),
                        'token' => null,
                        'reason' => null,
+                       'watch' => array(
+                               ApiBase::PARAM_DFLT => false,
+                               ApiBase::PARAM_DEPRECATED => true,
+                       ),
+                       'watchlist' => array(
+                               ApiBase::PARAM_DFLT => 'preferences',
+                               ApiBase::PARAM_TYPE => array(
+                                       'watch',
+                                       'unwatch',
+                                       'preferences',
+                                       'nochange'
+                               ),
+                       ),
+                       'unwatch' => array(
+                               ApiBase::PARAM_DFLT => false,
+                               ApiBase::PARAM_DEPRECATED => true,
+                       ),
+                       'oldimage' => null,
                );
        }
 
        public function getParamDescription() {
-               return array (
-                       'title' => 'Title of the page you want to delete.',
+               $p = $this->getModulePrefix();
+               return array(
+                       'title' => "Title of the page you want to delete. Cannot be used together with {$p}pageid",
+                       'pageid' => "Page ID of the page you want to delete. Cannot be used together with {$p}title",
                        'token' => 'A delete token previously retrieved through prop=info',
-                       'reason' => 'Reason for the deletion. If not set, an automatically generated reason will be used.'
+                       'reason' => 'Reason for the deletion. If not set, an automatically generated reason will be used',
+                       'watch' => 'Add the page to your watchlist',
+                       'watchlist' => 'Unconditionally add or remove the page from your watchlist, use preferences or do not change watch',
+                       'unwatch' => 'Remove the page from your watchlist',
+                       'oldimage' => 'The name of the old image to delete as provided by iiprop=archivename'
                );
        }
 
        public function getDescription() {
-               return array(
-                       'Deletes a page. You need to be logged in as a sysop to use this function, see also action=login.'
+               return 'Delete a page';
+       }
+
+       public function getPossibleErrors() {
+               return array_merge( parent::getPossibleErrors(),
+                       $this->getRequireOnlyOneParameterErrorMessages( array( 'title', 'pageid' ) ),
+                       array(
+                               array( 'invalidtitle', 'title' ),
+                               array( 'nosuchpageid', 'pageid' ),
+                               array( 'notanarticle' ),
+                               array( 'hookaborted', 'error' ),
+                               array( 'delete-toobig', 'limit' ),
+                               array( 'cannotdelete', 'title' ),
+                               array( 'invalidoldimage' ),
+                               array( 'nodeleteablefile' ),
+                       )
                );
        }
 
-       protected function getExamples() {
-               return array (
-                       'api.php?action=delete&title=Main%20Page&token=123ABC',
-                       'api.php?action=delete&title=Main%20Page&token=123ABC&reason=Preparing%20for%20move'
+       public function needsToken() {
+               return true;
+       }
+
+       public function getTokenSalt() {
+               return '';
+       }
+
+       public function getExamples() {
+               return array(
+                       'api.php?action=delete&title=Main%20Page&token=123ABC' => 'Delete the Main Page',
+                       'api.php?action=delete&title=Main%20Page&token=123ABC&reason=Preparing%20for%20move' => 'Delete the Main Page with the reason "Preparing for move"',
                );
        }
 
+       public function getHelpUrls() {
+               return 'https://www.mediawiki.org/wiki/API:Delete';
+       }
+
        public function getVersion() {
                return __CLASS__ . ': $Id$';
        }