* (bug 30245) Use the correct way to construct a log page title
[lhc/web/wiklou.git] / includes / ChangesList.php
index f25678d..19cc53b 100644 (file)
@@ -31,7 +31,7 @@ class RCCacheEntry extends RecentChange {
 /**
  * Base class for all changes lists
  */
-class ChangesList {
+class ChangesList extends ContextSource {
 
        /**
         * @var Skin
@@ -43,29 +43,47 @@ class ChangesList {
        protected $message;
 
        /**
-       * Changeslist contructor
-       * @param $skin Skin
-       */
-       public function __construct( $skin ) {
-               $this->skin = $skin;
+        * Changeslist contructor
+        *
+        * @param $obj Skin or IContextSource
+        */
+       public function __construct( $obj ) {
+               if ( $obj instanceof IContextSource ) {
+                       $this->setContext( $obj );
+                       $this->skin = $obj->getSkin();
+               } else {
+                       $this->setContext( $obj->getContext() );
+                       $this->skin = $obj;
+               }
                $this->preCacheMessages();
        }
 
        /**
-        * Fetch an appropriate changes list class for the specified user
-        * Some users might want to use an enhanced list format, for instance
+        * Fetch an appropriate changes list class for the main context
+        * This first argument used to be an User object.
         *
-        * @param $user User to fetch the list class for
+        * @deprecated in 1.18; use newFromContext() instead
+        * @param $unused Unused
         * @return ChangesList|EnhancedChangesList|OldChangesList derivative
         */
-       public static function newFromUser( $user ) {
-               global $wgRequest;
+       public static function newFromUser( $unused ) {
+               return self::newFromContext( RequestContext::getMain() );
+       }
 
-               $sk = $user->getSkin();
+       /**
+        * Fetch an appropriate changes list class for the specified context
+        * Some users might want to use an enhanced list format, for instance
+        *
+        * @param $context IContextSource to use
+        * @return ChangesList|EnhancedChangesList|OldChangesList derivative
+        */
+       public static function newFromContext( IContextSource $context ) {
+               $user = $context->getUser();
+               $sk = $context->getSkin();
                $list = null;
                if( wfRunHooks( 'FetchChangesList', array( $user, &$sk, &$list ) ) ) {
-                       $new = $wgRequest->getBool( 'enhanced', $user->getOption( 'usenewrc' ) );
-                       return $new ? new EnhancedChangesList( $sk ) : new OldChangesList( $sk );
+                       $new = $context->getRequest()->getBool( 'enhanced', $user->getOption( 'usenewrc' ) );
+                       return $new ? new EnhancedChangesList( $context ) : new OldChangesList( $context );
                } else {
                        return $list;
                }
@@ -207,47 +225,9 @@ class ChangesList {
                }
        }
 
-       /**
-        * @param $s
-        * @param $rc RecentChange
-        * @return void
-        */
-       public function insertMove( &$s, $rc ) {
-               # Diff
-               $s .= '(' . $this->message['diff'] . ') (';
-               # Hist
-               $s .= $this->skin->link(
-                       $rc->getMovedToTitle(),
-                       $this->message['hist'],
-                       array(),
-                       array( 'action' => 'history' ),
-                       array( 'known', 'noclasses' )
-               ) . ') . . ';
-               # "[[x]] moved to [[y]]"
-               $msg = ( $rc->mAttribs['rc_type'] == RC_MOVE ) ? '1movedto2' : '1movedto2_redir';
-               $s .= wfMsg(
-                       $msg,
-                       $this->skin->link(
-                               $rc->getTitle(),
-                               null,
-                               array(),
-                               array( 'redirect' => 'no' ),
-                               array( 'known', 'noclasses' )
-                       ),
-                       $this->skin->link(
-                               $rc->getMovedToTitle(),
-                               null,
-                               array(),
-                               array(),
-                               array( 'known', 'noclasses' )
-                       )
-               );
-       }
-
        public function insertDateHeader( &$s, $rc_timestamp ) {
-               global $wgLang;
                # Make date header if necessary
-               $date = $wgLang->date( $rc_timestamp, true, true );
+               $date = $this->getLang()->date( $rc_timestamp, true, true );
                if( $date != $this->lastdate ) {
                        if( $this->lastdate != '' ) {
                                $s .= "</ul>\n";
@@ -259,14 +239,9 @@ class ChangesList {
        }
 
        public function insertLog( &$s, $title, $logtype ) {
-               $logname = LogPage::logName( $logtype );
-               $s .= '(' . $this->skin->link(
-                       $title,
-                       $logname,
-                       array(),
-                       array(),
-                       array( 'known', 'noclasses' )
-               ) . ')';
+               $page = new LogPage( $logtype );
+               $logname = $page->getName()->escaped();
+               $s .= '(' . Linker::linkKnown( $title, $logname ) . ')';
        }
 
        /**
@@ -292,25 +267,23 @@ class ChangesList {
                                $query['rcid'] = $rc->mAttribs['rc_id'];
                        };
 
-                       $diffLink = $this->skin->link(
+                       $diffLink = Linker::linkKnown(
                                $rc->getTitle(),
                                $this->message['diff'],
                                array( 'tabindex' => $rc->counter ),
-                               $query,
-                               array( 'known', 'noclasses' )
+                               $query
                        );
                }
                $s .= '(' . $diffLink . $this->message['pipe-separator'];
                # History link
-               $s .= $this->skin->link(
+               $s .= Linker::linkKnown(
                        $rc->getTitle(),
                        $this->message['hist'],
                        array(),
                        array(
                                'curid' => $rc->mAttribs['rc_cur_id'],
                                'action' => 'history'
-                       ),
-                       array( 'known', 'noclasses' )
+                       )
                );
                $s .= ') . . ';
        }
@@ -323,7 +296,6 @@ class ChangesList {
         * @return void
         */
        public function insertArticleLink( &$s, &$rc, $unpatrolled, $watched ) {
-               global $wgContLang;
                # If it's a new article, there is no diff link, but if it hasn't been
                # patrolled yet, we need to give users a way to do so
                $params = array();
@@ -332,30 +304,21 @@ class ChangesList {
                        $params['rcid'] = $rc->mAttribs['rc_id'];
                }
 
+               $articlelink = Linker::linkKnown(
+                       $rc->getTitle(),
+                       null,
+                       array(),
+                       $params
+               );
                if( $this->isDeleted($rc,Revision::DELETED_TEXT) ) {
-                       $articlelink = $this->skin->link(
-                               $rc->getTitle(),
-                               null,
-                               array(),
-                               $params,
-                               array( 'known', 'noclasses' )
-                       );
                        $articlelink = '<span class="history-deleted">' . $articlelink . '</span>';
-               } else {
-                       $articlelink = ' '. $this->skin->link(
-                               $rc->getTitle(),
-                               null,
-                               array(),
-                               $params,
-                               array( 'known', 'noclasses' )
-                       );
                }
                # Bolden pages watched by this user
                if( $watched ) {
                        $articlelink = "<strong class=\"mw-watched\">{$articlelink}</strong>";
                }
                # RTL/LTR marker
-               $articlelink .= $wgContLang->getDirMark();
+               $articlelink .= $this->getLang()->getDirMark();
 
                wfRunHooks( 'ChangesListInsertArticleLink',
                        array(&$this, &$articlelink, &$s, &$rc, $unpatrolled, $watched) );
@@ -369,9 +332,8 @@ class ChangesList {
         * @return void
         */
        public function insertTimestamp( &$s, $rc ) {
-               global $wgLang;
                $s .= $this->message['semicolon-separator'] .
-                       $wgLang->time( $rc->mAttribs['rc_timestamp'], true, true ) . ' . . ';
+                       $this->getLang()->time( $rc->mAttribs['rc_timestamp'], true, true ) . ' . . ';
        }
 
        /** Insert links to user page, user talk page and eventually a blocking link
@@ -382,8 +344,8 @@ class ChangesList {
                if( $this->isDeleted( $rc, Revision::DELETED_USER ) ) {
                        $s .= ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-user' ) . '</span>';
                } else {
-                       $s .= $this->skin->userLink( $rc->mAttribs['rc_user'], $rc->mAttribs['rc_user_text'] );
-                       $s .= $this->skin->userToolLinks( $rc->mAttribs['rc_user'], $rc->mAttribs['rc_user_text'] );
+                       $s .= Linker::userLink( $rc->mAttribs['rc_user'], $rc->mAttribs['rc_user_text'] );
+                       $s .= Linker::userToolLinks( $rc->mAttribs['rc_user'], $rc->mAttribs['rc_user_text'] );
                }
        }
 
@@ -391,27 +353,23 @@ class ChangesList {
         *
         * @param $rc RecentChange
         */
-       public function insertAction( &$s, &$rc ) {
-               if( $rc->mAttribs['rc_type'] == RC_LOG ) {
-                       if( $this->isDeleted( $rc, LogPage::DELETED_ACTION ) ) {
-                               $s .= ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-event' ) . '</span>';
-                       } else {
-                               $s .= ' '.LogPage::actionText( $rc->mAttribs['rc_log_type'], $rc->mAttribs['rc_log_action'],
-                                       $rc->getTitle(), $this->skin, LogPage::extractParams( $rc->mAttribs['rc_params'] ), true, true );
-                       }
-               }
+       public function insertLogEntry( $rc ) {
+               $formatter = LogFormatter::newFromRow( $rc->mAttribs );
+               $formatter->setShowUserToolLinks( true );
+               $mark = $this->getLang()->getDirMark();
+               return $formatter->getActionText() . " $mark" . $formatter->getComment();
        }
 
-       /** insert a formatted comment
-        *
+       /** 
+        * Insert a formatted comment
         * @param $rc RecentChange
         */
-       public function insertComment( &$s, &$rc ) {
+       public function insertComment( $rc ) {
                if( $rc->mAttribs['rc_type'] != RC_MOVE && $rc->mAttribs['rc_type'] != RC_MOVE_OVER_REDIRECT ) {
                        if( $this->isDeleted( $rc, Revision::DELETED_COMMENT ) ) {
-                               $s .= ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-comment' ) . '</span>';
+                               return ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-comment' ) . '</span>';
                        } else {
-                               $s .= $this->skin->commentBlock( $rc->mAttribs['rc_comment'], $rc->getTitle() );
+                               return Linker::commentBlock( $rc->mAttribs['rc_comment'], $rc->getTitle() );
                        }
                }
        }
@@ -429,12 +387,11 @@ class ChangesList {
         * Returns the string which indicates the number of watching users
         */
        protected function numberofWatchingusers( $count ) {
-               global $wgLang;
                static $cache = array();
                if( $count > 0 ) {
                        if( !isset( $cache[$count] ) ) {
                                $cache[$count] = wfMsgExt( 'number_of_watching_users_RCview',
-                                       array('parsemag', 'escape' ), $wgLang->formatNum( $count ) );
+                                       array('parsemag', 'escape' ), $this->getLang()->formatNum( $count ) );
                        }
                        return $cache[$count];
                } else {
@@ -481,12 +438,11 @@ class ChangesList {
         * @param $rc RecentChange
         */
        public function insertRollback( &$s, &$rc ) {
-               global $wgUser;
                if( !$rc->mAttribs['rc_new'] && $rc->mAttribs['rc_this_oldid'] && $rc->mAttribs['rc_cur_id'] ) {
                        $page = $rc->getTitle();
                        /** Check for rollback and edit permissions, disallow special pages, and only
                          * show a link on the top-most revision */
-                       if ($wgUser->isAllowed('rollback') && $rc->mAttribs['page_latest'] == $rc->mAttribs['rc_this_oldid'] )
+                       if ( $this->getUser()->isAllowed('rollback') && $rc->mAttribs['page_latest'] == $rc->mAttribs['rc_this_oldid'] )
                        {
                                $rev = new Revision( array(
                                        'id'        => $rc->mAttribs['rc_this_oldid'],
@@ -495,7 +451,7 @@ class ChangesList {
                                        'deleted'   => $rc->mAttribs['rc_deleted']
                                ) );
                                $rev->setTitle( $page );
-                               $s .= ' '.$this->skin->generateRollback( $rev );
+                               $s .= ' '.Linker::generateRollback( $rev, $this->getContext() );
                        }
                }
        }
@@ -531,10 +487,10 @@ class OldChangesList extends ChangesList {
         * @param $rc RecentChange
         */
        public function recentChangesLine( &$rc, $watched = false, $linenumber = null ) {
-               global $wgLang, $wgRCShowChangedSize, $wgUser;
+               global $wgRCShowChangedSize;
                wfProfileIn( __METHOD__ );
                # Should patrol-related stuff be shown?
-               $unpatrolled = $wgUser->useRCPatrol() && !$rc->mAttribs['rc_patrolled'];
+               $unpatrolled = $this->getUser()->useRCPatrol() && !$rc->mAttribs['rc_patrolled'];
 
                $dateheader = ''; // $s now contains only <li>...</li>, for hooks' convenience.
                $this->insertDateHeader( $dateheader, $rc->mAttribs['rc_timestamp'] );
@@ -551,12 +507,11 @@ class OldChangesList extends ChangesList {
                        }
                }
 
-               // Moved pages
+               // Moved pages (very very old, not supported anymore)
                if( $rc->mAttribs['rc_type'] == RC_MOVE || $rc->mAttribs['rc_type'] == RC_MOVE_OVER_REDIRECT ) {
-                       $this->insertMove( $s, $rc );
                // Log entries
                } elseif( $rc->mAttribs['rc_log_type'] ) {
-                       $logtitle = Title::newFromText( 'Log/'.$rc->mAttribs['rc_log_type'], NS_SPECIAL );
+                       $logtitle = SpecialPage::getTitleFor( 'Log', $rc->mAttribs['rc_log_type'] );
                        $this->insertLog( $s, $logtitle, $rc->mAttribs['rc_log_type'] );
                // Log entries (old format) or log targets, and special pages
                } elseif( $rc->mAttribs['rc_namespace'] == NS_SPECIAL ) {
@@ -588,12 +543,17 @@ class OldChangesList extends ChangesList {
                                $s .= "$cd  . . ";
                        }
                }
-               # User tool links
-               $this->insertUserRelatedLinks( $s, $rc );
-               # Log action text (if any)
-               $this->insertAction( $s, $rc );
-               # Edit or log comment
-               $this->insertComment( $s, $rc );
+
+               if ( $rc->mAttribs['rc_type'] == RC_LOG ) {
+                       $s .= $this->insertLogEntry( $rc );
+               } else {
+                       # User tool links
+                       $this->insertUserRelatedLinks( $s, $rc );
+                       # LTR/RTL direction mark
+                       $s .= $this->getLang()->getDirMark();
+                       $s .= $this->insertComment( $rc );
+               }
+
                # Tags
                $this->insertTags( $s, $rc, $classes );
                # Rollback
@@ -604,7 +564,7 @@ class OldChangesList extends ChangesList {
                # How many users watch this page
                if( $rc->numberofWatchingusers > 0 ) {
                        $s .= ' ' . wfMsgExt( 'number_of_watching_users_RCview',
-                               array( 'parsemag', 'escape' ), $wgLang->formatNum( $rc->numberofWatchingusers ) );
+                               array( 'parsemag', 'escape' ), $this->getLang()->formatNum( $rc->numberofWatchingusers ) );
                }
 
                if( $this->watchlist ) {
@@ -628,13 +588,12 @@ class EnhancedChangesList extends ChangesList {
         * @return String
         */
        public function beginRecentChangesList() {
-               global $wgOut;
                $this->rc_cache = array();
                $this->rcMoveIndex = 0;
                $this->rcCacheIndex = 0;
                $this->lastdate = '';
                $this->rclistOpen = false;
-               $wgOut->addModuleStyles( 'mediawiki.special.changeslist' );
+               $this->getOutput()->addModuleStyles( 'mediawiki.special.changeslist' );
                return '';
        }
        /**
@@ -646,8 +605,6 @@ class EnhancedChangesList extends ChangesList {
         * @return string
         */
        public function recentChangesLine( &$baseRC, $watched = false ) {
-               global $wgLang, $wgUser;
-
                wfProfileIn( __METHOD__ );
 
                # Create a specialised object
@@ -656,7 +613,7 @@ class EnhancedChangesList extends ChangesList {
                $curIdEq = array( 'curid' => $rc->mAttribs['rc_cur_id'] );
 
                # If it's a new day, add the headline and flush the cache
-               $date = $wgLang->date( $rc->mAttribs['rc_timestamp'], true );
+               $date = $this->getLang()->date( $rc->mAttribs['rc_timestamp'], true );
                $ret = '';
                if( $date != $this->lastdate ) {
                        # Process current cache
@@ -667,7 +624,7 @@ class EnhancedChangesList extends ChangesList {
                }
 
                # Should patrol-related stuff be shown?
-               if( $wgUser->useRCPatrol() ) {
+               if( $this->getUser()->useRCPatrol() ) {
                        $rc->unpatrolled = !$rc->mAttribs['rc_patrolled'];
                } else {
                        $rc->unpatrolled = false;
@@ -677,24 +634,20 @@ class EnhancedChangesList extends ChangesList {
                # Make article link
                $type = $rc->mAttribs['rc_type'];
                $logType = $rc->mAttribs['rc_log_type'];
-               // Page moves
+               // Page moves, very old style, not supported anymore
                if( $type == RC_MOVE || $type == RC_MOVE_OVER_REDIRECT ) {
-                       $msg = ( $type == RC_MOVE ) ? "1movedto2" : "1movedto2_redir";
-                       $clink = wfMsg( $msg, $this->skin->linkKnown( $rc->getTitle(), null,
-                               array(), array( 'redirect' => 'no' ) ),
-                               $this->skin->linkKnown( $rc->getMovedToTitle() ) );
                // New unpatrolled pages
                } elseif( $rc->unpatrolled && $type == RC_NEW ) {
-                       $clink = $this->skin->linkKnown( $rc->getTitle(), null, array(),
+                       $clink = Linker::linkKnown( $rc->getTitle(), null, array(),
                                array( 'rcid' => $rc->mAttribs['rc_id'] ) );
                // Log entries
                } elseif( $type == RC_LOG ) {
                        if( $logType ) {
                                $logtitle = SpecialPage::getTitleFor( 'Log', $logType );
-                               $clink = '(' . $this->skin->linkKnown( $logtitle,
+                               $clink = '(' . Linker::linkKnown( $logtitle,
                                        LogPage::logName( $logType ) ) . ')';
                        } else {
-                               $clink = $this->skin->link( $rc->getTitle() );
+                               $clink = Linker::link( $rc->getTitle() );
                        }
                        $watched = false;
                // Log entries (old format) and special pages
@@ -703,14 +656,14 @@ class EnhancedChangesList extends ChangesList {
                        if ( $specialName == 'Log' ) {
                                # Log updates, etc
                                $logname = LogPage::logName( $logtype );
-                               $clink = '(' . $this->skin->linkKnown( $rc->getTitle(), $logname ) . ')';
+                               $clink = '(' . Linker::linkKnown( $rc->getTitle(), $logname ) . ')';
                        } else {
                                wfDebug( "Unexpected special page in recentchanges\n" );
                                $clink = '';
                        }
                // Edits
                } else {
-                       $clink = $this->skin->linkKnown( $rc->getTitle() );
+                       $clink = Linker::linkKnown( $rc->getTitle() );
                }
 
                # Don't show unusable diff links
@@ -718,7 +671,7 @@ class EnhancedChangesList extends ChangesList {
                        $showdifflinks = false;
                }
 
-               $time = $wgLang->time( $rc->mAttribs['rc_timestamp'], true, true );
+               $time = $this->getLang()->time( $rc->mAttribs['rc_timestamp'], true, true );
                $rc->watched = $watched;
                $rc->link = $clink;
                $rc->timestamp = $time;
@@ -761,7 +714,7 @@ class EnhancedChangesList extends ChangesList {
                } elseif( in_array( $type, array( RC_LOG, RC_MOVE, RC_MOVE_OVER_REDIRECT ) ) ) {
                        $lastLink = $this->message['last'];
                } else {
-                       $lastLink = $this->skin->linkKnown( $rc->getTitle(), $this->message['last'],
+                       $lastLink = Linker::linkKnown( $rc->getTitle(), $this->message['last'],
                                array(), $curIdEq + array('diff' => $thisOldid, 'oldid' => $lastOldid) + $rcIdQuery );
                }
 
@@ -769,8 +722,8 @@ class EnhancedChangesList extends ChangesList {
                if( $this->isDeleted( $rc, Revision::DELETED_USER ) ) {
                        $rc->userlink = ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-user' ) . '</span>';
                } else {
-                       $rc->userlink = $this->skin->userLink( $rc->mAttribs['rc_user'], $rc->mAttribs['rc_user_text'] );
-                       $rc->usertalklink = $this->skin->userToolLinks( $rc->mAttribs['rc_user'], $rc->mAttribs['rc_user_text'] );
+                       $rc->userlink = Linker::userLink( $rc->mAttribs['rc_user'], $rc->mAttribs['rc_user_text'] );
+                       $rc->usertalklink = Linker::userToolLinks( $rc->mAttribs['rc_user'], $rc->mAttribs['rc_user_text'] );
                }
 
                $rc->lastlink = $lastLink;
@@ -805,7 +758,7 @@ class EnhancedChangesList extends ChangesList {
         * Enhanced RC group
         */
        protected function recentChangesBlockGroup( $block ) {
-               global $wgLang, $wgContLang, $wgRCShowChangedSize;
+               global $wgRCShowChangedSize;
 
                wfProfileIn( __METHOD__ );
 
@@ -867,9 +820,9 @@ class EnhancedChangesList extends ChangesList {
                $users = array();
                foreach( $userlinks as $userlink => $count) {
                        $text = $userlink;
-                       $text .= $wgContLang->getDirMark();
+                       $text .= $this->getLang()->getDirMark();
                        if( $count > 1 ) {
-                               $text .= ' (' . $wgLang->formatNum( $count ) . '×)';
+                               $text .= ' (' . $this->getLang()->formatNum( $count ) . '×)';
                        }
                        array_push( $users, $text );
                }
@@ -909,14 +862,14 @@ class EnhancedChangesList extends ChangesList {
                        $this->insertArticleLink( $r, $block[0], $block[0]->unpatrolled, $block[0]->watched );
                }
 
-               $r .= $wgContLang->getDirMark();
+               $r .= $this->getLang()->getDirMark();
 
                $queryParams['curid'] = $curId;
                # Changes message
                $n = count($block);
                static $nchanges = array();
                if ( !isset( $nchanges[$n] ) ) {
-                       $nchanges[$n] = wfMsgExt( 'nchanges', array( 'parsemag', 'escape' ), $wgLang->formatNum( $n ) );
+                       $nchanges[$n] = wfMsgExt( 'nchanges', array( 'parsemag', 'escape' ), $this->getLang()->formatNum( $n ) );
                }
                # Total change link
                $r .= ' ';
@@ -931,7 +884,7 @@ class EnhancedChangesList extends ChangesList {
                                $params['diff'] = $currentRevision;
                                $params['oldid'] = $oldid;
 
-                               $r .= $this->skin->link(
+                               $r .= Linker::link(
                                        $block[0]->getTitle(),
                                        $nchanges[$n],
                                        array(),
@@ -951,12 +904,11 @@ class EnhancedChangesList extends ChangesList {
                        $params['action'] = 'history';
 
                        $r .= $this->message['pipe-separator'] .
-                               $this->skin->link(
+                               Linker::linkKnown(
                                        $block[0]->getTitle(),
                                        $this->message['hist'],
                                        array(),
-                                       $params,
-                                       array( 'known', 'noclasses' )
+                                       $params
                                ) . ')';
                }
                $r .= ' . . ';
@@ -1019,12 +971,11 @@ class EnhancedChangesList extends ChangesList {
                                        $params['rcid'] = $rcObj->mAttribs['rc_id'];
                                }
 
-                               $link = $this->skin->link(
+                               $link = Linker::linkKnown(
                                                $rcObj->getTitle(),
                                                $rcObj->timestamp,
                                                array(),
-                                               $params,
-                                               array( 'known', 'noclasses' )
+                                               $params
                                        );
                                if( $this->isDeleted($rcObj,Revision::DELETED_TEXT) )
                                        $link = '<span class="history-deleted">'.$link.'</span> ';
@@ -1045,13 +996,15 @@ class EnhancedChangesList extends ChangesList {
                                $r .= $rcObj->getCharacterDifference() . ' . . ' ;
                        }
 
-                       # User links
-                       $r .= $rcObj->userlink;
-                       $r .= $rcObj->usertalklink;
-                       // log action
-                       $this->insertAction( $r, $rcObj );
-                       // log comment
-                       $this->insertComment( $r, $rcObj );
+                       if ( $rcObj->mAttribs['rc_type'] == RC_LOG ) {
+                               $r .= $this->insertLogEntry( $rcObj );
+                       } else {
+                               # User links
+                               $r .= $rcObj->userlink;
+                               $r .= $rcObj->usertalklink;
+                               $r .= $this->insertComment( $rcObj );
+                       }
+
                        # Rollback
                        $this->insertRollback( $r, $rcObj );
                        # Tags
@@ -1149,15 +1102,9 @@ class EnhancedChangesList extends ChangesList {
                $r .= '&#160;'.$rcObj->timestamp.'&#160;</td><td>';
                # Article or log link
                if( $logType ) {
-                       $logtitle = Title::newFromText( "Log/$logType", NS_SPECIAL );
+                       $logtitle = SpecialPage::getTitleFor( 'Log', $logType );
                        $logname = LogPage::logName( $logType );
-                       $r .= '(' . $this->skin->link(
-                               $logtitle,
-                               $logname,
-                               array(),
-                               array(),
-                               array( 'known', 'noclasses' )
-                       ) . ')';
+                       $r .= '(' . Linker::linkKnown( $logtitle, htmlspecialchars( $logname ) ) . ')';
                } else {
                        $this->insertArticleLink( $r, $rcObj, $rcObj->unpatrolled, $rcObj->watched );
                }
@@ -1165,12 +1112,11 @@ class EnhancedChangesList extends ChangesList {
                if ( $type != RC_LOG ) {
                        $r .= ' ('. $rcObj->difflink . $this->message['pipe-separator'];
                        $query['action'] = 'history';
-                       $r .= $this->skin->link(
+                       $r .= Linker::linkKnown(
                                $rcObj->getTitle(),
                                $this->message['hist'],
                                array(),
-                               $query,
-                               array( 'known', 'noclasses' )
+                               $query
                        ) . ')';
                }
                $r .= ' . . ';
@@ -1178,19 +1124,15 @@ class EnhancedChangesList extends ChangesList {
                if( $wgRCShowChangedSize && ($cd = $rcObj->getCharacterDifference()) ) {
                        $r .= "$cd . . ";
                }
-               # User/talk
-               $r .= ' '.$rcObj->userlink . $rcObj->usertalklink;
-               # Log action (if any)
-               if( $logType ) {
-                       if( $this->isDeleted($rcObj,LogPage::DELETED_ACTION) ) {
-                               $r .= ' <span class="history-deleted">' . wfMsgHtml('rev-deleted-event') . '</span>';
-                       } else {
-                               $r .= ' ' . LogPage::actionText( $logType, $rcObj->mAttribs['rc_log_action'], $rcObj->getTitle(),
-                                       $this->skin, LogPage::extractParams( $rcObj->mAttribs['rc_params'] ), true, true );
-                       }
+
+               if ( $type == RC_LOG ) {
+                       $r .= $this->insertLogEntry( $rcObj );
+               } else { 
+                       $r .= ' '.$rcObj->userlink . $rcObj->usertalklink;
+                       $r .= $this->insertComment( $rcObj );
+                       $r .= $this->insertRollback( $r, $rcObj );
                }
-               $this->insertComment( $r, $rcObj );
-               $this->insertRollback( $r, $rcObj );
+
                # Tags
                $classes = explode( ' ', $classes );
                $this->insertTags( $r, $rcObj, $classes );