more missing variable bugs
[lhc/web/wiklou.git] / includes / Article.php
index cf226d8..c7f9649 100644 (file)
@@ -34,6 +34,7 @@ class Article {
        var $mId, $mTable;
        var $mForUpdate;
        var $mOldId;
+       var $mRevIdFetched;
        /**#@-*/
 
        /**
@@ -58,13 +59,17 @@ class Article {
          * @private
          */
        function clear() {
+               $this->mDataLoaded    = false;
                $this->mContentLoaded = false;
+               
                $this->mCurID = $this->mUser = $this->mCounter = -1; # Not loaded
                $this->mRedirectedFrom = $this->mUserText =
                $this->mTimestamp = $this->mComment = $this->mFileCache = '';
                $this->mCountAdjustment = 0;
                $this->mTouched = '19700101000000';
                $this->mForUpdate = false;
+               $this->mIsRedirect = false;
+               $this->mRevIdFetched = 0;
        }
 
        /**
@@ -256,11 +261,67 @@ class Article {
 
                $t = $this->mTitle->getPrefixedText();
 
-               $noredir = $noredir || ($wgRequest->getVal( 'redirect' ) == 'no');
+               $noredir = $noredir || ($wgRequest->getVal( 'redirect' ) == 'no')
+                       || $wgRequest->getCheck( 'rdfrom' );
                $this->mOldId = $oldid;
                $this->fetchContent( $oldid, $noredir, true );
        }
        
+       
+       /**
+        * Fetch a page record with the given conditions
+        * @param Database $dbr
+        * @param array    $conditions
+        * @access private
+        */
+       function pageData( &$dbr, $conditions ) {
+               return $dbr->selectRow( 'page',
+                       array(
+                               'page_id',
+                               'page_namespace',
+                               'page_title',
+                               'page_restrictions',
+                               'page_counter',
+                               'page_is_redirect',
+                               'page_is_new',
+                               'page_random',
+                               'page_touched',
+                               'page_latest',
+                               'page_len' ),
+                       $conditions,
+                       'Article::pageData' );
+       }
+       
+       function pageDataFromTitle( &$dbr, $title ) {
+               return $this->pageData( $dbr, array(
+                       'page_namespace' => $title->getNamespace(),
+                       'page_title'     => $title->getDBkey() ) );
+       }
+       
+       function pageDataFromId( &$dbr, $id ) {
+               return $this->pageData( $dbr, array(
+                       'page_id' => IntVal( $id ) ) );
+       }
+       
+       /**
+        * Set the general counter, title etc data loaded from
+        * some source.
+        *
+        * @param object $data
+        * @access private
+        */
+       function loadPageData( $data ) {
+               $this->mTitle->mRestrictions = explode( ',', trim( $data->page_restrictions ) );
+               $this->mTitle->mRestrictionsLoaded = true;
+               
+               $this->mCounter    = $data->page_counter;
+               $this->mTouched    = wfTimestamp( TS_MW, $data->page_touched );
+               $this->mIsRedirect = $data->page_is_redirect;
+               $this->mLatest     = $data->page_latest;
+               
+               $this->mDataLoaded = true;
+       }
+       
        /**
         * Get text of an article from database
         * @param int $oldid 0 for whatever the latest revision is
@@ -287,32 +348,39 @@ class Article {
                }
                $this->mContent = wfMsg( 'missingarticle', $t );
 
-               if( !$oldid ) {
-                       # Retrieve current version
-                       $id = $this->getID();
-                       if ( 0 == $id ) {
+               if( $oldid ) {
+                       $revision = Revision::newFromId( $oldid );
+                       if( is_null( $revision ) ) {
+                               wfDebug( "$fname failed to retrieve specified revision, id $oldid\n" );
                                return false;
                        }
-
-                       $s = $dbr->selectRow( array( 'text', 'revision', 'page' ),
-                               $this->getContentFields(),
-                               "page_id='$id' AND rev_page=page_id AND rev_id=page_latest AND old_id=rev_id",
-                               $fname, $this->getSelectOptions() );
+                       $data = $this->pageDataFromId( $dbr, $revision->getPage() );
+                       if( !$data ) {
+                               wfDebug( "$fname failed to get page data linked to revision id $oldid\n" );
+                               return false;
+                       }
+                       $this->mTitle = Title::makeTitle( $data->page_namespace, $data->page_title );
+                       $this->loadPageData( $data );
                } else {
-                       # Historical revision
-                       $s = $dbr->selectRow( array( 'text', 'revision', 'page' ),
-                               $this->getContentFields(),
-                               "rev_page=page_id AND rev_id='$oldid' AND old_id=rev_id",
-                               $fname, $this->getSelectOptions() );
-               }
-               if ( $s === false ) {
-                       return false;
+                       if( !$this->mDataLoaded ) {
+                               $data = $this->pageDataFromTitle( $dbr, $this->mTitle );
+                               if( !$data ) {
+                                       wfDebug( "$fname failed to find page data for title " . $this->mTitle->getPrefixedText() . "\n" );
+                                       return false;
+                               }
+                               $this->loadPageData( $data );
+                       }
+                       $revision = Revision::newFromId( $this->mLatest );
+                       if( is_null( $revision ) ) {
+                               wfDebug( "$fname failed to retrieve current page, rev_id $data->page_latest\n" );
+                               return false;
+                       }
                }
 
                # If we got a redirect, follow it (unless we've been told
                # not to by either the function parameter or the query
                if ( !$oldid && !$noredir ) {
-                       $rt = Title::newFromRedirect( Revision::getRevisionText( $s ) );
+                       $rt = Title::newFromRedirect( $revision->getText() );
                        # process if title object is valid and not special:userlogout
                        if ( $rt && ! ( $rt->getNamespace() == NS_SPECIAL && $rt->getText() == 'Userlogout' ) ) {
                                # Gotta hand redirects to special pages differently:
@@ -321,7 +389,8 @@ class Article {
                                if( $globalTitle ) {
                                        global $wgOut;
                                        if ( $rt->getInterwiki() != '' && $rt->isLocal() ) {
-                                               $wgOut->redirect( $rt->getFullURL() ) ;
+                                               $source = $this->mTitle->getFullURL( 'redirect=no' );
+                                               $wgOut->redirect( $rt->getFullURL( 'rdfrom=' . urlencode( $source ) ) ) ;
                                                return false;
                                        }
                                        if ( $rt->getNamespace() == NS_SPECIAL ) {
@@ -329,46 +398,39 @@ class Article {
                                                return false;
                                        }
                                }
-                               $rid = $rt->getArticleID();
-                               if ( 0 != $rid ) {
-                                       $redirRow = $dbr->selectRow( array( 'text', 'revision', 'page' ),
-                                               $this->getContentFields(),
-                                               "page_id='$rid' AND rev_page=page_id AND rev_id=page_latest AND old_id=rev_id",
-                                               $fname, $this->getSelectOptions() );
-
-                                       if ( $redirRow !== false ) {
+                               $redirData = $this->pageDataFromTitle( $dbr, $rt );
+                               if( $redirData ) {
+                                       $redirRev = Revision::newFromId( $redirData->page_latest );
+                                       if( !is_null( $redirRev ) ) {
                                                $this->mRedirectedFrom = $this->mTitle->getPrefixedText();
                                                $this->mTitle = $rt;
-                                               $s = $redirRow;
+                                               $data = $redirData;
+                                               $this->loadPageData( $data );
+                                               $revision = $redirRev;
                                        }
                                }
                        }
                }
 
                # if the title's different from expected, update...
-               if( $globalTitle &&
-                       ( $this->mTitle->getNamespace() != $s->page_namespace ||
-                       $this->mTitle->getDBkey() != $s->page_title ) ) {
-                       $oldTitle = Title::makeTitle( $s->page_namesapce, $s->page_title );
-                       $this->mTitle = $oldTitle;
+               if( $globalTitle ) {
                        global $wgTitle;
-                       $wgTitle = $oldTitle;
+                       if( !$this->mTitle->equals( $wgTitle ) ) {
+                               $wgTitle = $this->mTitle;
+                       }
                }
                
                # Back to the business at hand...
-               $this->mCounter = $s->page_counter;
-               $this->mTitle->mRestrictions = explode( ',', trim( $s->page_restrictions ) );
-               $this->mTitle->mRestrictionsLoaded = true;
-               $this->mTouched = wfTimestamp( TS_MW, $s->page_touched );
-
-               $this->mContent = Revision::getRevisionText( $s );
+               $this->mContent   = $revision->getText();
                
-               $this->mUser = $s->rev_user;
-               $this->mUserText = $s->rev_user_text;
-               $this->mComment = $s->rev_comment;
-               $this->mTimestamp = wfTimestamp( TS_MW, $s->rev_timestamp );
+               $this->mUser      = $revision->getUser();
+               $this->mUserText  = $revision->getUserText();
+               $this->mComment   = $revision->getComment();
+               $this->mTimestamp = wfTimestamp( TS_MW, $revision->getTimestamp() );
                
+               $this->mRevIdFetched = $revision->getID();
                $this->mContentLoaded = true;
+               
                return $this->mContent;
        }
 
@@ -461,7 +523,7 @@ class Article {
        function isRedirect( $text = false ) {
                if ( $text === false ) {
                        $this->loadContent();
-                       $titleObj = Title::newFromRedirect( $this->mText );
+                       $titleObj = Title::newFromRedirect( $this->fetchRevisionText() );
                } else {
                        $titleObj = Title::newFromRedirect( $text );
                }
@@ -475,7 +537,7 @@ class Article {
         */
        function loadLastEdit() {
                global $wgOut;
-
+               
                if ( -1 != $this->mUser )
                        return;
 
@@ -483,19 +545,13 @@ class Article {
                $id = $this->getID();
                if ( 0 == $id ) return;
 
-               $fname = 'Article::loadLastEdit';
-
-               $dbr =& $this->getDB();
-               $s = $dbr->selectRow( array( 'revision', 'page') ,
-                 array( 'rev_user','rev_user_text','rev_timestamp', 'rev_comment','rev_minor_edit' ),
-                 array( 'page_id' => $id, 'page_latest=rev_id' ), $fname, $this->getSelectOptions() );
-
-               if ( $s !== false ) {
-                       $this->mUser = $s->rev_user;
-                       $this->mUserText = $s->rev_user_text;
-                       $this->mTimestamp = wfTimestamp(TS_MW,$s->rev_timestamp);
-                       $this->mComment = $s->rev_comment;
-                       $this->mMinorEdit = $s->rev_minor_edit;
+               $this->mLastRevision = Revision::loadFromPageId( $this->getDB(), $id );
+               if( !is_null( $this->mLastRevision ) ) {
+                       $this->mUser      = $this->mLastRevision->getUser();
+                       $this->mUserText  = $this->mLastRevision->getUserText();
+                       $this->mTimestamp = $this->mLastRevision->getTimestamp();
+                       $this->mComment   = $this->mLastRevision->getComment();
+                       $this->mMinorEdit = $this->mLastRevision->isMinor();
                }
        }
 
@@ -523,6 +579,11 @@ class Article {
                $this->loadLastEdit();
                return $this->mMinorEdit;
        }
+       
+       function getRevIdFetched() {
+               $this->loadLastEdit();
+               return $this->mRevIdFetched;
+       }
 
        function getContributors($limit = 0, $offset = 0) {
                $fname = 'Article::getContributors';
@@ -566,7 +627,7 @@ class Article {
        function view() {
                global $wgUser, $wgOut, $wgRequest, $wgOnlySysopsCanPatrol, $wgLang;
                global $wgLinkCache, $IP, $wgEnableParserCache, $wgStylePath, $wgUseRCPatrol;
-               global $wgEnotif;
+               global $wgEnotif, $wgParser;
                $sk = $wgUser->getSkin();
 
                $fname = 'Article::view';
@@ -585,8 +646,12 @@ class Article {
                if ( !is_null( $diff ) ) {
                        require_once( 'DifferenceEngine.php' );
                        $wgOut->setPageTitle( $this->mTitle->getPrefixedText() );
+                       
                        $de = new DifferenceEngine( $oldid, $diff, $rcid );
+                       // DifferenceEngine directly fetched the revision:
+                       $this->mRevIdFetched = $de->mNewid;
                        $de->showDiffPage();
+
                        if( $diff == 0 ) {
                                # Run view updates for current revision only
                                $this->viewUpdates();
@@ -646,10 +711,13 @@ class Article {
                                # Can't cache redirects
                                $pcache = false;
                        } elseif ( !empty( $rdfrom ) ) {
-                               $sk = $wgUser->getSkin();
-                               $redir = $sk->makeExternalLink( $rdfrom, $rdfrom );
-                               $s = wfMsg( 'redirectedfrom', $redir );
-                               $wgOut->setSubtitle( $s );
+                               global $wgRedirectSources;
+                               if( $wgRedirectSources && preg_match( $wgRedirectSources, $rdfrom ) ) {
+                                       $sk = $wgUser->getSkin();
+                                       $redir = $sk->makeExternalLink( $rdfrom, $rdfrom );
+                                       $s = wfMsg( 'redirectedfrom', $redir );
+                                       $wgOut->setSubtitle( $s );
+                               }
                        }
 
                        # wrap user css and user js in pre and don't parse
@@ -669,7 +737,11 @@ class Article {
 
                                $wgOut->addHTML( '<img valign="center" src="'.$imageUrl.'" alt="#REDIRECT" />' .
                                  '<span class="redirectText">'.$link.'</span>' );
-
+                               
+                               $parseout = $wgParser->parse($text, $this->mTitle, ParserOptions::newFromUser($wgUser));
+                               $catlinks = $parseout->getCategoryLinks();
+                               $wgOut->addCategoryLinks($catlinks);
+                               $skin = $wgUser->getSkin();
                        } else if ( $pcache ) {
                                # Display content and save to parser cache
                                $wgOut->addPrimaryWikiText( $text, $this );
@@ -678,7 +750,12 @@ class Article {
                                $wgOut->addWikiText( $text );
                        }
                }
-               $wgOut->setPageTitle( $this->mTitle->getPrefixedText() );
+               /* title may have been set from the cache */
+               $t = $wgOut->getPageTitle();    
+               if( empty( $t ) ) {
+                       $wgOut->setPageTitle( $this->mTitle->getPrefixedText() );
+               }
+
                # If we have been passed an &rcid= parameter, we want to give the user a
                # chance to mark this new article as patrolled.
                if ( $wgUseRCPatrol && !is_null ( $rcid ) && $rcid != 0 && $wgUser->isLoggedIn() &&
@@ -698,8 +775,6 @@ class Article {
 
                $this->viewUpdates();
                wfProfileOut( $fname );
-
-               $wgUser->clearNotification( $this->mTitle );
        }
 
        /**
@@ -710,10 +785,11 @@ class Article {
         * Best if all done inside a transaction.
         *
         * @param Database $dbw
-        * @return int The newly created page_id key
+        * @param string   $restrictions
+        * @return int     The newly created page_id key
         * @access private
         */
-       function insertOn( &$dbw ) {
+       function insertOn( &$dbw, $restrictions = '' ) {
                $fname = 'Article::insertOn';
                wfProfileIn( $fname );
                
@@ -723,7 +799,7 @@ class Article {
                        'page_namespace'    => $this->mTitle->getNamespace(),
                        'page_title'        => $this->mTitle->getDBkey(),
                        'page_counter'      => 0,
-                       'page_restrictions' => '',
+                       'page_restrictions' => $restrictions,
                        'page_is_redirect'  => 0, # Will set this shortly...
                        'page_is_new'       => 1,
                        'page_random'       => wfRandom(),
@@ -732,6 +808,8 @@ class Article {
                ), $fname );
                $newid = $dbw->insertId();
                
+               $this->mTitle->resetArticleId( $newid );
+               
                wfProfileOut( $fname );
                return $newid;
        }
@@ -740,32 +818,74 @@ class Article {
         * Update the page record to point to a newly saved revision.
         *
         * @param Database $dbw
-        * @param int $revId
-        * @param int $lastRevision
-        * @param bool $isRedirect
+        * @param Revision $revision -- for ID number, and text used to set
+                                       length and redirect status fields
+        * @param int $lastRevision -- if given, will not overwrite the page field
+        *                             when different from the currently set value.
+        *                             Giving 0 indicates the new page flag should
+        *                             be set on.
         * @return bool true on success, false on failure
         * @access private
         */
-       function updateRevisionOn( &$dbw, $revId, $lastRevision, $isRedirect = false ) {
+       function updateRevisionOn( &$dbw, $revision, $lastRevision = null ) {
                $fname = 'Article::updateToRevision';
                wfProfileIn( $fname );
                
+               $conditions = array( 'page_id' => $this->getId() );
+               if( !is_null( $lastRevision ) ) {
+                       # An extra check against threads stepping on each other
+                       $conditions['page_latest'] = $lastRevision;
+               }
+               $text = $revision->getText();
                $dbw->update( 'page',
                        array( /* SET */
-                               'page_latest'      => $revId,
+                               'page_latest'      => $revision->getId(),
                                'page_touched'     => $dbw->timestamp(),
-                               'page_is_new'      => ($lastRevision == 0),
-                               'page_is_redirect' => $isRedirect,
-                       ), array( /* WHERE */
-                               'page_id'          => $this->getId(),
-                               'page_latest'      => $lastRevision, # Paranoia
-                       ), $fname
-               );
+                               'page_is_new'      => ($lastRevision === 0) ? 0 : 1,
+                               'page_is_redirect' => Article::isRedirect( $text ),
+                               'page_len'         => strlen( $text ),
+                       ),
+                       $conditions,
+                       $fname );
                
                wfProfileOut( $fname );
                return ( $dbw->affectedRows() != 0 );
        }
        
+       /**
+        * If the given revision is newer than the currently set page_latest,
+        * update the page record. Otherwise, do nothing.
+        *
+        * @param Database $dbw
+        * @param Revision $revision
+        */
+       function updateIfNewerOn( &$dbw, $revision ) {
+               $fname = 'Article::updateIfNewerOn';
+               wfProfileIn( $fname );
+               
+               $row = $dbw->selectRow(
+                       array( 'revision', 'page' ),
+                       array( 'rev_id', 'rev_timestamp' ),
+                       array(
+                               'page_id' => $this->getId(),
+                               'page_latest=rev_id' ),
+                       $fname );
+               if( $row ) {
+                       if( $row->rev_timestamp >= $revision->getTimestamp() ) {
+                               wfProfileOut( $fname );
+                               return false;
+                       }
+                       $prev = $row->rev_id;
+               } else {
+                       # No or missing previous revision; mark the page as new
+                       $prev = 0;
+               }
+               
+               $ret = $this->updateRevisionOn( $dbw, $revision, $prev );
+               wfProfileOut( $fname );
+               return $ret;
+       }
+       
        /**
         * Theoretically we could defer these whole insert and update
         * functions for after display, but that's taking a big leap
@@ -773,7 +893,7 @@ class Article {
         * errors at some point.
         * @private
         */
-       function insertNewArticle( $text, $summary, $isminor, $watchthis ) {
+       function insertNewArticle( $text, $summary, $isminor, $watchthis, $suppressRC=false ) {
                global $wgOut, $wgUser;
                global $wgUseSquid, $wgDeferredUpdateList, $wgInternalServer;
 
@@ -785,6 +905,7 @@ class Article {
                $ttl = $this->mTitle->getDBkey();
                $text = $this->preSaveTransform( $text );
                $isminor = ( $isminor && $wgUser->isLoggedIn() ) ? 1 : 0;
+               $now = wfTimestampNow();
 
                $dbw =& wfGetDB( DB_MASTER );
 
@@ -803,10 +924,12 @@ class Article {
                $this->mTitle->resetArticleID( $newid );
                
                # Update the page record with revision data
-               $this->updateRevisionOn( $dbw, $revisionId, 0, $this->isRedirect( $text ) );
+               $this->updateRevisionOn( $dbw, $revision, 0 );
 
                Article::onArticleCreate( $this->mTitle );
-               RecentChange::notifyNew( $now, $this->mTitle, $isminor, $wgUser, $summary );
+               if(!$suppressRC) {
+                       RecentChange::notifyNew( $now, $this->mTitle, $isminor, $wgUser, $summary );
+               }
 
                if ($watchthis) {
                        if(!$this->mTitle->userIsWatching()) $this->watch();
@@ -970,19 +1093,19 @@ class Article {
 
                $text = $this->preSaveTransform( $text );
                $dbw =& wfGetDB( DB_MASTER );
+               $now = wfTimestampNow();
 
                # Update article, but only if changed.
 
                # It's important that we either rollback or complete, otherwise an attacker could
                # overwrite cur entries by sending precisely timed user aborts. Random bored users
                # could conceivably have the same effect, especially if cur is locked for long periods.
-               if( $wgDBtransactions ) {
-                       $dbw->query( 'BEGIN', $fname );
-               } else {
+               if( !$wgDBtransactions ) {
                        $userAbort = ignore_user_abort( true );
                }
 
                $oldtext = $this->getContent( true );
+               $lastRevision = 0;
 
                if ( 0 != strcmp( $text, $oldtext ) ) {
                        $this->mCountAdjustment = $this->isCountable( $text )
@@ -1001,7 +1124,7 @@ class Article {
                        $revisionId = $revision->insertOn( $dbw );
                        
                        # Update page
-                       $ok = $this->updateRevisionOn( $dbw, $revisionId, $lastRevision, $redir );
+                       $ok = $this->updateRevisionOn( $dbw, $revision, $lastRevision );
 
                        if( !$ok ) {
                                /* Belated edit conflict! Run away!! */
@@ -1009,15 +1132,13 @@ class Article {
                        } else {
                                # Update recentchanges and purge cache and whatnot
                                $bot = (int)($wgUser->isBot() || $forceBot);
-                               RecentChange::notifyEdit( $now, $this->mTitle, $me2, $wgUser, $summary,
+                               RecentChange::notifyEdit( $now, $this->mTitle, $isminor, $wgUser, $summary,
                                        $lastRevision, $this->getTimestamp(), $bot );
                                Article::onArticleEdit( $this->mTitle );
                        }
                }
 
-               if( $wgDBtransactions ) {
-                       $dbw->query( 'COMMIT', $fname );
-               } else {
+               if( !$wgDBtransactions ) {
                        ignore_user_abort( $userAbort );
                }
 
@@ -1053,7 +1174,7 @@ class Article {
                                array_push( $wgPostCommitUpdateList, $u );
                        }
        
-                       $this->showArticle( $text, wfMsg( 'updated' ), $sectionanchor, $me2, $now, $summary, $lastRevision );
+                       $this->showArticle( $text, wfMsg( 'updated' ), $sectionanchor, $isminor, $now, $summary, $lastRevision );
                }
                return $good;
        }
@@ -1132,6 +1253,31 @@ class Article {
                }
        }
 
+       /**
+        * Validate function
+        */
+       function validate() {
+               global $wgOut, $wgUser, $wgRequest, $wgUseValidation;
+               
+               if ( !$wgUseValidation ) # Are we using article validation at all?
+               {
+                       $wgOut->errorpage( "nosuchspecialpage", "nospecialpagetext" );
+                       return ;
+               }
+               
+               $wgOut->setRobotpolicy( 'noindex,follow' );
+               $revision = $wgRequest->getVal( 'revision' );
+               
+               include_once ( "SpecialValidate.php" ) ; # The "Validation" class
+               
+               $v = new Validation ;
+               if ( $wgRequest->getVal ( "mode" , "" ) == "list" )
+                       $t = $v->showList ( $this ) ;
+               else
+                       $t = $v->validatePageForm ( $this , $revision ) ;
+               
+               $wgOut->addHTML ( $t ) ;
+       }
 
        /**
         * Add this page to $wgUser's watchlist
@@ -1150,13 +1296,13 @@ class Article {
                        return;
                }
 
-               if (wfRunHooks('WatchArticle', $wgUser, $this)) {
+               if (wfRunHooks('WatchArticle', array(&$wgUser, &$this))) {
                        
                        $wgUser->addWatch( $this->mTitle );
                        $wgUser->saveSettings();
 
-                       wfRunHooks('WatchArticleComplete', $wgUser, $this);
-                       
+                       wfRunHooks('WatchArticleComplete', array(&$wgUser, &$this));
+
                        $wgOut->setPagetitle( wfMsg( 'addedwatch' ) );
                        $wgOut->setRobotpolicy( 'noindex,follow' );
                        
@@ -1185,12 +1331,12 @@ class Article {
                        return;
                }
 
-               if (wfRunHooks('UnwatchArticle', $wgUser, $this)) {
+               if (wfRunHooks('UnwatchArticle', array(&$wgUser, &$this))) {
                        
                        $wgUser->removeWatch( $this->mTitle );
                        $wgUser->saveSettings();
                        
-                       wfRunHooks('UnwatchArticleComplete', $wgUser, $this);
+                       wfRunHooks('UnwatchArticleComplete', array(&$wgUser, &$this));
                        
                        $wgOut->setPagetitle( wfMsg( 'removedwatch' ) );
                        $wgOut->setRobotpolicy( 'noindex,follow' );
@@ -1243,7 +1389,7 @@ class Article {
                        if( !$moveonly ) {
                                $restrictions .= ":edit=" . $limit;
                        }
-                       if (wfRunHooks('ArticleProtect', $this, $wgUser, $limit == 'sysop', $reason, $moveonly)) {
+                       if (wfRunHooks('ArticleProtect', array(&$this, &$wgUser, $limit == 'sysop', $reason, $moveonly))) {
                                
                                $dbw =& wfGetDB( DB_MASTER );
                                $dbw->update( 'page',
@@ -1255,7 +1401,7 @@ class Article {
                                                                                           ), 'Article::protect'
                                                          );
                                
-                               wfRunHooks('ArticleProtectComplete', $this, $wgUser, $limit == 'sysop', $reason, $moveonly);
+                               wfRunHooks('ArticleProtectComplete', array(&$this, &$wgUser, $limit == 'sysop', $reason, $moveonly));
                                
                                $log = new LogPage( 'protect' );
                                if ( $limit === '' ) {
@@ -1315,9 +1461,6 @@ class Article {
                        <td align='left'>
                                <input type='text' size='60' name='wpReasonProtect' id='wpReasonProtect' value=\"" . htmlspecialchars( $reason ) . "\" />
                        </td>
-               </tr>
-               <tr>
-                       <td>&nbsp;</td>
                </tr>" );
                if($moveonly != '') {
                        $wgOut->AddHTML( "
@@ -1325,7 +1468,7 @@ class Article {
                        <td align='right'>
                                <input type='checkbox' name='wpMoveOnly' value='1' id='wpMoveOnly' />
                        </td>
-                       <td>
+                       <td align='left'>
                                <label for='wpMoveOnly'>{$moveonly}</label>
                        </td>
                </tr> " );
@@ -1339,7 +1482,7 @@ class Article {
                </tr>
        </table>
        <input type='hidden' name='wpEditToken' value=\"{$token}\" />
-</form>\n" );
+</form>" );
 
                $wgOut->returnToMain( false );
        }
@@ -1493,9 +1636,6 @@ class Article {
                                <input type='text' size='60' name='wpReason' id='wpReason' value=\"" . htmlspecialchars( $reason ) . "\" />
                        </td>
                </tr>
-               <tr>
-                       <td>&nbsp;</td>
-               </tr>
                <tr>
                        <td>&nbsp;</td>
                        <td>
@@ -1518,7 +1658,7 @@ class Article {
                $fname = 'Article::doDelete';
                wfDebug( $fname."\n" );
 
-               if (wfRunHooks('ArticleDelete', $this, $wgUser, $reason)) {
+               if (wfRunHooks('ArticleDelete', array(&$this, &$wgUser, &$reason))) {
                        if ( $this->doDeleteArticle( $reason ) ) {
                                $deleted = $this->mTitle->getPrefixedText();
                                
@@ -1534,7 +1674,7 @@ class Article {
                                
                                $wgOut->addHTML( '<p>' . $text . "</p>\n" );
                                $wgOut->returnToMain( false );
-                               wfRunHooks('ArticleDeleteComplete', $this, $wgUser, $reason);
+                               wfRunHooks('ArticleDeleteComplete', array(&$this, &$wgUser, $reason));
                        } else {
                                $wgOut->fatalError( wfMsg( 'cannotdelete' ) );
                        }
@@ -1677,70 +1817,76 @@ class Article {
                $n = $this->mTitle->getNamespace();
 
                # Get the last editor, lock table exclusively
-               $s = $dbw->selectRow( array( 'page', 'revision' ),
-                       array( 'page_id','rev_user','rev_user_text','rev_comment' ),
-                       array( 'page_title' => $tt, 'page_namespace' => $n ),
-                       $fname, 'FOR UPDATE'
-               );
-               if( $s === false ) {
-                       # Something wrong
+               $dbw->begin();
+               $current = Revision::newFromTitle( $this->mTitle );
+               if( is_null( $current ) ) {
+                       # Something wrong... no page?
+                       $dbw->rollback();
                        $wgOut->addHTML( wfMsg( 'notanarticle' ) );
                        return;
                }
-               $ut = $dbw->strencode( $s->cur_user_text );
-               $uid = $s->rev_user;
-               $pid = $s->page_id;
 
                $from = str_replace( '_', ' ', $wgRequest->getVal( 'from' ) );
-               if( $from != $s->rev_user_text ) {
+               if( $from != $current->getUserText() ) {
                        $wgOut->setPageTitle(wfmsg('rollbackfailed'));
                        $wgOut->addWikiText( wfMsg( 'alreadyrolled',
                                htmlspecialchars( $this->mTitle->getPrefixedText()),
                                htmlspecialchars( $from ),
-                               htmlspecialchars( $s->rev_user_text ) ) );
-                       if($s->rev_comment != '') {
+                               htmlspecialchars( $current->getUserText() ) ) );
+                       if( $current->getComment() != '') {
                                $wgOut->addHTML(
-                                       wfMsg('editcomment',
-                                       htmlspecialchars( $s->rev_comment ) ) );
+                                       wfMsg( 'editcomment',
+                                       htmlspecialchars( $current->getComment() ) ) );
                        }
                        return;
                }
 
                # Get the last edit not by this guy
-               $s = $dbw->selectRow( 'old',
-                       array( 'old_text','old_user','old_user_text','old_timestamp','old_flags' ),
+               $user = IntVal( $current->getUser() );
+               $user_text = $dbw->addQuotes( $current->getUserText() );
+               $s = $dbw->selectRow( 'revision',
+                       array( 'rev_id', 'rev_timestamp' ),
                        array(
-                               'old_namespace' => $n,
-                               'old_title' => $tt,
-                               "old_user <> {$uid} OR old_user_text <> '{$ut}'"
-                       ), $fname, array( 'FOR UPDATE', 'USE INDEX' => 'name_title_timestamp' )
-               );
+                               'rev_page' => $current->getPage(),
+                               "rev_user <> {$user} OR rev_user_text <> {$user_text}"
+                       ), $fname,
+                       array(
+                               'USE INDEX' => 'page_timestamp',
+                               'ORDER BY'  => 'rev_timestamp DESC' )
+                       );
                if( $s === false ) {
                        # Something wrong
+                       $dbw->rollback();
                        $wgOut->setPageTitle(wfMsg('rollbackfailed'));
                        $wgOut->addHTML( wfMsg( 'cantrollback' ) );
                        return;
                }
-
+               
                if ( $bot ) {
                        # Mark all reverted edits as bot
                        $dbw->update( 'recentchanges',
                                array( /* SET */
                                        'rc_bot' => 1
                                ), array( /* WHERE */
-                                       'rc_user' => $uid,
-                                       "rc_timestamp > '{$s->old_timestamp}'",
+                                       'rc_cur_id'    => $current->getPage(),
+                                       'rc_user_text' => $current->getUserText(),
+                                       "rc_timestamp > '{$s->rev_timestamp}'",
                                ), $fname
                        );
                }
 
                # Save it!
-               $newcomment = wfMsg( 'revertpage', $s->old_user_text, $from );
+               $target = Revision::newFromId( $s->rev_id );
+               $newcomment = wfMsg( 'revertpage', $target->getUserText(), $from );
+               
                $wgOut->setPagetitle( wfMsg( 'actioncomplete' ) );
                $wgOut->setRobotpolicy( 'noindex,nofollow' );
                $wgOut->addHTML( '<h2>' . htmlspecialchars( $newcomment ) . "</h2>\n<hr />\n" );
-               $this->updateArticle( Revision::getRevisionText( $s ), $newcomment, 1, $this->mTitle->userIsWatching(), $bot );
+               
+               $this->updateArticle( $target->getText(), $newcomment, 1, $this->mTitle->userIsWatching(), $bot );
                Article::onArticleEdit( $this->mTitle );
+               
+               $dbw->commit();
                $wgOut->returnToMain( false );
        }
 
@@ -1769,7 +1915,10 @@ class Article {
                        $this->mTitle->getText() == $wgUser->getName()) {
                        require_once( 'UserTalkUpdate.php' );
                        $u = new UserTalkUpdate( 0, $this->mTitle->getNamespace(), $this->mTitle->getDBkey(), false, false, false );
+               } else {
+                       $wgUser->clearNotification( $this->mTitle );
                }
+
        }
 
        /**
@@ -1908,64 +2057,41 @@ class Article {
         */
        function checkTouched() {
                $fname = 'Article::checkTouched';
-               $id = $this->getID();
-               $dbr =& $this->getDB();
-               $s = $dbr->selectRow( 'page', array( 'page_touched', 'page_is_redirect' ),
-                       array( 'page_id' => $id ), $fname, $this->getSelectOptions() );
-               if( $s !== false ) {
-                       $this->mTouched = wfTimestamp( TS_MW, $s->page_touched );
-                       return !$s->page_is_redirect;
-               } else {
-                       return false;
+               if( !$this->mDataLoaded ) {
+                       $dbr =& $this->getDB();
+                       $data = $this->pageDataFromId( $dbr, $this->getId() );
+                       if( $data ) {
+                               $this->loadPageData( $data );
+                       }
                }
+               return !$this->mIsRedirect;
        }
 
        /**
         * Edit an article without doing all that other stuff
+        * The article must already exist; link tables etc
+        * are not updated, caches are not flushed.
         *
         * @param string $text text submitted
         * @param string $comment comment submitted
-        * @param integer $minor whereas it's a minor modification
+        * @param bool $minor whereas it's a minor modification
         */
        function quickEdit( $text, $comment = '', $minor = 0 ) {
-               global $wgUser;
                $fname = 'Article::quickEdit';
-
-               #wfDebugDieBacktrace( "$fname called." );
-
                wfProfileIn( $fname );
 
                $dbw =& wfGetDB( DB_MASTER );
-               $ns = $this->mTitle->getNamespace();
-               $dbkey = $this->mTitle->getDBkey();
-               $encDbKey = $dbw->strencode( $dbkey );
-               $timestamp = $dbw->timestamp();
-               # insert new text
-               $dbw->insert( 'text', array(
-                               'old_text' => $text,
-                               'old_flags' => "" ), $fname );
-               $text_id = $dbw->insertID();
-
-               # update page
-               $dbw->update( 'page', array(
-                       'page_is_new' => 0,
-                       'page_touched' => $timestamp,
-                       'page_is_redirect' => $this->isRedirect( $text ) ? 1 : 0,
-                       'page_latest' => $text_id ),
-                       array( 'page_namespace' => $ns, 'page_title' => $dbkey ), $fname );
-               # Retrieve page ID
-               $page_id = $dbw->selectField( 'page', 'page_id', array( 'page_namespace' => $ns, 'page_title' => $dbkey ), $fname );
-
-               # update revision
-               $dbw->insert( 'revision', array(
-                       'rev_id' => $text_id,
-                       'rev_page' => $page_id,
-                       'rev_comment' => $comment,
-                       'rev_user' => $wgUser->getID(),
-                       'rev_user_text' => $wgUser->getName(),
-                       'rev_timestamp' => $timestamp,
-                       'rev_minor_edit' => intval($minor) ),
-                       $fname );
+               $dbw->begin();
+               $revision = new Revision( array(
+                       'page'       => $this->getId(),
+                       'text'       => $text,
+                       'comment'    => $comment,
+                       'minor_edit' => $minor ? 1 : 0,
+                       ) );
+               $revisionId = $revision->insertOn( $dbw );
+               $this->updateRevisionOn( $dbw, $revision );
+               $dbw->commit();
+               
                wfProfileOut( $fname );
        }
 
@@ -2151,34 +2277,36 @@ class Article {
                
                return array( 'edits' => $edits, 'authors' => $authors );
        }
-}
 
-/**
- * Check whether an article is a stub
- *
- * @public
- * @param integer $articleID   ID of the article that is to be checked
- */
-function wfArticleIsStub( $articleID ) {
-       global $wgUser;
-       $fname = 'wfArticleIsStub';
-
-       wfDebugDieBacktrace( 'This function seems to be unused. Pending removal.' );
-
-       $threshold = $wgUser->getOption('stubthreshold') ;
-       if ( $threshold > 0 ) {
-               $dbr =& wfGetDB( DB_SLAVE );
-               $s = $dbr->selectRow( array('page', 'text'),
-                       array( 'LENGTH(old_text) AS len', 'page_namespace', 'page_is_redirect' ),
-                       array( 'page_id' => $articleID, "page.page_latest=text.old_id" ),
-                       $fname ) ;
-               if ( $s == false OR $s->page_is_redirect OR $s->page_namespace != NS_MAIN ) {
-                       return false;
+       /**
+        * Return a list of templates used by this article.
+        * Uses the links table to find the templates
+        *
+        * @return array
+        */
+       function getUsedTemplates() {
+               $result = array();
+               $id = $this->mTitle->getArticleID();
+
+               $db =& wfGetDB( DB_SLAVE );
+               $page = $db->tableName( 'page' );
+               $links = $db->tableName( 'links' );
+               $sql = "SELECT page_title ".
+                       "FROM $page,$links WHERE l_to=page_id AND l_from={$id} and page_namespace=".NS_TEMPLATE;
+               $res = $db->query( $sql, "Article:getUsedTemplates" );
+               if ( false !== $res ) {
+                       if ( $db->numRows( $res ) ) {
+                               while ( $row = $db->fetchObject( $res ) ) {
+                                       $result[] = $row->page_title;
+                               }
+                       }
                }
-               $size = $s->len;
-               return ( $size < $threshold );
+               $db->freeResult( $res );
+               return $result;
        }
-       return false;
+
+
 }
 
+
 ?>