From f422ee6bf274722fbd48f7a19a59ab6e3fe9d18b Mon Sep 17 00:00:00 2001 From: Kevin Israel Date: Sun, 29 Mar 2015 14:07:46 -0400 Subject: [PATCH] Fix ORDER BY in fixUserRegistration.php Non-boolean options for select() must be provided as key-value pairs. If provided as numbered elements, they will not end up in the generated query. Follows-up ea406e42cd41. Change-Id: I0364618b6a805c353cdc19a60f157df33519d87a --- maintenance/fixUserRegistration.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/maintenance/fixUserRegistration.php b/maintenance/fixUserRegistration.php index 43f4b6c0eb..40e091595e 100644 --- a/maintenance/fixUserRegistration.php +++ b/maintenance/fixUserRegistration.php @@ -46,13 +46,13 @@ class FixUserRegistration extends Maintenance { 'user', 'user_id', array( - 'user_id >' . $dbw->addQuotes( $lastId ), + 'user_id > ' . $dbw->addQuotes( $lastId ), 'user_registration IS NULL' ), __METHOD__, array( 'LIMIT' => $this->mBatchSize, - 'ORDER BY user_id ASC', + 'ORDER BY' => 'user_id', ) ); foreach ( $res as $row ) { -- 2.20.1