From eb4f75c87a5573e42feb079e599efd2be6629abb Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Mon, 10 Apr 2017 16:13:20 +0100 Subject: [PATCH] Fixes to mw.notifications * Fix cutting of drop shadows * Use null as default empty value Change-Id: I09b77161c3a2cc0ef586c08c7287a73bd1dd2066 --- resources/src/mediawiki/mediawiki.notification.css | 3 ++- resources/src/mediawiki/mediawiki.notification.js | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/resources/src/mediawiki/mediawiki.notification.css b/resources/src/mediawiki/mediawiki.notification.css index 147de92f7e..633798d9c9 100644 --- a/resources/src/mediawiki/mediawiki.notification.css +++ b/resources/src/mediawiki/mediawiki.notification.css @@ -1,7 +1,8 @@ .mw-notification-area { top: 0; right: 0; - padding: 1em 1em 0 0; + /* Padding on all sides so drop shadows aren't cut by overflow: hidden */ + padding: 1em; width: 20em; line-height: 1.35; z-index: 10000; diff --git a/resources/src/mediawiki/mediawiki.notification.js b/resources/src/mediawiki/mediawiki.notification.js index 4849f5a08b..d36c4a06b9 100644 --- a/resources/src/mediawiki/mediawiki.notification.js +++ b/resources/src/mediawiki/mediawiki.notification.js @@ -396,9 +396,9 @@ defaults: { autoHide: true, autoHideSeconds: 'short', - tag: false, - title: undefined, - type: false + tag: null, + title: null, + type: null }, /** -- 2.20.1