From db1226cd9bd5866a741d54a6d74bf80f27355def Mon Sep 17 00:00:00 2001 From: petarpetkovic Date: Wed, 20 Dec 2017 18:50:03 +0100 Subject: [PATCH] Fix old style filters disappearing regression Add FormWrapperWidget after controller is initialized, to avoid it being removed when changes list view model is updated during initialization. Change-Id: I3bd4d1bc9efbcdbf99493498267ed1a690fd1ab2 --- resources/src/mediawiki.rcfilters/mw.rcfilters.init.js | 2 ++ .../mediawiki.rcfilters/ui/mw.rcfilters.ui.MainWrapperWidget.js | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js index f7708996ee..fe8bcf419f 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js @@ -100,6 +100,8 @@ conditionalViews ); + mainWrapperWidget.initFormWidget( specialPage ); + $( 'a.mw-helplink' ).attr( 'href', 'https://www.mediawiki.org/wiki/Special:MyLanguage/Help:New_filters_for_edit_review' diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MainWrapperWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MainWrapperWidget.js index e64ffd8e7e..8002045dc8 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MainWrapperWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MainWrapperWidget.js @@ -61,7 +61,6 @@ $( 'body' ) .append( this.$overlay ) .addClass( 'mw-rcfilters-ui-initialized' ); - this.initFormWidget(); }; /* Initialization */ -- 2.20.1