From d807a9dc4ac1a4216664428f75cb56abc77a9b5c Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Fri, 17 Jul 2015 15:22:54 -0700 Subject: [PATCH] Added FIXME to default Database replace() implementation Change-Id: I3ec0ec066248ee733b41f9c70d40382d96898613 --- includes/db/Database.php | 1 + 1 file changed, 1 insertion(+) diff --git a/includes/db/Database.php b/includes/db/Database.php index 2f1155dd78..04b3edd3b1 100644 --- a/includes/db/Database.php +++ b/includes/db/Database.php @@ -2873,6 +2873,7 @@ abstract class DatabaseBase implements IDatabase { $rows = array( $rows ); } + // @FXIME: this is not atomic, but a trx would break affectedRows() foreach ( $rows as $row ) { # Delete rows which collide if ( $uniqueIndexes ) { -- 2.20.1