From 85403c05ddd438e2635acbb2c68033c4f9504e18 Mon Sep 17 00:00:00 2001
From: Antoine Musso <hashar@users.mediawiki.org>
Date: Sun, 14 Mar 2004 01:44:17 +0000
Subject: [PATCH] Lighter version using a sub function to avoid repetiting
 code. Will ease futur status integration as well.

---
 includes/SpecialSpecialpages.php | 55 +++++++++++++++-----------------
 1 file changed, 26 insertions(+), 29 deletions(-)

diff --git a/includes/SpecialSpecialpages.php b/includes/SpecialSpecialpages.php
index 9805fa5293..91e6163af8 100644
--- a/includes/SpecialSpecialpages.php
+++ b/includes/SpecialSpecialpages.php
@@ -2,26 +2,19 @@
 
 function wfSpecialSpecialpages()
 {
-	global $wgUser, $wgOut, $wgLang;
-
-	$wgOut->setRobotpolicy( "index,nofollow" );
-
-	$sk = $wgUser->getSkin();
-	$validSP = $wgLang->getValidSpecialPages();
-	$wgOut->addHTML( "<h2>" . wfMsg( "spheading" ) . "</h2>\n<ul>" );
-
-	foreach ( $validSP as $name => $desc ) {
-		if ( "" == $desc ) { continue; }
-		$link = $sk->makeKnownLink( $wgLang->specialPage( $name ), $desc );
-		$wgOut->addHTML( "<li>{$link}</li>\n" );
-	}
-	$wgOut->addHTML( "</ul>\n" );
-
-	if ( $wgUser->isSysop() ) {
-		$sysopSP = $wgLang->getSysopSpecialPages();
-		$wgOut->addHTML( "<h2>" . wfMsg( "sysopspheading" ) . "</h2>\n<ul>" );
-
-		foreach ( $sysopSP as $name => $desc ) {
+	global $wgLang, $wgOut, $wgUser;
+	
+	# sub function generating the list of pages
+	#   $SP      : the list of pages
+	#   $heading : header to be used
+	#   $sk      : skin object ???
+	
+	function wfSpecialSpecialpages_gen($SP,$heading,$sk)
+	{
+		global $wgLang, $wgOut;
+
+		$wgOut->addHTML( "<h2>" . wfMsg( $heading ) . "</h2>\n<ul>" );
+		foreach ( $SP as $name => $desc ) {
 			if ( "" == $desc ) { continue; }
 			$link = $sk->makeKnownLink( $wgLang->specialPage( $name ), $desc );
 			$wgOut->addHTML( "<li>{$link}</li>\n" );
@@ -29,17 +22,21 @@ function wfSpecialSpecialpages()
 		$wgOut->addHTML( "</ul>\n" );
 	}
 
+	$wgOut->setRobotpolicy( "index,nofollow" );
+	$sk = $wgUser->getSkin();	
+
+	# all users special pages
+	wfSpecialSpecialpages_gen($wgLang->getValidSpecialPages(),"spheading",$sk);
+
+	# sysops only special pages
+	if ( $wgUser->isSysop() ) {
+		wfSpecialSpecialpages_gen($wgLang->getSysopSpecialPages(),"sysopspheading",$sk);
+	}
+
+	# developers only special pages
 	if ( $wgUser->isDeveloper() ) {
-		$devSP = $wgLang->getDeveloperSpecialPages();
-		$wgOut->addHTML( "<h2>" . wfMsg( "developerspheading" ) .
-		  "</h2>\n<ul>" );
+		wfSpecialSpecialpages_gen($wgLang->getDeveloperSpecialPages(),"developerspheading",$sk);
 
-		foreach ( $devSP as $name => $desc ) {
-			if ( "" == $desc ) { continue; }
-			$link = $sk->makeKnownLink( $wgLang->specialPage( $name ), $desc );
-			$wgOut->addHTML( "<li>{$link}</li>\n" );
-		}
-		$wgOut->addHTML( "</ul>\n" );
 	}
 }
 
-- 
2.20.1