From 25d84b8da85e963a3126d0e996c1ce1aa14581b2 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Tue, 17 Apr 2018 22:33:41 +0100 Subject: [PATCH] WebStart: Remove redundant unset() for $IP This seems redundant given it is unconditionally being set two statements later. Probably a left-over from r36353 (c6b902f180), which did an unset() because there was another variable called $preIP, and the original would no longer be needed. However, we currently only use one variable ($IP) and there's no need to unset() it before setting. Bug: T189966 Change-Id: I17d516709beabeb80bd72b37f70ac9b666a501d4 (cherry picked from commit 3aa0b0567ff64ecb74df7534c8812c78c323df7c) --- includes/WebStart.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/includes/WebStart.php b/includes/WebStart.php index c9aecce4e0..6f3aa71624 100644 --- a/includes/WebStart.php +++ b/includes/WebStart.php @@ -41,8 +41,6 @@ header( 'X-Content-Type-Options: nosniff' ); */ $wgRequestTime = $_SERVER['REQUEST_TIME_FLOAT']; -unset( $IP ); - # Valid web server entry point, enable includes. # Please don't move this line to includes/Defines.php. This line essentially # defines a valid entry point. If you put it in includes/Defines.php, then -- 2.20.1