From 13f159a3a093e84544b85614901af18c14cf8c62 Mon Sep 17 00:00:00 2001 From: Reedy Date: Sun, 20 Dec 2015 14:24:07 +0000 Subject: [PATCH] ApiQueryBase::checkRowCount() was removed Deprecated since 1.24 Change-Id: Id3357ccd8b5eb3f5e2fe1c63fc7b72ae38d6ac1a --- RELEASE-NOTES-1.27 | 1 + includes/api/ApiQueryBase.php | 24 ------------------------ 2 files changed, 1 insertion(+), 24 deletions(-) diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27 index 3289da5d1d..daa1b8f48e 100644 --- a/RELEASE-NOTES-1.27 +++ b/RELEASE-NOTES-1.27 @@ -191,6 +191,7 @@ changes to languages because of Phabricator reports. * User::editToken() was removed (deprecated since 1.19). * ApiQueryBase::titleToKey(), ApiQueryBase::keyToTitle() and ApiQueryBase::keyPartToTitle() all removed (deprecated since 1.24). +* ApiQueryBase::checkRowCount() was removed (deprecated since 1.24). == Compatibility == diff --git a/includes/api/ApiQueryBase.php b/includes/api/ApiQueryBase.php index 87f89044be..76bbc5d09f 100644 --- a/includes/api/ApiQueryBase.php +++ b/includes/api/ApiQueryBase.php @@ -587,30 +587,6 @@ abstract class ApiQueryBase extends ApiBase { * @{ */ - /** - * Estimate the row count for the SELECT query that would be run if we - * called select() right now, and check if it's acceptable. - * @deprecated since 1.24 - * @return bool True if acceptable, false otherwise - */ - protected function checkRowCount() { - wfDeprecated( __METHOD__, '1.24' ); - $db = $this->getDB(); - $rowcount = $db->estimateRowCount( - $this->tables, - $this->fields, - $this->where, - __METHOD__, - $this->options - ); - - if ( $rowcount > $this->getConfig()->get( 'APIMaxDBRows' ) ) { - return false; - } - - return true; - } - /** * Gets the personalised direction parameter description * -- 2.20.1