From 0b58cdc7f2d95b84b5e6d1c2a62a17fdd94ce86a Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 19 Apr 2017 15:38:32 -0700 Subject: [PATCH] Lower the amount of jobs pushed into redis at once This further limits how long the server can be tied up by push(). Change-Id: I02d242578dadc19912c9fccfdcf5e15c5eb78e9e --- includes/jobqueue/JobQueueRedis.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/jobqueue/JobQueueRedis.php b/includes/jobqueue/JobQueueRedis.php index c2c9d66119..eb91680815 100644 --- a/includes/jobqueue/JobQueueRedis.php +++ b/includes/jobqueue/JobQueueRedis.php @@ -75,6 +75,8 @@ class JobQueueRedis extends JobQueue { /** @var string Compression method to use */ protected $compression; + const MAX_PUSH_SIZE = 25; // avoid tying up the server + /** * @param array $params Possible keys: * - redisConfig : An array of parameters to RedisConnectionPool::__construct(). @@ -212,7 +214,7 @@ class JobQueueRedis extends JobQueue { if ( $flags & self::QOS_ATOMIC ) { $batches = [ $items ]; // all or nothing } else { - $batches = array_chunk( $items, 100 ); // avoid tying up the server + $batches = array_chunk( $items, self::MAX_PUSH_SIZE ); } $failed = 0; $pushed = 0; -- 2.20.1