From: Brion Vibber <brion@users.mediawiki.org>
Date: Tue, 13 Dec 2005 00:42:39 +0000 (+0000)
Subject: Add fixme note for ArticleViewHeader hook, which appears to be misplaced.
X-Git-Tag: 1.6.0~951
X-Git-Url: https://git.cyclocoop.org/%27.%24link.%27?a=commitdiff_plain;h=db8fc03440e96c279e5deb6064a73010810a1d31;p=lhc%2Fweb%2Fwiklou.git

Add fixme note for ArticleViewHeader hook, which appears to be misplaced.
If the view is a parser cache hit, the hook will not be called.
---

diff --git a/includes/Article.php b/includes/Article.php
index fc0efc8051..6a4a65d673 100644
--- a/includes/Article.php
+++ b/includes/Article.php
@@ -786,6 +786,10 @@ class Article {
 			}
 		}
 		if( !$outputDone ) {
+			/**
+			 * @fixme: this hook doesn't work most of the time, as it doesn't
+			 * trigger when the parser cache is used.
+			 */
 			wfRunHooks( 'ArticleViewHeader', array( &$this ) ) ;
 			# wrap user css and user js in pre and don't parse
 			# XXX: use $this->mTitle->usCssJsSubpage() when php is fixed/ a workaround is found