From: Sam Reed <reedy@users.mediawiki.org>
Date: Sun, 11 Mar 2012 23:40:33 +0000 (+0000)
Subject: Bug 35162 - Change in Database api break extension MSSQLBackCompat
X-Git-Tag: 1.31.0-rc.0~24295
X-Git-Url: https://git.cyclocoop.org/%27.%24link.%27?a=commitdiff_plain;h=c6f38f8bf632651d1239de4a1d2deeabdb424db7;p=lhc%2Fweb%2Fwiklou.git

Bug 35162 - Change in Database api break extension MSSQLBackCompat

$canonicalDBTypes is probably superfluous information, but doesn't harm as a shortcut

Ping r108051
---

diff --git a/includes/db/Database.php b/includes/db/Database.php
index 47eb596d6a..5c03617445 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -680,7 +680,7 @@ abstract class DatabaseBase implements DatabaseType {
 		$dbType = strtolower( $dbType );
 		$class = 'Database' . ucfirst( $dbType );
 
-		if( in_array( $dbType, $canonicalDBTypes ) ) {
+		if( in_array( $dbType, $canonicalDBTypes ) || ( class_exists( $class ) && is_subclass_of( $class, 'DatabaseBase' ) ) ) {
 			return new $class(
 				isset( $p['host'] ) ? $p['host'] : false,
 				isset( $p['user'] ) ? $p['user'] : false,
@@ -689,8 +689,6 @@ abstract class DatabaseBase implements DatabaseType {
 				isset( $p['flags'] ) ? $p['flags'] : 0,
 				isset( $p['tablePrefix'] ) ? $p['tablePrefix'] : 'get from global'
 			);
-		} elseif ( class_exists( $class ) && is_subclass_of( $class, 'DatabaseBase' ) ) {
-			return new $class( $p );
 		} else {
 			return null;
 		}