From: daniel <daniel.kinzler@wikimedia.de>
Date: Thu, 26 Feb 2015 21:35:18 +0000 (+0100)
Subject: ParserOptions: added comment regarding editsections usage.
X-Git-Tag: 1.31.0-rc.0~10122^2
X-Git-Url: https://git.cyclocoop.org/%27.%24link.%27?a=commitdiff_plain;h=a86ad78b558f390fd5195f39dd544c51b6611f94;p=lhc%2Fweb%2Fwiklou.git

ParserOptions: added comment regarding editsections usage.

// @note: as of Feb 2015, core never sets the editsection flag, since it uses
// <mw:editsection> tags to inject editsections on the fly. However, extensions
// may be using it by calling ParserOption::optionUsed resp. ParserOutput::registerOption
// directly. At least Wikibase does at this point in time.

Change-Id: Ief95ecb3ae1f5699b788dd3dad0eaf1aa6cc163c
---

diff --git a/includes/parser/ParserOptions.php b/includes/parser/ParserOptions.php
index 4459047a35..1073aed817 100644
--- a/includes/parser/ParserOptions.php
+++ b/includes/parser/ParserOptions.php
@@ -802,6 +802,10 @@ class ParserOptions {
 
 		$confstr .= $wgRenderHashAppend;
 
+		// @note: as of Feb 2015, core never sets the editsection flag, since it uses
+		// <mw:editsection> tags to inject editsections on the fly. However, extensions
+		// may be using it by calling ParserOption::optionUsed resp. ParserOutput::registerOption
+		// directly. At least Wikibase does at this point in time.
 		if ( !in_array( 'editsection', $forOptions ) ) {
 			$confstr .= '!*';
 		} elseif ( !$this->mEditSection ) {