Replace some MWException usage in User
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 25 Jun 2015 20:02:18 +0000 (13:02 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 1 Jul 2015 04:07:48 +0000 (21:07 -0700)
Change-Id: I61dbd6223354530311c497ad0f45ed49a573d0cb

includes/User.php

index 1ee8173..f0614fe 100644 (file)
@@ -369,7 +369,8 @@ class User implements IDBAccessObject {
                                Hooks::run( 'UserLoadAfterLoadFromSession', array( $this ) );
                                break;
                        default:
-                               throw new MWException( "Unrecognised value for User->mFrom: \"{$this->mFrom}\"" );
+                               throw new UnexpectedValueException(
+                                       "Unrecognised value for User->mFrom: \"{$this->mFrom}\"" );
                }
        }
 
@@ -943,7 +944,7 @@ class User implements IDBAccessObject {
         *   - 'usable'     Valid for batch processes and login
         *   - 'creatable'  Valid for batch processes, login and account creation
         *
-        * @throws MWException
+        * @throws InvalidArgumentException
         * @return bool|string
         */
        public static function getCanonicalName( $name, $validate = 'valid' ) {
@@ -990,7 +991,8 @@ class User implements IDBAccessObject {
                                }
                                break;
                        default:
-                               throw new MWException( 'Invalid parameter value for $validate in ' . __METHOD__ );
+                               throw new InvalidArgumentException(
+                                       'Invalid parameter value for $validate in ' . __METHOD__ );
                }
                return $name;
        }