From: Huji Lee <huji.huji@gmail.com>
Date: Mon, 3 Oct 2016 18:34:50 +0000 (-0400)
Subject: Password reset link is shown when no reset options are available
X-Git-Tag: 1.31.0-rc.0~5161^2
X-Git-Url: https://git.cyclocoop.org/%7B%7B%20url_for%28?a=commitdiff_plain;h=183f0bd5e382ae67707a4829c482649e1fa83bf9;p=lhc%2Fweb%2Fwiklou.git

Password reset link is shown when no reset options are available

Bug: T144705
Change-Id: I7d6b563e32039e7313121de9629f02ad4f02d351
---

diff --git a/includes/specialpage/LoginSignupSpecialPage.php b/includes/specialpage/LoginSignupSpecialPage.php
index bf83e7bb37..275e12191e 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -1070,7 +1070,7 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
 		}
 		if ( !$this->isSignup() && $this->showExtraInformation() ) {
 			$passwordReset = new PasswordReset( $this->getConfig(), AuthManager::singleton() );
-			if ( $passwordReset->isAllowed( $this->getUser() ) ) {
+			if ( $passwordReset->isAllowed( $this->getUser() )->isGood() ) {
 				$fieldDefinitions['passwordReset'] = [
 					'type' => 'info',
 					'raw' => true,