From 968f8468346bcb95b1101030fe29e62696b0c534 Mon Sep 17 00:00:00 2001 From: Erik Bernhardson Date: Fri, 29 Jul 2016 13:30:32 -0700 Subject: [PATCH] Remove return by reference in Title::makeTitle This made sense back in php4, but has no useful effect anymore with our minimum php version being 5.5. This also has the effect of searching for 'function makeTitle' now actually finding something. Change-Id: I0ea02a2e7dff285341b0e5b5b7773da78bfaaff3 --- includes/Title.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/Title.php b/includes/Title.php index 8aa8cb7db7..ea42768c0e 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -500,7 +500,7 @@ class Title implements LinkTarget { * @param string $interwiki The interwiki prefix * @return Title The new object */ - public static function &makeTitle( $ns, $title, $fragment = '', $interwiki = '' ) { + public static function makeTitle( $ns, $title, $fragment = '', $interwiki = '' ) { $t = new Title(); $t->mInterwiki = $interwiki; $t->mFragment = $fragment; -- 2.20.1