From 68f79fb6711a830be8551607f33e64ebc7dfe1fc Mon Sep 17 00:00:00 2001 From: "Mark A. Hershberger" Date: Fri, 6 Jan 2012 21:25:09 +0000 Subject: [PATCH] minor w/s + move $title instantiation above Enotif --- includes/RecentChange.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/includes/RecentChange.php b/includes/RecentChange.php index 6463ad0929..c446ddee29 100644 --- a/includes/RecentChange.php +++ b/includes/RecentChange.php @@ -158,7 +158,7 @@ class RecentChange { /** * Writes the data in this object to the database - * @param $noudp bool + * @param $noudp bool */ public function save( $noudp = false ) { global $wgLocalInterwiki, $wgPutIPinRC; @@ -214,10 +214,11 @@ class RecentChange { $editor = ($wgUser->getName() == $this->mAttribs['rc_user_text']) ? $wgUser : User::newFromName( $this->mAttribs['rc_user_text'], false ); } + $title = Title::makeTitle( $this->mAttribs['rc_namespace'], $this->mAttribs['rc_title'] ); + # @todo FIXME: This would be better as an extension hook $enotif = new EmailNotification(); - $title = Title::makeTitle( $this->mAttribs['rc_namespace'], $this->mAttribs['rc_title'] ); - $enotif->notifyOnPageChange( $editor, $title, + $status = $enotif->notifyOnPageChange( $editor, $title, $this->mAttribs['rc_timestamp'], $this->mAttribs['rc_comment'], $this->mAttribs['rc_minor'], @@ -731,7 +732,7 @@ class RecentChange { # see http://www.irssi.org/documentation/formats for some colour codes. prefix is \003, # no colour (\003) switches back to the term default $fullString = "$titleString\0034 $flag\00310 " . - "\00302$url\003 \0035*\003 \00303$user\003 \0035*\003 $szdiff \00310$comment\003\n"; + "\00302$url\003 \0035*\003 \00303$user\003 \0035*\003 $szdiff \00310$comment\003\n"; return $fullString; } -- 2.20.1