Kunal Mehta [Thu, 4 Jan 2018 08:21:05 +0000 (00:21 -0800)]
Remove deprecated back-compat HtmlFormatter class
Change-Id: I9325ae046997812c607e93896e108053edca76d5
jenkins-bot [Thu, 4 Jan 2018 07:01:31 +0000 (07:01 +0000)]
Merge "ApiComparePages: Add 'fromsection' and 'tosection' parameters"
Kunal Mehta [Wed, 3 Jan 2018 06:51:44 +0000 (22:51 -0800)]
Treat phpdbg as run from the command line when checking PHP_SAPI
phpdbg is a gdb-style debugger for PHP that is run from the command
line. However, it has a different PHP_SAPI value, so it was impossible
to run maintenance scripts with it (until now).
To avoid having to check both PHP_SAPI values in a bunch of places,
introduce wfIsCLI() to easily check whether running from the
command-line or not.
We're (CI team) interested in generating code coverage with phpdbg
instead of xdebug, hence this patch.
Bug: T184043
Change-Id: Id1f994ca146d7858cd8bb6ab6cdbb7718ff524fb
Kunal Mehta [Wed, 3 Jan 2018 20:32:07 +0000 (12:32 -0800)]
Bump dev dependency composer/spdx-licenses to 1.2.0
Notably, this includes support for SPDX 3.0.
https://github.com/composer/spdx-licenses/compare/1.1.4...1.2.0
Deprecated license identifiers will still be accepted, but in the future we
can start warning that they are deprecated.
Bug: T183858
Change-Id: I819ce40f24d8447a20c266b2f1fa454e966dd5a5
jenkins-bot [Wed, 3 Jan 2018 21:18:11 +0000 (21:18 +0000)]
Merge "HTMLTextAreaField: Add 'useeditfont' param"
Ed Sanders [Wed, 3 Jan 2018 17:31:34 +0000 (17:31 +0000)]
HTMLTextAreaField: Add 'useeditfont' param
Change-Id: I7c76e911b4d71842b49272186e880051eee8de2b
Brad Jorsch [Wed, 3 Jan 2018 18:27:37 +0000 (13:27 -0500)]
Add tests for ApiFormatBase
Ensuring proper behavior of the base class lets comprehensive tests of
subclasses be simpler.
This also adjusts ApiFormatTestBase to be a bit more usable, passing an
array of options through to encodeData() instead of just a class name.
And removes the unused 'SKIP' from testGeneralEncoding, but allows
expecting an exception (for use in I63ce42dd).
Change-Id: Ib2a1fa0b04860b09105376881ff8411f9534c453
jenkins-bot [Wed, 3 Jan 2018 20:55:44 +0000 (20:55 +0000)]
Merge "Fix RepoGroup caching bug"
jenkins-bot [Wed, 3 Jan 2018 20:51:55 +0000 (20:51 +0000)]
Merge "Mark DBError as runtime exception"
jenkins-bot [Wed, 3 Jan 2018 20:24:55 +0000 (20:24 +0000)]
Merge "Put menus/popups of infused PHP widgets into the default overlay"
Brad Jorsch [Wed, 3 Jan 2018 19:04:59 +0000 (14:04 -0500)]
Fix typo in PostgresUpdater in I30a3a983
Bug: T174028
Change-Id: I916c8e693e477e03295a2224320eb94599c34d65
MaxSem [Wed, 3 Jan 2018 17:22:28 +0000 (17:22 +0000)]
Merge "Allow programmatic input in Command"
Gergő Tisza [Fri, 22 Dec 2017 02:07:36 +0000 (02:07 +0000)]
Allow programmatic input in Command
Bug: T182463
Change-Id: Ib68180c7af12558686f4864c24fd85f01201d6fb
jenkins-bot [Wed, 3 Jan 2018 16:08:54 +0000 (16:08 +0000)]
Merge "Add message to the assert of ApiClearHasMsgTest"
Lucas Werkmeister [Fri, 22 Dec 2017 14:46:30 +0000 (15:46 +0100)]
Add semantic tags to license info text
Surround uppercased parts of the text in emphasis or strong importance
tags, and then change the style of those tags to remove their special
font weight or style. In normal browsers, there should be no visible
difference, but other user agents might be able to utilize the
additional semantic information.
Change-Id: Ief505e28fe971da537726afd75238b87204b85dd
RazeSoldier [Fri, 29 Dec 2017 14:03:55 +0000 (22:03 +0800)]
Display the file sha1 value in the file info page
When a visitor accesses an info page of an existing file, base-36 sha1 value of this file will displayed in the table of basic information.
Bug: T181651
Change-Id: Ib8cae3e4070a186e28e8625556d3c510af0701c2
Phantom42 [Wed, 3 Jan 2018 02:26:48 +0000 (04:26 +0200)]
Add message to the assert of ApiClearHasMsgTest
This adds 'sanity check' message for one of asserts so it is more
clear that it is asserting a precondition.
Change-Id: I10d36c1bf69effd7bd83f4a2259144e9f6e114fc
Gergő Tisza [Wed, 3 Jan 2018 02:19:58 +0000 (18:19 -0800)]
Fix RepoGroup caching bug
'bypassCache' was renamed in I9f79e5942ced4ae13ba4de0b4c62908cc746e777
to 'latest' but the cache bypass code was not updated.
Also fix an unrelated phpdoc error.
Change-Id: I141b97300853c60092363a90af063c3fd4941d27
Gergő Tisza [Tue, 2 Jan 2018 22:07:28 +0000 (14:07 -0800)]
Mark DBError as runtime exception
Some tools (e.g. PHPStorm) can trace exceptions through the
call tree and show warnings when a call can throw an exception which
is neither handled nor acknowledged via @throws annotation.
This is quite useful but currently too noisy to use due to all methods
involving some kind of DB interaction potentially throwing a DBError.
To avoid false warnings, make DBError inherit from RuntimeException
to signal it to such tools that it is not meant to be handled.
Change-Id: I847d258791b128547e10672c5e06a9ce18458371
Sam Wilson [Tue, 7 Nov 2017 03:10:14 +0000 (11:10 +0800)]
Convert Preferences class into PreferencesFactory service
This deprecates the Preferences class and replaces it with
a PreferencesFactory service. Basically, all code from Preferences
is moved into DefaultPreferencesFactory. All Prefereces methods
are now either shims calling DefaultPreferencesFactory or just
throw exceptions.
Bug: T178449
Change-Id: Id0b2db0c2de0890f6e1609a9a0dca207c4600f99
jenkins-bot [Tue, 2 Jan 2018 22:48:46 +0000 (22:48 +0000)]
Merge "Add test for DBConnRef"
Bartosz Dziewoński [Tue, 2 Jan 2018 22:25:01 +0000 (23:25 +0100)]
Put menus/popups of infused PHP widgets into the default overlay
With some special tweaks:
* Remove weird custom overlay handling in DateInputWidget that nobody
actually used. I think if you need something special like that, you
can just write two lines of JS code to attach the dropdown elsewhere.
* Also handle the CapsuleMultiselectWidget produced by HTMLForm's
'multiselect' field in the same way.
Bug: T183069
Change-Id: I693f406194aeb826a3ab5bc78c97015b0b8a7fdb
Umherirrender [Tue, 2 Jan 2018 21:57:38 +0000 (22:57 +0100)]
Remove duplicate names from CREDITS
- "Michael M." was added manually, "Schnark" came from git log - see
https://phabricator.wikimedia.org/p/Schnark/ for the connection of both
names
- same email address, already in .mailmap
- "victorbarbu" in Ib031bef17c8a7d708a5c7878e74967d19217bbc8
- "Victor Barbu" in I5285dbfc47d6429e16b7e7839bf55d48320d0bf0
- same email address, added to mailmap
- matejsuchanek in I4ef06d781bcb1aa0bc7b6d27c27cfde98390a367
- Matěj Suchánek in Ib888634af281fc2347eaa389db4141782a98c15c
Change-Id: Ibc784dca10c9f74918daf1c3940f3cd17de1deda
Bartosz Dziewoński [Thu, 14 Dec 2017 01:29:19 +0000 (02:29 +0100)]
OOjs UI: Fix font size for default overlay
Menus/popups inside the default overlay suffer from the same issue as
dialogs, as described in the comment here.
Bug: T183069
Depends-On: Ied0541209c4a9d7bf8c0574b0a864ba09fff1b70
Change-Id: I53888581f9e1da3b036166613c46cbc1085aa55e
jenkins-bot [Tue, 2 Jan 2018 21:15:43 +0000 (21:15 +0000)]
Merge "Update OOjs UI to v0.24.4"
Moriel Schottlender [Tue, 2 Jan 2018 20:23:25 +0000 (12:23 -0800)]
Follow-up Ic67a6f1af: RCFilters: Untypo the recurring namespaces typo
The param name is namespace, not namespaces. Do keep up, Schottlender.
Bug: T183910
Change-Id: Ib14a3918a85c22ddd2121c8dcc709ab53b5ff63f
Bartosz Dziewoński [Tue, 2 Jan 2018 20:02:12 +0000 (21:02 +0100)]
Update OOjs UI to v0.24.4
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.4
Depends-On: Ia54fb8fddc159f1612ca3038cdbd7da63935aa83
Change-Id: I3e59bf24191ddb753602cd4221fe998b53d25d8c
jenkins-bot [Tue, 2 Jan 2018 19:17:04 +0000 (19:17 +0000)]
Merge "MCR database schema"
Moriel Schottlender [Tue, 2 Jan 2018 18:29:03 +0000 (10:29 -0800)]
RCFilters: Correct looking for items in namespace group
To look for the namespace items, we either search for things in the
'namesapces' view (plural) or the 'namespace' group (singular) so
the code had a typo. This is a recurring typo, but overall, it makes
more sense to look for items in the **group** of namespaces rather
than in the namespace view, conceptually.
Bug: T183910
Change-Id: Ic67a6f1afd3e95fe776fbc5c33ecb7af737055b4
jenkins-bot [Tue, 2 Jan 2018 18:14:07 +0000 (18:14 +0000)]
Merge "Expand templates: Change 'text' to 'wikitext'"
jenkins-bot [Tue, 2 Jan 2018 18:12:48 +0000 (18:12 +0000)]
Merge "Expand templates: Use editfont on wikitext inputs"
addshore [Tue, 2 Jan 2018 17:04:51 +0000 (17:04 +0000)]
Pass $title to RevisionStore in Revision::newFromArchiveRow
Follow up to:
I60568b8ffd22d5e3f861c03b4b8ef14332e9015b
Change-Id: Icab36eecbaa2fdbc8832f2563786c0041930b608
Arlo Breault [Tue, 2 Jan 2018 15:39:45 +0000 (10:39 -0500)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
28d7734fa2385a8fa599e3ce1bfbcd8582c05bc4
Change-Id: Iee7f3f0022c9c770c1a02b401699df0915ea7c86
daniel [Tue, 2 Jan 2018 14:25:17 +0000 (15:25 +0100)]
Add test for DBConnRef
Change-Id: I510b2ed22b3866392592a5df53aa0f3ff6aab750
jenkins-bot [Tue, 2 Jan 2018 14:16:34 +0000 (14:16 +0000)]
Merge "Fix border colour used for textarea"
Ed Sanders [Tue, 2 Jan 2018 13:36:56 +0000 (13:36 +0000)]
Fix border colour used for textarea
Prevents FOUC when WikiEditor finishes loading.
Change-Id: Ib3610939cdb4b6a65f702688de9852a203ad6bab
Ed Sanders [Mon, 1 Jan 2018 14:02:34 +0000 (14:02 +0000)]
Expand templates: Change 'text' to 'wikitext'
Change-Id: Idbddadc7187bbfe6214f313ac0205184bceb2d23
Ed Sanders [Mon, 1 Jan 2018 14:01:38 +0000 (14:01 +0000)]
Expand templates: Use editfont on wikitext inputs
Change-Id: Ie8919b4d5caf13749d81b419aff276f7c57d7049
jenkins-bot [Tue, 2 Jan 2018 12:19:02 +0000 (12:19 +0000)]
Merge "Add @covers tags for more tests"
jenkins-bot [Tue, 2 Jan 2018 11:55:26 +0000 (11:55 +0000)]
Merge "HooksTest: Covers Hooks::callHook too"
Kunal Mehta [Fri, 29 Dec 2017 23:44:13 +0000 (15:44 -0800)]
Add @covers tags for more tests
Change-Id: If2254b3a9e61e056091779a1ea14237aa7b42eb6
Bartosz Dziewoński [Tue, 10 Oct 2017 18:51:50 +0000 (20:51 +0200)]
Generalize non-digit-grouping of four-digit numbers
In some languages it's conventional not to insert a thousands
separator in numbers that are four digits long (1000-9999).
Rather than copy-paste the custom code to do this between 13 files,
introduce another option and have the base Language class handle it.
This also fixes an issue in several languages where this logic
previously would not work for negative or fractional numbers.
To implement this, a new option is added to MessagesXx.php files,
`$minimumGroupingDigits = 2;`, with the meaning as defined in
<http://unicode.org/reports/tr35/tr35-numbers.html>. It is a little
roundabout, but it could allow us to migrate the number formatting
(currently all custom code) to some generic library easily.
Bug: T177846
Change-Id: Iedd8de5648cf2de1c94044918626de2f96365d48
jenkins-bot [Tue, 2 Jan 2018 10:12:26 +0000 (10:12 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 15.0.0"
Translation updater bot [Tue, 2 Jan 2018 08:42:01 +0000 (09:42 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I4e4a02ce4bfd4b5a73d87c57b3a9e8ef12db5087
Kunal Mehta [Tue, 2 Jan 2018 08:19:21 +0000 (00:19 -0800)]
HooksTest: Covers Hooks::callHook too
Change-Id: Id2b97b031b2fcf82a6fba66dae353db1acf340c3
jenkins-bot [Tue, 2 Jan 2018 07:21:52 +0000 (07:21 +0000)]
Merge "Chinese Conversion Table Update 2017-6"
jenkins-bot [Tue, 2 Jan 2018 05:28:44 +0000 (05:28 +0000)]
Merge "Add test for ApiClearHasMsg"
Phantom42 [Tue, 2 Jan 2018 02:58:08 +0000 (04:58 +0200)]
Add test for ApiClearHasMsg
Bug: T183769
Change-Id: I60c66a7cddaf03a83afd29e536281916ef3eb6d5
Subramanya Sastry [Tue, 2 Jan 2018 00:54:43 +0000 (18:54 -0600)]
Bump RemexHTML version to 1.0.2
Depends-On: I9fb9978c69f37bafc0049cd7ed343c033dd50ef8
Change-Id: I25bfac2c71b50db8d64f29f4b84af0a2732f245b
Umherirrender [Mon, 1 Jan 2018 13:10:16 +0000 (14:10 +0100)]
build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
Clean up use of @codingStandardsIgnore
- @codingStandardsIgnoreFile -> phpcs:ignoreFile
- @codingStandardsIgnoreLine -> phpcs:ignore
- @codingStandardsIgnoreStart -> phpcs:disable
- @codingStandardsIgnoreEnd -> phpcs:enable
For phpcs:disable always the necessary sniffs are provided.
Some start/end pairs are changed to line ignore
Change-Id: I92ef235849bcc349c69e53504e664a155dd162c8
Kunal Mehta [Fri, 29 Dec 2017 23:22:37 +0000 (15:22 -0800)]
Use MediaWikiCoversValidator for tests that don't use MediaWikiTestCase
Change-Id: I8c4de7e9c72c9969088666007b54c6fd23f6cc13
Translation updater bot [Mon, 1 Jan 2018 07:43:44 +0000 (08:43 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib05ba7e02b1e4fdc06ebdc819f076106ad835d0c
jenkins-bot [Mon, 1 Jan 2018 01:18:52 +0000 (01:18 +0000)]
Merge "Add tests for ApiCheckToken"
Phantom42 [Sun, 31 Dec 2017 20:16:17 +0000 (22:16 +0200)]
Add tests for ApiCheckToken
Bug: T183768
Change-Id: I63ab0413252c7333f73b881995869454c4881a57
jenkins-bot [Mon, 1 Jan 2018 00:05:25 +0000 (00:05 +0000)]
Merge "Revision: Handle all return values of Title::newFromId"
Sam Smith [Wed, 27 Dec 2017 14:17:04 +0000 (14:17 +0000)]
Revision: Handle all return values of Title::newFromId
In Revision::getKnownCurrent, fail early when Title::newFromId returns
null to avoid an uncatchable fatal error being triggered.
RevisionStore#getKnownCurrentRevision requires that the title parameter
be an instance of Title.
This follows on from Ia4c20a91.
Change-Id: I9bddafcc5df630d1dff1e2526194186cab7097e5
Umherirrender [Sun, 31 Dec 2017 12:35:10 +0000 (13:35 +0100)]
Fix typo in word "callback"
Change-Id: If47b9d80df4189317ec41998b35546a6118288c2
Translation updater bot [Sun, 31 Dec 2017 08:14:59 +0000 (09:14 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I7a68758df8af2b9ffdf0e8d5a2c84fdbae221b9d
jenkins-bot [Sat, 30 Dec 2017 21:25:14 +0000 (21:25 +0000)]
Merge "Remove self-explaining "section heading" comments from classes"
Kunal Mehta [Sat, 30 Dec 2017 10:32:06 +0000 (02:32 -0800)]
Parser: extract $title, follow-up
3d560be428
In the conversion away from extract(), the $title variable was missed. This
broke LabeledSectionTransclusion.
Change-Id: If4c140aedf16fc16a4ae2361f465798055748255
Brad Jorsch [Sat, 30 Dec 2017 17:59:26 +0000 (12:59 -0500)]
ApiComparePages: Add 'fromsection' and 'tosection' parameters
The deprecated diffing in prop=revisions and such used a 'rvsection'
parameter. To enable migration of things using that, action=compare
needs corresponding section parameters.
Bug: T183823
Change-Id: If1a0e2df614c083b37640418c69cca367ce0e895
jenkins-bot [Sat, 30 Dec 2017 17:10:58 +0000 (17:10 +0000)]
Merge "Improve (weak and strict) type hints invarious places"
jenkins-bot [Sat, 30 Dec 2017 10:42:38 +0000 (10:42 +0000)]
Merge "Decapitalise services folder in tests/phpunit"
jenkins-bot [Sat, 30 Dec 2017 08:37:47 +0000 (08:37 +0000)]
Merge "Append leading \ to BlobStoreFactoryTest covers"
Translation updater bot [Sat, 30 Dec 2017 08:12:23 +0000 (09:12 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I38e3c7018119fe60f30e1f0830eea7508d0061d5
Reedy [Sat, 30 Dec 2017 05:02:03 +0000 (05:02 +0000)]
Append leading \ to BlobStoreFactoryTest covers
Change-Id: I9b85aa9808c40aa728c6ef186c50bc8cdda08bc6
Aaron Schulz [Sat, 2 Dec 2017 21:12:41 +0000 (13:12 -0800)]
Try to opportunistically flush statsd data in maintenance scripts
This helps to avoid OOMs from buffer build-ups in the statsd
factory object. This piggy-backs on to the same checks used
for deferred update runs. In addition, the output() method
checks if the data size is getting large and emits if needed.
Bug: T181385
Change-Id: I598be98a5770f8358975815e51380c4b8f63a79e
Reedy [Sat, 30 Dec 2017 04:09:52 +0000 (04:09 +0000)]
Decapitalise services folder in tests/phpunit
Change-Id: If3bf8fd704eccdde435cb3bfd99ba1c1d3caee1f
Reedy [Sat, 30 Dec 2017 02:01:32 +0000 (02:01 +0000)]
Stop testing hhvm 3.12 on travis
WMF is using 3.18, which we're testing
Change-Id: I7749d4fe81433a1fd2e07447af1912c30d7c9330
jenkins-bot [Fri, 29 Dec 2017 22:05:42 +0000 (22:05 +0000)]
Merge "Special:ProtectedPages: Add fields directly in $formDescriptor"
Kunal Mehta [Fri, 22 Dec 2017 07:24:06 +0000 (23:24 -0800)]
Verify that all @covers tags are sane when running tests
PHPUnit only verifies that @covers tags are correct when actually
running coverage - but that's too slow to do on every commit. And if
even a single tag is incorrect, the entire coverage job will fail. It
also has some different requirements compared to normal tags, like all
namespaced classes must use their absolute name. All of those things
combined make it easy for developers to accidentally break the coverage
job.
There are some external tools that also do this, but those tools are
incompatible with our unusual PHPUnit setup (the phpunit.php wrapper
script).
The MediaWikiCoversValidator trait just calls the same method that
PHPUnit does to validate @covers tags. It is implemented as a trait so
that test cases that implement PHPUnit_Framework_TestCase directly can
still use this.
Bug: T171899
Change-Id: I1d564bcae2bfbedb004c440b90db6341148ed4ba
jenkins-bot [Fri, 29 Dec 2017 13:48:06 +0000 (13:48 +0000)]
Merge "API: Fix doc comment for ApiFormatNone"
jenkins-bot [Fri, 29 Dec 2017 10:31:22 +0000 (10:31 +0000)]
Merge "[MCR] Revision::newFromArchiveRow remove recently added $title param"
jenkins-bot [Fri, 29 Dec 2017 10:28:24 +0000 (10:28 +0000)]
Merge "Revert "[MCR] Add and use $title param to RevisionStore getPrevious/Next""
jenkins-bot [Fri, 29 Dec 2017 10:28:21 +0000 (10:28 +0000)]
Merge "Revert "[MCR] Add optional $title param to Revision byId methods""
Kunal Mehta [Fri, 29 Dec 2017 09:01:07 +0000 (01:01 -0800)]
API: Fix doc comment for ApiFormatNone
Change-Id: I42812402b91b2775657e68189fb662a1a3d33c08
Translation updater bot [Fri, 29 Dec 2017 08:30:53 +0000 (09:30 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I3656774b88a5d31eff6b78779528c270b484ddd7
jenkins-bot [Fri, 29 Dec 2017 06:27:50 +0000 (06:27 +0000)]
Merge "Make ImagePage#getThumbPrevText and ImagePage#makeSizeLink protected instead of private"
Prateek Saxena [Fri, 29 Dec 2017 04:10:41 +0000 (09:40 +0530)]
Special:ProtectedPages: Add fields directly in $formDescriptor
…instead of having separate functions.
Change-Id: Ife9ca83b97b24e4372d1b43b0eea41c3ac5c0fe2
jenkins-bot [Fri, 29 Dec 2017 00:21:55 +0000 (00:21 +0000)]
Merge "Remove duplicate getTitle call in RevisionStore::getNextRevision"
jenkins-bot [Fri, 29 Dec 2017 00:20:56 +0000 (00:20 +0000)]
Merge "[MCR] pass $queryFlags into RevisionStore::getTitle"
jenkins-bot [Thu, 28 Dec 2017 23:48:21 +0000 (23:48 +0000)]
Merge "Remove leading backslashes from "use \…" tags"
addshore [Thu, 28 Dec 2017 18:57:13 +0000 (18:57 +0000)]
[MCR] Revision::newFromArchiveRow remove recently added $title param
The $title param was added as part of
Ieabca1cf157fb667c75fc907b9da2917f71c61b3 and is not yet used
by any code.
The underlying issue with title fetching in RevisionStore has been fixed
in commit
4de36baa63afc23398f5d1747f08fc47309c314c
I15e4663902e2cbfe15b0da2e46449330e313bd0d
This patch removes the param that is not needed, but adds duplicate
logic to fetch a Title object to pass into the Revision object that
is created.
This logic is pulled directly from
RevisionStore::newRevisionFromArchiveRow.
Change-Id: I60568b8ffd22d5e3f861c03b4b8ef14332e9015b
addshore [Thu, 28 Dec 2017 18:48:55 +0000 (18:48 +0000)]
Revert "[MCR] Add and use $title param to RevisionStore getPrevious/Next"
This reverts commit
a760526bb41df8a46f70b498a2059323a99a683c.
This is a PARTIAL revert and the changes to the follwing methods remain:
- Revision::newFromArchiveRow
This is no longer needed as the underlying issue has been fixed
in commit
4de36baa63afc23398f5d1747f08fc47309c314c
I15e4663902e2cbfe15b0da2e46449330e313bd0d
Change-Id: I3e0ae29e62d59bcb4be871ef5b389a673ce8f103
addshore [Thu, 28 Dec 2017 18:34:17 +0000 (18:34 +0000)]
Revert "[MCR] Add optional $title param to Revision byId methods"
This reverts commit
7bfb4f195121008471974490ae24a86f2a450951.
and
56b7ba03a286c0997752fb61b14662347ea0e9de
This is no longer needed as the underlying issue has been fixed
in commit
4de36baa63afc23398f5d1747f08fc47309c314c
I15e4663902e2cbfe15b0da2e46449330e313bd0d
Bug: T183505
Change-Id: I194a558625d15fd4f7929e363557847f8bebde4f
jenkins-bot [Thu, 28 Dec 2017 16:53:39 +0000 (16:53 +0000)]
Merge "Add @covers tags API tests without them"
jenkins-bot [Thu, 28 Dec 2017 16:47:45 +0000 (16:47 +0000)]
Merge "Add @covers tags to languages tests"
jenkins-bot [Thu, 28 Dec 2017 16:45:17 +0000 (16:45 +0000)]
Merge "Add @covers tags to miscellaneous tests (#2)"
jenkins-bot [Thu, 28 Dec 2017 16:39:10 +0000 (16:39 +0000)]
Merge "Add @coversNothing in places where @covers does not apply"
Fomafix [Thu, 21 Apr 2016 05:39:08 +0000 (05:39 +0000)]
Simplify autocomplete attribute in HTMLForm
Follows-up
7489a3e8
Change-Id: Ifb17c88e39df7031054b3bee83772172c64d0a6b
Thiemo Mättig [Thu, 28 Dec 2017 15:31:56 +0000 (16:31 +0100)]
Improve (weak and strict) type hints invarious places
Change-Id: I3a42ec1547fae971d7b495c99dd144739d8521ab
Thiemo Mättig [Thu, 28 Dec 2017 15:30:05 +0000 (16:30 +0100)]
Remove leading backslashes from "use \…" tags
Change-Id: I494b029de089a07e3b946ee78293a12d5036f63e
Thiemo Mättig [Thu, 28 Dec 2017 15:12:08 +0000 (16:12 +0100)]
Remove self-explaining "section heading" comments from classes
I can see that "parent::__construct" literally calls the parent
constructor. I can see that stuff preceeded by the keyword "protected"
is protected. I really (really) don't need comments explaining such.
Change-Id: I7458e714976a6acd3ba6a7c93fdc27d03903df83
addshore [Thu, 28 Dec 2017 13:15:49 +0000 (13:15 +0000)]
Remove duplicate getTitle call in RevisionStore::getNextRevision
Change-Id: I5b7cd0e2a9ce413e582b4bdeeebc94a143896728
addshore [Thu, 28 Dec 2017 13:14:39 +0000 (13:14 +0000)]
[MCR] pass $queryFlags into RevisionStore::getTitle
Bug: T183716
Bug: T183717
Bug: T183505
Change-Id: I15e4663902e2cbfe15b0da2e46449330e313bd0d
jenkins-bot [Thu, 28 Dec 2017 11:08:09 +0000 (11:08 +0000)]
Merge "Add @covers tags to database tests"
jenkins-bot [Thu, 28 Dec 2017 11:05:51 +0000 (11:05 +0000)]
Merge "tests: Complete test coverage of HtmlArmor"
jenkins-bot [Thu, 28 Dec 2017 10:42:14 +0000 (10:42 +0000)]
Merge "Remove useless StatusTest::testCanConstruct()"
jenkins-bot [Thu, 28 Dec 2017 10:40:10 +0000 (10:40 +0000)]
Merge "Remove resolved todo from MWNamespace test"
jenkins-bot [Thu, 28 Dec 2017 10:34:47 +0000 (10:34 +0000)]
Merge "Improve @covers for TemplateParserTest"