From: Derick Alangi <alangiderick@gmail.com>
Date: Mon, 25 Feb 2019 17:11:57 +0000 (+0100)
Subject: maintenance: Remove arguments that match their default values
X-Git-Tag: 1.34.0-rc.0~2703^2
X-Git-Url: https://git.cyclocoop.org/%7B%7B%20url_for%28%27votes%27%2C%20votes=%27waiting%27%29%20%7D%7D?a=commitdiff_plain;h=c0927cba654d365af3f6fe6d5705bf2facd3f527;p=lhc%2Fweb%2Fwiklou.git

maintenance: Remove arguments that match their default values

Calls to methods with arguments as default values can safely be
removed as there is an exact match. With or without them, code
will still work as intended.

Change-Id: Id8141626a51d9cc8bf8bc0baeb5e38d120664da5
---

diff --git a/maintenance/resetUserEmail.php b/maintenance/resetUserEmail.php
index 771d19bc7b..3ba5c6b382 100644
--- a/maintenance/resetUserEmail.php
+++ b/maintenance/resetUserEmail.php
@@ -32,10 +32,10 @@ require_once __DIR__ . '/Maintenance.php';
 class ResetUserEmail extends Maintenance {
 	public function __construct() {
 		$this->addDescription( "Resets a user's email" );
-		$this->addArg( 'user', 'Username or user ID, if starts with #', true );
+		$this->addArg( 'user', 'Username or user ID, if starts with #' );
 		$this->addArg( 'email', 'Email to assign' );
 
-		$this->addOption( 'no-reset-password', 'Don\'t reset the user\'s password', false, false );
+		$this->addOption( 'no-reset-password', 'Don\'t reset the user\'s password' );
 
 		parent::__construct();
 	}