From: Erik Bernhardson <ebernhardson@wikimedia.org>
Date: Fri, 29 Jul 2016 20:30:32 +0000 (-0700)
Subject: Remove return by reference in Title::makeTitle
X-Git-Tag: 1.31.0-rc.0~6219^2
X-Git-Url: https://git.cyclocoop.org/%7B%7B%20url_for%28%27votes%27%2C%20votes=%27waiting%27%29%20%7D%7D?a=commitdiff_plain;h=968f8468346bcb95b1101030fe29e62696b0c534;p=lhc%2Fweb%2Fwiklou.git

Remove return by reference in Title::makeTitle

This made sense back in php4, but has no useful effect anymore
with our minimum php version being 5.5. This also has the effect
of searching for 'function makeTitle' now actually finding something.

Change-Id: I0ea02a2e7dff285341b0e5b5b7773da78bfaaff3
---

diff --git a/includes/Title.php b/includes/Title.php
index 8aa8cb7db7..ea42768c0e 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -500,7 +500,7 @@ class Title implements LinkTarget {
 	 * @param string $interwiki The interwiki prefix
 	 * @return Title The new object
 	 */
-	public static function &makeTitle( $ns, $title, $fragment = '', $interwiki = '' ) {
+	public static function makeTitle( $ns, $title, $fragment = '', $interwiki = '' ) {
 		$t = new Title();
 		$t->mInterwiki = $interwiki;
 		$t->mFragment = $fragment;