(bug 45130) Fix siprop=protocols in XML format

Change-Id: I2362be19f1e8f759e574d85ed210978c0fbd53a3

diff --git a/includes/api/ApiQuerySiteinfo.php b/includes/api/ApiQuerySiteinfo.php
index 593d6e7..624711a 100644 (file)
--- a/includes/api/ApiQuerySiteinfo.php
+++ b/includes/api/ApiQuerySiteinfo.php
@@ -554,8 +554,10 @@ class ApiQuerySiteinfo extends ApiQueryBase {
 
        public function appendProtocols( $property ) {
                global $wgUrlProtocols;
-               $this->getResult()->setIndexedTagName( $wgUrlProtocols, 'p' );
-               return $this->getResult()->addValue( 'query', $property, $wgUrlProtocols );
+               // Make a copy of the global so we don't try to set the _element key of it - bug 45130
+               $protocols = array_values( $wgUrlProtocols );
+               $this->getResult()->setIndexedTagName( $protocols, 'p' );
+               return $this->getResult()->addValue( 'query', $property, $protocols );
        }
 
        private function formatParserTags( $item ) {