Started tests for Message class, fixed one bug found by them
authorMax Semenik <maxsem@users.mediawiki.org>
Mon, 29 Mar 2010 14:30:42 +0000 (14:30 +0000)
committerMax Semenik <maxsem@users.mediawiki.org>
Mon, 29 Mar 2010 14:30:42 +0000 (14:30 +0000)
includes/Message.php
maintenance/tests/MessageTest.php [new file with mode: 0644]

index 5ab41a7..2ec07fa 100644 (file)
@@ -277,7 +277,7 @@ class Message {
         * @return Bool: true if it is and false if not.
         */
        public function exists() {
-               return $this->fetchMessage() === false;
+               return $this->fetchMessage() !== false;
        }
 
        public static function rawParam( $value ) {
diff --git a/maintenance/tests/MessageTest.php b/maintenance/tests/MessageTest.php
new file mode 100644 (file)
index 0000000..9adba37
--- /dev/null
@@ -0,0 +1,19 @@
+<?php
+
+class MessageTest extends PHPUnit_Framework_TestCase {
+       function testExists() {
+               $this->assertTrue( Message::key( 'mainpage' )->exists() );
+               $this->assertTrue( Message::key( 'mainpage' )->params( array() )->exists() );
+               $this->assertTrue( Message::key( 'mainpage' )->rawParams( 'foo', 123 )->exists() );
+               $this->assertFalse( Message::key( 'i-dont-exist-evar' )->exists() );
+               $this->assertFalse( Message::key( 'i-dont-exist-evar' )->params( array() )->exists() );
+               $this->assertFalse( Message::key( 'i-dont-exist-evar' )->rawParams( 'foo', 123 )->exists() );
+       }
+
+       function testKey() {
+               $this->assertType( 'Message', Message::key( 'mainpage' ) );
+               $this->assertType( 'Message', Message::key( 'i-dont-exist-evar' ) );
+               $this->assertEquals( 'Main Page', Message::key( 'mainpage' )->text() );
+               $this->assertEquals( '&lt;i-dont-exist-evar&gt;', Message::key( 'i-dont-exist-evar' )->text() );
+       }
+}
\ No newline at end of file