Removed begin/commit calls that result in error spam
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 21 May 2014 22:50:15 +0000 (15:50 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 21 May 2014 22:50:15 +0000 (15:50 -0700)
* The delete calls already try to start transactions. Also CLI scripts
  run in autocommit mode anyway.

Change-Id: I433691b3e4e578983e4e15334248f029e0b0d277

maintenance/deleteEqualMessages.php

index c30a86e..1a54df1 100644 (file)
@@ -172,7 +172,6 @@ class DeleteEqualMessages extends Maintenance {
                foreach ( $messageInfo['results'] as $result ) {
                        wfWaitForSlaves();
                        $dbw->ping();
-                       $dbw->begin( __METHOD__ );
                        $title = Title::makeTitle( NS_MEDIAWIKI, $result['title'] );
                        $this->output( "\n* [[$title]]" );
                        $page = WikiPage::factory( $title );
@@ -185,7 +184,6 @@ class DeleteEqualMessages extends Maintenance {
                                $error = ''; // Passed by ref
                                $page->doDeleteArticle( 'Orphaned talk page of no longer required message', false, 0, false, $error, $user );
                        }
-                       $dbw->commit( __METHOD__ );
                }
                $this->output( "\n\ndone!\n" );
        }