dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 262a7e2) | patch
(bug 56849) Deprecate dangerous edittime-based content update functions
authorAdam Roses Wight <awight@wikimedia.org>
Sun, 18 May 2014 21:26:17 +0000 (14:26 -0700)
committerIAlex <codereview@emsenhuber.ch>
Sat, 24 May 2014 05:23:39 +0000 (05:23 +0000)
commit2521f8b5b98069a176bc891c59e9206c490b68de
tree563e22ccba543f8d0ec8cdcb054c8fd60fd3447etree | snapshot
parent262a7e2d581c1b13c90247643fa1633cd33b0988commit | diff
(bug 56849) Deprecate dangerous edittime-based content update functions

Existing edit conflict logic relies on second-resolution timestamps,
which can fail in many exciting ways.  This patch provides new support
functions which take an explicit revision ID instead of a timestamp.

No functionality is changed.  Hopefully.

TODO:
* Make use of this code by replacing all edittime and starttime logic
with an explicit baseRevId.

Change-Id: I83cdd4adaaa67f81e933654228eccdc9fcdf9009
includes/Revision.php diff | blob | history
includes/WikiPage.php diff | blob | history
tests/phpunit/includes/WikiPageTest.php diff | blob | history
Wiklou, le Wiki du Wiklou