Completing code housekeeping stuff for rest of includes/ directory: removing unused...

[lhc/web/wiklou.git] / includes / SpecialSpecialpages.php

diff --git a/includes/SpecialSpecialpages.php b/includes/SpecialSpecialpages.php
index 91e6163..78f9dee 100644 (file)
--- a/includes/SpecialSpecialpages.php
+++ b/includes/SpecialSpecialpages.php
@@ -1,43 +1,60 @@
 <?php
+/**
+ *
+ * @package MediaWiki
+ * @subpackage SpecialPage
+ */
+
+/**
+ *
+ */
+function wfSpecialSpecialpages() {
+       global $wgOut, $wgUser;
+
+       $wgOut->setRobotpolicy( 'index,nofollow' );
+       $sk = $wgUser->getSkin();
+
+       /** Pages available to all */
+       wfSpecialSpecialpages_gen( SpecialPage::getRegularPages(), 'spheading', $sk );
+
+       /** Restricted special pages */
+       wfSpecialSpecialpages_gen( SpecialPage::getRestrictedPages(), 'restrictedpheading', $sk );
+}
 
-function wfSpecialSpecialpages()
-{
-       global $wgLang, $wgOut, $wgUser;
-       
-       # sub function generating the list of pages
-       #   $SP      : the list of pages
-       #   $heading : header to be used
-       #   $sk      : skin object ???
-       
-       function wfSpecialSpecialpages_gen($SP,$heading,$sk)
-       {
-               global $wgLang, $wgOut;
-
-               $wgOut->addHTML( "<h2>" . wfMsg( $heading ) . "</h2>\n<ul>" );
-               foreach ( $SP as $name => $desc ) {
-                       if ( "" == $desc ) { continue; }
-                       $link = $sk->makeKnownLink( $wgLang->specialPage( $name ), $desc );
-                       $wgOut->addHTML( "<li>{$link}</li>\n" );
-               }
-               $wgOut->addHTML( "</ul>\n" );
+/**
+ * sub function generating the list of pages
+ * @param $pages the list of pages
+ * @param $heading header to be used
+ * @param $sk skin object ???
+ */
+function wfSpecialSpecialpages_gen($pages,$heading,$sk) {
+       global $wgOut, $wgSortSpecialPages;
+
+       if( count( $pages ) == 0 ) {
+               # Yeah, that was pointless. Thanks for coming.
+               return;
        }
 
-       $wgOut->setRobotpolicy( "index,nofollow" );
-       $sk = $wgUser->getSkin();       
-
-       # all users special pages
-       wfSpecialSpecialpages_gen($wgLang->getValidSpecialPages(),"spheading",$sk);
-
-       # sysops only special pages
-       if ( $wgUser->isSysop() ) {
-               wfSpecialSpecialpages_gen($wgLang->getSysopSpecialPages(),"sysopspheading",$sk);
+       /** Put them into a sortable array */
+       $sortedPages = array();
+       foreach ( $pages as $page ) {
+               if ( $page->isListed() ) {
+                       $sortedPages[$page->getDescription()] = $page->getTitle();
+               }
        }
 
-       # developers only special pages
-       if ( $wgUser->isDeveloper() ) {
-               wfSpecialSpecialpages_gen($wgLang->getDeveloperSpecialPages(),"developerspheading",$sk);
+       /** Sort */
+       if ( $wgSortSpecialPages ) {
+               ksort( $sortedPages );
+       }
 
+       /** Now output the HTML */
+       $wgOut->addHTML( '<h2>' . wfMsgHtml( $heading ) . "</h2>\n<ul>" );
+       foreach ( $sortedPages as $desc => $title ) {
+               $link = $sk->makeKnownLinkObj( $title, $desc );
+               $wgOut->addHTML( "<li>{$link}</li>\n" );
        }
+       $wgOut->addHTML( "</ul>\n" );
 }
 
 ?>