Platonides [Tue, 4 Jan 2011 11:31:06 +0000 (11:31 +0000)]
Partial revert of r79520, follow up to r79558. Unconditionally use the new format.
For environments post r70783, they will need to rerender pages with __NOEDITSECTION__ or no headings (hopefully those will be simple pages).
There will be no extra parser cache misses for environments pre r70783.
Rotem Liss [Tue, 4 Jan 2011 09:40:33 +0000 (09:40 +0000)]
Localization update for he.
Tim Starling [Tue, 4 Jan 2011 06:12:33 +0000 (06:12 +0000)]
Fix for bug 26561: clickjacking attacks. See the bug report for full documentation.
Daniel Friesen [Tue, 4 Jan 2011 04:23:01 +0000 (04:23 +0000)]
*sigh* I was looking at parser tests, but not notices in a site this time... Followup r79558 fix a small php notice.
Daniel Friesen [Tue, 4 Jan 2011 04:20:09 +0000 (04:20 +0000)]
Followup r79520 and r79528, one of the args was missing when calling doEditSectionLink. Additionally the LanguageConverter was screwing up editsection markers really badly. Switched to <editsection> pesudo-xml style markers for best compatibility with the language converter. (tags are already escaped so we don't need to worry about similar user input)
Sam Reed [Tue, 4 Jan 2011 04:05:32 +0000 (04:05 +0000)]
* (bug 26560) On allusers if limit < total number of users, last user gets duplicate
If $lastUserData is set to null, it won't get added again!
Sam Reed [Tue, 4 Jan 2011 03:36:39 +0000 (03:36 +0000)]
* (bug 26559) list=allusers auprop=rights does not match list=users usprop=rights
X! [Tue, 4 Jan 2011 03:22:40 +0000 (03:22 +0000)]
Add API query test
Sam Reed [Tue, 4 Jan 2011 02:48:02 +0000 (02:48 +0000)]
* (bug 26558) list=allusers auprop=groups does not list groups a user is automatically a member of
Sam Reed [Tue, 4 Jan 2011 02:18:03 +0000 (02:18 +0000)]
Followup r79545, we don't really care for duplicate userrights
Sam Reed [Tue, 4 Jan 2011 02:13:51 +0000 (02:13 +0000)]
Add rights to array. Grrr
Sam Reed [Tue, 4 Jan 2011 02:08:38 +0000 (02:08 +0000)]
Crappy spaces from r79549
Sam Reed [Tue, 4 Jan 2011 02:06:55 +0000 (02:06 +0000)]
Rest of * (bug 25767) Add userrights properties to allusers and users query lists
Add missing parameter from r79545
X! [Tue, 4 Jan 2011 01:51:48 +0000 (01:51 +0000)]
Forcing array breaks MWFunction with <2 parameters
X! [Tue, 4 Jan 2011 01:44:11 +0000 (01:44 +0000)]
Fix r79494: Don't prefix functions now that they're in their own class
Sam Reed [Tue, 4 Jan 2011 01:39:02 +0000 (01:39 +0000)]
* (bug 25767) Add userrights properties to allusers and users query lists
First part of this bug. Listing of all rights that users have
X! [Tue, 4 Jan 2011 01:35:01 +0000 (01:35 +0000)]
Followup to r79532: Did I really need to implement a parameter? No, I did not.
X! [Tue, 4 Jan 2011 01:33:57 +0000 (01:33 +0000)]
Update to use the PHPUnit autoloader, define $IP
Chad Horohoe [Tue, 4 Jan 2011 00:42:48 +0000 (00:42 +0000)]
Remove nasty ancient global $title (at least $wgTitle is easier to grep for), its no longer set since r78512. Afaict, this generic-named global is no longer in core.
It's not a title object, it's a string of what title= in the URL. If you want that, use WebRequest::getText() or something. Using this string is *wrong* and any extensions should be fixed (I didn't check because $title is a PITA to grep for). Don't backport to 1.17 because this is trivial, harmless, and may Break Something.
(Also made fileCachedPage private since it has no outside callers and I can't see any reason why you should)
Chad Horohoe [Mon, 3 Jan 2011 23:56:49 +0000 (23:56 +0000)]
Add new addExtensionTable() wrapper for adding new tables for extensions: way easier than remembering array syntax for addExtensionUpdate()
Ilmari Karonen [Mon, 3 Jan 2011 23:20:13 +0000 (23:20 +0000)]
make action=parse return a missingtitle error if the page param refers to a missing (rather than just invalid) title
X! [Mon, 3 Jan 2011 21:36:49 +0000 (21:36 +0000)]
Add API format testing
X! [Mon, 3 Jan 2011 21:14:51 +0000 (21:14 +0000)]
Add JSON test case
X! [Mon, 3 Jan 2011 21:14:22 +0000 (21:14 +0000)]
Followup r79523: Test that calling self:: and parent:: throws exception
Daniel Friesen [Mon, 3 Jan 2011 21:04:05 +0000 (21:04 +0000)]
Followup r79520, some characters inside the encoded data were being modified by the parser causing it to break. Switching to a encoding scheme without that issue and adding a test to throw a less fatal error.
Raimond Spekking [Mon, 3 Jan 2011 20:52:23 +0000 (20:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-03 20:25:00 UTC)
Sam Reed [Mon, 3 Jan 2011 20:41:22 +0000 (20:41 +0000)]
Move comment about groups potentially returning less results from server.
Comment out description line about rights from ApiQueryUsers, as that prop doesn't exist (Might do in future. Possible artifact from large scale comment addition?)
Ilmari Karonen [Mon, 3 Jan 2011 20:32:04 +0000 (20:32 +0000)]
merge the nearly identical Title::moveToNewTitle() and Title::moveOverExistingRedirect() to a single Title::moveToInternal() method
X! [Mon, 3 Jan 2011 20:19:51 +0000 (20:19 +0000)]
Throw an exception if calling parent or self on MWFunction.
Daniel Friesen [Mon, 3 Jan 2011 20:17:20 +0000 (20:17 +0000)]
Try to output editsection markers instead of rendered editsection links and defer the rendering to a point where the markup does not need to be stored in the cache.
Doing this allows skins to override doEditSectionLinks without poluting the parser cache or fragmenting the parser cache more.
As a side effect it eliminates the primary cause of user language based parser cache fragmentation.
Because this makes most old parser cache entries invalid $wgUseEditSectionTokens is provided so that large installations like Wikipedia can keep their old parser cache entries.
X! [Mon, 3 Jan 2011 19:55:44 +0000 (19:55 +0000)]
Run is_callable, just to make sure the autoloader gets called.
Alexandre Emsenhuber [Mon, 3 Jan 2011 19:50:01 +0000 (19:50 +0000)]
* Modified Article::loadPageData() to use a slave database connection and pageDataFromTitle() instead of pageDataFromId() in the default case, as in Wiki.php (this also saves a query since the ID will be fetched with other fileds)
* Removed the loadPageData() call for the initial article in Wiki.php, will be triggered by the isRedirect() call 7 lines below if needed (this was not needed if $target is set by the InitializeArticleMaybeRedirect hook), but kept the second one (same as above, Article::exists() triggers Title::getArticleId() that would use one query to get id and a second one is needed to get the complete page data)
* Modified Article::fetchContent() to use common code (loadPageData()) and to only call it if really needed
Alexandre Emsenhuber [Mon, 3 Jan 2011 18:15:44 +0000 (18:15 +0000)]
Just call loadPageData() if not already done to get the $mIsRedirect flag in Article::isRedirect() instead of doing a lot of useless stuff
Alexandre Emsenhuber [Mon, 3 Jan 2011 17:12:27 +0000 (17:12 +0000)]
no need to set $this->mOldId, this is already done in getOldID()
nadeesha [Mon, 3 Jan 2011 09:18:21 +0000 (09:18 +0000)]
Change the xpath of the 'You can now Folder/index.php start using your wiki' text.
nadeesha [Mon, 3 Jan 2011 09:07:55 +0000 (09:07 +0000)]
Changed 'enter your wiki' link, environment ok text and remove 'Subscribe to the release announcements mailing list' check box verification section
nadeesha [Mon, 3 Jan 2011 09:06:53 +0000 (09:06 +0000)]
Change the xpath of the 'Upgrade complete' text
nadeesha [Mon, 3 Jan 2011 09:05:58 +0000 (09:05 +0000)]
Remove verification for help field hint for 'Subscribe to the release announcements mailing list' as per the code review comment(MediaWiki r79089)
nadeesha [Mon, 3 Jan 2011 09:05:18 +0000 (09:05 +0000)]
Remove testOnlyBackButtonAvailability() function as per the code review comment (MediaWiki r78165 )
Sam Reed [Mon, 3 Jan 2011 03:40:26 +0000 (03:40 +0000)]
Remove unreachable return;
Add missing global $IP;
X! [Mon, 3 Jan 2011 02:49:52 +0000 (02:49 +0000)]
Mark broken parser tests as broken
X! [Mon, 3 Jan 2011 02:10:05 +0000 (02:10 +0000)]
Move wfCreateObject to MWFunction::newObj. This uses the ReflectionClass to
instantiate a variable-length constructor in php 5.1.3 and up, and falls
back to the old, ugly, manual method that was in the old wfCreateObject
function. The instances in the core have been replaced.
Tim Starling [Mon, 3 Jan 2011 02:05:10 +0000 (02:05 +0000)]
Refresh header fix for Opera, as in r79498
Raimond Spekking [Sun, 2 Jan 2011 21:18:06 +0000 (21:18 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-02 20:53:00 UTC)
Sam Reed [Sun, 2 Jan 2011 21:01:44 +0000 (21:01 +0000)]
* (bug 26541) Generator-ise ApiQueryRecentChanges
X! [Sun, 2 Jan 2011 20:00:32 +0000 (20:00 +0000)]
Forgot the RELEASE-NOTES (woo, 500!)
X! [Sun, 2 Jan 2011 19:58:27 +0000 (19:58 +0000)]
-Add &watchuser option to ApiBlock
-Write tests for ApiBlock
Alexandre Emsenhuber [Sun, 2 Jan 2011 19:04:23 +0000 (19:04 +0000)]
Fix for r64254: undefined variable
X! [Sun, 2 Jan 2011 15:54:18 +0000 (15:54 +0000)]
Followup to r79463: Move fallback functions to new Fallback class
Alexandre Emsenhuber [Sun, 2 Jan 2011 14:35:22 +0000 (14:35 +0000)]
Fix for r45497: undefined variable
Alexandre Emsenhuber [Sun, 2 Jan 2011 14:29:04 +0000 (14:29 +0000)]
Replaced call to in_string() by strpos() since the former is not available at the time this function is called from WebStart.php (was breaking the installer)
Niklas Laxström [Sun, 2 Jan 2011 12:43:43 +0000 (12:43 +0000)]
The subtitle on movepage is now redundant with the tabs
Raimond Spekking [Sun, 2 Jan 2011 10:07:58 +0000 (10:07 +0000)]
Follow-up r79483: Fix syntax error: PHP Notice: Undefined variable: wgUpgradeKey in /home/betawiki/projects/mediawiki-ext/Installer/Installer.i18n.php on line 5997
Sam Reed [Sun, 2 Jan 2011 09:30:41 +0000 (09:30 +0000)]
Fixup some syntax errors in messages
Sam Reed [Sun, 2 Jan 2011 08:33:47 +0000 (08:33 +0000)]
Method documentation
Sam Reed [Sun, 2 Jan 2011 08:25:05 +0000 (08:25 +0000)]
Explicitally define $duplicates = array();
Also changed undefined $row for $rows
Sam Reed [Sun, 2 Jan 2011 08:05:04 +0000 (08:05 +0000)]
* (bug 26540) Fixed wrong call to applyPatch in MysqlUpdater
X! [Sun, 2 Jan 2011 06:48:07 +0000 (06:48 +0000)]
Per my comment on r68760: Make MWfunction class, complete with call_user_func helper functions that automatically
make the callback PHP 5.1 compatible with the Class::Method syntax. Add Unit tests to supplement it.
X! [Sun, 2 Jan 2011 06:15:32 +0000 (06:15 +0000)]
Followup to r79477: Add invalid purge title
X! [Sun, 2 Jan 2011 06:09:58 +0000 (06:09 +0000)]
Add API purge test (mainly as proof of concept for how API tests should be written)
X! [Sun, 2 Jan 2011 05:52:00 +0000 (05:52 +0000)]
Refactor much of the API testing code.
Old: ApiWatchTest not only tested the watch module, but also tested the login module,
and the login module test was also used to log in to the API for the other tests.
New: ApiWatchTest only contains watch-specific methods. The login testing has been moved
to ApiTest. The code used to log in and get tokens have been moved to ApiSetup. Nice,
organized, and much nicer than before. ApiUploadTest is still pretty fugly, though.
Krinkle [Sun, 2 Jan 2011 04:46:44 +0000 (04:46 +0000)]
* Toggle entire element if no .mw-collapsible-content is found
* Bug fixed in which a single customtoggle should trigger multiple customcollapsible elements
If no .mw-collapsible-content element is found when the toggleElement() function is called, assume that the user wants the mw-collapsible itself to be toggled. This enables custom use with table rows (in which we dont want something inside to toggle but the entire table row) - with a remote toggle.
This change makes it possible to have a togglable table-row.
The intial "collapsed" state for a mw-customtoggle is no longer executed by performing a click on the mw-customtoggle. Instead by calling the toggle function directly.
Reason being that an mw-customtoggle could have any number of special functions bound to it (be it the function to toggle another mw-customcollapsible, or perhaps a totally different function).
I considered using this method for 'normal' default togglers as well. However default togglers have more actions involved aside from just 'toggling' the element. Namely changing the innerText to the localized message and swapping classes. Those stay as they are by simply simulating a click() event on them (if the initial state should be collapsed).
Sam Reed [Sun, 2 Jan 2011 04:46:41 +0000 (04:46 +0000)]
Followup r79470, removed unused variable
X! [Sun, 2 Jan 2011 04:38:04 +0000 (04:38 +0000)]
GlobalFunction additions:
-in_string has a case-insensitive option
-wfClientAcceptsGzip has a force option to force resetting the static value, useful for unit tests
Unit tests for more global functions added
Sam Reed [Sun, 2 Jan 2011 04:37:06 +0000 (04:37 +0000)]
Method documentation
Change variable assignment
Sam Reed [Sun, 2 Jan 2011 03:20:45 +0000 (03:20 +0000)]
ApiQueryRevisions: Switch from manual Cache checking, to use $article->getParserOutput()
ApiParse: Fix comment typo
X! [Sun, 2 Jan 2011 02:33:07 +0000 (02:33 +0000)]
Add more wfDebug tests
X! [Sun, 2 Jan 2011 02:16:32 +0000 (02:16 +0000)]
Followup r79467: Add more wfDebug() tests, complete with MockOutputPage
X! [Sun, 2 Jan 2011 01:59:52 +0000 (01:59 +0000)]
Add some wfDebug() unit tests
X! [Sun, 2 Jan 2011 01:51:44 +0000 (01:51 +0000)]
Add fallback mb_* function tests
X! [Sun, 2 Jan 2011 01:35:24 +0000 (01:35 +0000)]
Fix r79463 and r79464: Syntax error
X! [Sun, 2 Jan 2011 01:34:26 +0000 (01:34 +0000)]
Accidental syntax error. *hides*
X! [Sun, 2 Jan 2011 01:29:00 +0000 (01:29 +0000)]
Move fallback function creation out of function_exists() conditionals.
This allows for unit testing of the fallback functions to ensure that
they work like the real functions do
Aryeh Gregor [Sun, 2 Jan 2011 00:10:42 +0000 (00:10 +0000)]
Fix broken blacklisting code from r79363
Problem reported by Krinkle -- the code I copy-pasted from the wiki page
was wrong, and apparently I didn't test properly in Opera.
Sam Reed [Sat, 1 Jan 2011 23:06:04 +0000 (23:06 +0000)]
Add missing $popts parameter, and pass it from r79455
Sam Reed [Sat, 1 Jan 2011 23:01:24 +0000 (23:01 +0000)]
Allow section to work with oldid when oldid == currentrevid (worked with older id)
Sam Reed [Sat, 1 Jan 2011 22:49:47 +0000 (22:49 +0000)]
Per Platonides on CR r75334, use $article->getParserOutput() to get latest revision, rather than doing parser cache stuff ourselves
Helps reduce code duplication too
Sam Reed [Sat, 1 Jan 2011 22:46:23 +0000 (22:46 +0000)]
Document getParserOutput() return type in Article
Sam Reed [Sat, 1 Jan 2011 22:42:53 +0000 (22:42 +0000)]
Per Nikerabbit on IRC, and Bryan on CR (r79451), change back for ===, and intval( $oldid )
Sam Reed [Sat, 1 Jan 2011 22:35:16 +0000 (22:35 +0000)]
Followup r75334. Change to int == string, rather than int === string (not going to work)
Attempt to load/save an article object, rather than an title object from the parser cache.
Per Bryan, and per bug 26534 now logged, this really needs refactoring more cleanly. As if latestRevId == oldid set, it's doing exactly the same lookup/parse
Platonides [Sat, 1 Jan 2011 22:24:51 +0000 (22:24 +0000)]
rm unused global
X! [Sat, 1 Jan 2011 22:19:22 +0000 (22:19 +0000)]
Fix r79447: Remove debugging code
Platonides [Sat, 1 Jan 2011 22:16:58 +0000 (22:16 +0000)]
Remove unused globals
X! [Sat, 1 Jan 2011 22:16:54 +0000 (22:16 +0000)]
Followup r79443: Add some form of organization to the test autoloader
Raimond Spekking [Sat, 1 Jan 2011 22:09:01 +0000 (22:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-01 21:40:00 UTC)
Platonides [Sat, 1 Jan 2011 22:04:14 +0000 (22:04 +0000)]
Use an autoloader for the tests, following the ideas from r72858.
The SeleniumTestConstants class was added in r79437
Alexandre Emsenhuber [Sat, 1 Jan 2011 21:57:32 +0000 (21:57 +0000)]
Per Platonides, fix for r79430: removed debugging code
X! [Sat, 1 Jan 2011 20:57:13 +0000 (20:57 +0000)]
Reorder functions around, add some form of order to the test suite.
It'd be nice to break some of these functions out to another class, but then again,
I'd also like to see Windows actually become stable, MediaWiki to become fully class based,
and Google to stop taking over the world. We can't all have what we want.
Platonides [Sat, 1 Jan 2011 20:56:39 +0000 (20:56 +0000)]
I am fed up of selenium constants which aren't properly defined by all files using them.
Making those of SeleniumTestConstants.php into class constants.
for i in $(grep -o 'const [A-Z_]*' SeleniumTestConstants.php | cut -c 7-); do
find -name \*.php -and -not -name SeleniumTestConstants.php -exec sed -i s/$i/SeleniumTestConstants::$i/g \{\} +
done
X! [Sat, 1 Jan 2011 18:10:28 +0000 (18:10 +0000)]
Add fuzz tests to new parser tests (someone else should make sure this works as expected)
Daniel Friesen [Sat, 1 Jan 2011 17:51:10 +0000 (17:51 +0000)]
Fix Vector to output a proper newline and indentation before the ending body and html tags... (*cough* A certain sneaker wearing rabbit made me do it)
Daniel Friesen [Sat, 1 Jan 2011 17:38:15 +0000 (17:38 +0000)]
Add a realname option to query=userinfo in the api.
X! [Sat, 1 Jan 2011 17:05:08 +0000 (17:05 +0000)]
Don't use the --verbose option anymore
Alexandre Emsenhuber [Sat, 1 Jan 2011 16:58:00 +0000 (16:58 +0000)]
Made the page_count update defered, as for the site_stats update. I just removed Article::incViewCount() since nothing else was calling this function.
Daniel Friesen [Sat, 1 Jan 2011 16:44:58 +0000 (16:44 +0000)]
Fix modern to use the tooltiponly attribute.
Daniel Friesen [Sat, 1 Jan 2011 16:41:45 +0000 (16:41 +0000)]
Convert the common bottomscripts, reporttime, and debug boilerplate into a printTrail() helper method.
Note that in vector this does move the fixalpha stuff above bottomscripts while it was after it before, theoretically though this shouldn't cause any trouble.
Markus Glaser [Sat, 1 Jan 2011 15:52:52 +0000 (15:52 +0000)]
SimpleSeleniumTest now has its own resources (database and images dir)
Markus Glaser [Sat, 1 Jan 2011 15:51:54 +0000 (15:51 +0000)]
test data for SimpleSeleniumTest
Markus Glaser [Sat, 1 Jan 2011 15:51:37 +0000 (15:51 +0000)]
test data for SimpleSeleniumTest
Markus Glaser [Sat, 1 Jan 2011 15:49:58 +0000 (15:49 +0000)]
typo in comment