Timo Tijhof [Thu, 12 Feb 2015 08:56:50 +0000 (08:56 +0000)]
backupTextPassTest: Disable checkpointHelper test
Bug: T70653
Change-Id: Iafab3094b7526dd646610f34ed9f97cfca868c3a
jenkins-bot [Thu, 12 Feb 2015 07:57:04 +0000 (07:57 +0000)]
Merge "Use MediaWikiTestCase methods for tempdir in unit tests"
jenkins-bot [Thu, 12 Feb 2015 07:28:10 +0000 (07:28 +0000)]
Merge "filerepo: Use standard method for creating temp dir in unit test"
jenkins-bot [Thu, 12 Feb 2015 00:54:12 +0000 (00:54 +0000)]
Merge "Update OOjs UI to v0.7.0"
Fomafix [Tue, 10 Feb 2015 10:54:20 +0000 (10:54 +0000)]
SpecialWhatlinkshere: Mark redirects containing templates
Mark redirects containing templates with class "mw-redirect" on
Special:WhatLinksHere.
Bug: T89098
Change-Id: Icd921c25a9c3542acb44e7175195328f283a1d5c
James D. Forrester [Thu, 12 Feb 2015 00:08:17 +0000 (16:08 -0800)]
Update OOjs UI to v0.7.0
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.7.0/History.md
Change-Id: I70c56ce5aa070d1a5e6f51f80fce7cd7750b3007
Aaron Schulz [Wed, 11 Feb 2015 22:21:16 +0000 (14:21 -0800)]
Fixed FileRepo::newGood handling of $value
bug: T89296
Change-Id: Icc2cc058d99a972bc0b243c94c49326627aa89b5
jenkins-bot [Wed, 11 Feb 2015 20:47:07 +0000 (20:47 +0000)]
Merge "Made BagOStuff::merge() take any callable"
Translation updater bot [Wed, 11 Feb 2015 20:24:17 +0000 (21:24 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Id5664c8bed61f9c2f0260163de04befce964cbd4
Aaron Schulz [Tue, 10 Feb 2015 19:11:53 +0000 (11:11 -0800)]
Made BagOStuff::merge() take any callable
Change-Id: I5ce99b8d343f1629f888a3b7594976a83839e2b7
jenkins-bot [Wed, 11 Feb 2015 19:00:55 +0000 (19:00 +0000)]
Merge "Never treat persistent stat cache as "latest" in FileBackend"
jenkins-bot [Wed, 11 Feb 2015 19:00:16 +0000 (19:00 +0000)]
Merge "Made RecentChangesUpdateJob lock wiki specific"
jenkins-bot [Wed, 11 Feb 2015 18:48:41 +0000 (18:48 +0000)]
Merge "Do not call purgeExpiredRestrictions on simple page views"
Brion Vibber [Thu, 5 Feb 2015 09:49:43 +0000 (01:49 -0800)]
Fix doc comment on $wgResponsiveImages
Doc comment referred to older implementation's data attributes.
Updated to refer to the correct srcset attribute as settled on
by browser makers, which was switched to long ago here.
Change-Id: If2bc83dd41dd88d6480957ff4968111396c9fe98
Aaron Schulz [Wed, 11 Feb 2015 17:54:34 +0000 (09:54 -0800)]
Made RecentChangesUpdateJob lock wiki specific
Change-Id: I566d81affcd3d60cd5e8da090db9ea79495e7722
jenkins-bot [Wed, 11 Feb 2015 17:52:15 +0000 (17:52 +0000)]
Merge "Clean up state of libxml on failed import."
jenkins-bot [Wed, 11 Feb 2015 15:09:50 +0000 (15:09 +0000)]
Merge "Revert "Add AvailableRightsTest for User::getAllRights completeness""
Hashar [Wed, 11 Feb 2015 15:03:02 +0000 (15:03 +0000)]
Revert "Add AvailableRightsTest for User::getAllRights completeness"
This change has not been advertised and cause random extensions
to start failing giving little clue to users.
Please have this change discussed on wikitech-l and announced
ahead of time to minimize disruptions. It brokes MathSearch at least:
https://gerrit.wikimedia.org/r/#/c/189442/
This reverts commit
d333cd8f7be190d7e296721caa79478ab7ef1b20.
Change-Id: If9a28b1386fca946d8ba351c16134cdf7da8a148
jenkins-bot [Wed, 11 Feb 2015 14:20:50 +0000 (14:20 +0000)]
Merge "mediawiki.api.login: Chain then() instead of Deferred wrapping"
daniel [Wed, 11 Feb 2015 11:06:25 +0000 (12:06 +0100)]
Clean up state of libxml on failed import.
Make sure we always call XMLReader::close() to clean up libxml's internal state,
even if import fails with an exception. Otherwise, any subsequent attempt at importing
(or otherwise using an XMLReader) will fail with:
XMLReader::open(): Unable to open source data
This is particularly annoying for unit tests which should be allowed to fail
without dragging down subsequent tests. Even more importantly, they may
explicitly be testing a failure case, which should not cause subsequent tests
to fail.
NOTE: Wikibase patch Id035ecebebb67 is blocked on this,
please re-check once this is merged.
Change-Id: I31c014df39aa11c11ded70050ef12a8e2c5fefc5
Gergő Tisza [Wed, 11 Feb 2015 10:22:53 +0000 (10:22 +0000)]
Fix mediawiki.startUp documentation
Follow-up to I41177b730a7370b4c9ca13d758d9f8493ff5192e
Change-Id: I4a7bfd7f4efc719bda2ae8680555c6b27e6ccfe2
jenkins-bot [Wed, 11 Feb 2015 09:33:01 +0000 (09:33 +0000)]
Merge "Ignore EXIF data in FormatMetadata::fetchExtendedMetadata()"
jenkins-bot [Wed, 11 Feb 2015 09:09:54 +0000 (09:09 +0000)]
Merge "Handle missing width nicely in thumb.php"
Aaron Schulz [Wed, 11 Feb 2015 05:22:39 +0000 (21:22 -0800)]
Do not call purgeExpiredRestrictions on simple page views
* Also cleaned up the on-the-fly expiry check.
bug: T88445
Change-Id: I0f601df978cc7cdd0a0b7861d39e59dae9bdda00
Timo Tijhof [Wed, 11 Feb 2015 04:08:49 +0000 (04:08 +0000)]
mediawiki.api.login: Chain then() instead of Deferred wrapping
No need to wrap a promise and manually forwarding fail().
Using "then()" does this by default.
Remove redundant 'data.login' assertion. API errors are already
handled at this point.
Handle login error before success to allow a clean function exit.
Change-Id: I032226b1e2b362c61eb2c6de0c7f5ebe2ed25b7e
Timo Tijhof [Wed, 11 Feb 2015 01:42:33 +0000 (01:42 +0000)]
Use MediaWikiTestCase methods for tempdir in unit tests
* Use MediaWikiTestCase::getNewTempFile and getNewTempDirectory
instead of wfTempDir().
The upload api tests wrote a tempnam() file directly (where
wfTempDir() is typically shared with other systems and concurrent
runs). Use MediaWikiTestCase::getNewTempFile and
getNewTempDirectory instead.
This also ensures its removal by the teardown handler without
needing manual unlink() calls. And it doesn't rely on the test
passing. (Many unlink calls where at the bottom of tests,
which wouldn't be reached in case of failure).
* For the upload test, the presistent storing of
'Oberaargletscher_from_Oberaar.jpg' (downloaded from Commons)
was removed. Note that this didn't work for Jenkins builds anyway
as Jenkins builds set $wgTmpDirectory to a unique directory
in tmpfs associated with an individual build.
* For filebackend tests, moved directory creation from the dataProvider
to the main test.
Implemented addTmpFiles() to allow subclasses to register
additional files (created by other means) to be cleaned up also.
Removed unused $tmpName and $toPath parameters in data
provider for FileBackendTest::testStore. And fixed weird double
$op2 variable name to be called $op3.
* Skipped parserTest.inc, MockFileBackend.php, and
UploadFromUrlTestSuite.php as those don't use MediaWikiTestCase.
Change-Id: Ic7feb06ef0c1006eb99485470a1a59419f972545
jenkins-bot [Wed, 11 Feb 2015 01:54:50 +0000 (01:54 +0000)]
Merge "registration: Apply ResourceFileModulePaths to all modules"
jenkins-bot [Wed, 11 Feb 2015 01:54:47 +0000 (01:54 +0000)]
Merge "registration: Throw an Exception if a JSON file is invalid"
Kunal Mehta [Wed, 11 Feb 2015 00:43:12 +0000 (16:43 -0800)]
registration: Apply ResourceFileModulePaths to all modules
Previously any module definition that specified a "class" was skipped. This
is problematic for custom modules that extend ResourceLoaderFileModule and
should be using the default paths.
Since we can't determine at initialization time whether a module class is a
ResourceLoaderFileModule or not, just add the default paths to all modules,
and leave it up to the individual classes to use the extra arguments or not.
Change-Id: Iee5d178343326030968755983f62629b81ef3c88
Timo Tijhof [Tue, 10 Feb 2015 07:55:43 +0000 (07:55 +0000)]
filerepo: Use standard method for creating temp dir in unit test
Previously, the unittests-thumb directory (and its hashed subdirectories,
and the .htaccess and index.html files) were being left behind.
While that may be a bug in the FileBackend class, the unit test
shouldn't rely on that for its teardown. If we want to assert that,
that can be a separate test.
Bug: T89085
Change-Id: Ided46b71ace82159864145b76d98bb10da5d0311
jenkins-bot [Wed, 11 Feb 2015 01:35:50 +0000 (01:35 +0000)]
Merge "registration: Remove unused ExtensionRegistry::loadInfoFromFile()"
Kunal Mehta [Wed, 11 Feb 2015 00:39:24 +0000 (16:39 -0800)]
registration: Throw an Exception if a JSON file is invalid
Currently you get confusing fatals like:
Argument 2 passed to ExtensionRegistry::processAutoLoader() must
be an array, null given
Change-Id: Icc7198db152e071c5a42e06547268fbaee916107
Marius Hoch [Wed, 11 Feb 2015 01:14:27 +0000 (02:14 +0100)]
Make UserRightsProxy::addGroup/removeGroup return bool
Required as of
e0094618b577a82209b9cc52cd15dda5e1deb784
Change-Id: I0cf9d8ee3ef9796d47442baff12a6cf8ae425d37
Kunal Mehta [Wed, 11 Feb 2015 00:31:26 +0000 (16:31 -0800)]
registration: Remove unused ExtensionRegistry::loadInfoFromFile()
Nothing calls this, I think it was left over from an earlier implementation
that did.
Change-Id: I6dd41066e040d90c8f2baa1eaf3ac3aef14b6385
Aaron Schulz [Sun, 25 Jan 2015 09:19:24 +0000 (01:19 -0800)]
Never treat persistent stat cache as "latest" in FileBackend
bug: T89184
Change-Id: I035c0f85a641efa0e4e3209b2bcf9847c08ab0d2
jenkins-bot [Tue, 10 Feb 2015 22:41:50 +0000 (22:41 +0000)]
Merge "Remove last profiling data from unit tests"
jenkins-bot [Tue, 10 Feb 2015 21:34:03 +0000 (21:34 +0000)]
Merge "Allow adding of context-based LESS Variables"
jenkins-bot [Tue, 10 Feb 2015 21:32:55 +0000 (21:32 +0000)]
Merge "Moved RecentChange::purgeExpiredChanges to a job"
Florianschmidtwelzow [Sun, 1 Feb 2015 21:37:34 +0000 (22:37 +0100)]
Allow adding of context-based LESS Variables
Add new hook (ResourceLoaderGetLessVars) called in ResourceLoader::getLessVars to
allow context-based less variables. Cache the resulting array to avoid multiple runs
of this hook.
Change-Id: I5a73bbd0ab58f8fe34519931c4f26c90998e3451
Chad Horohoe [Tue, 10 Feb 2015 21:15:00 +0000 (13:15 -0800)]
Remove last profiling data from unit tests
Change-Id: I66255ef5364f4eebafadbed663e0945e13f31969
Translation updater bot [Tue, 10 Feb 2015 20:39:14 +0000 (21:39 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I0af6985fe915f16fc887f4da140057cdca7d788a
Aaron Schulz [Fri, 23 Jan 2015 21:00:49 +0000 (13:00 -0800)]
Only support "daemonized" mode for redis job queues to avoid code duplication
Change-Id: I83bf61734fc48feea8a2f93adfe70f7d3a066b9e
Gergő Tisza [Thu, 5 Feb 2015 02:16:06 +0000 (02:16 +0000)]
Handle missing width nicely in thumb.php
Bug: T88508
Change-Id: I2cbe4ab914a9edba71461b194151938feeafeb11
jenkins-bot [Tue, 10 Feb 2015 18:57:26 +0000 (18:57 +0000)]
Merge "Remove phpunit profiling. It doesn't make any sense"
Chad Horohoe [Wed, 4 Feb 2015 18:47:57 +0000 (10:47 -0800)]
Remove phpunit profiling. It doesn't make any sense
Change-Id: I7aa98ddc0a80f931a685e2946e61aa4a7dfdabff
Aaron Schulz [Tue, 27 Jan 2015 10:15:03 +0000 (02:15 -0800)]
Made BagOStuff::cas protected, which is just one merge() implementation
Change-Id: I3ef82226231f7e03f7493ae042cad22339f4c869
Aaron Schulz [Thu, 5 Feb 2015 01:10:57 +0000 (17:10 -0800)]
Avoiding writing sessions for no reason
bug: T88635
Change-Id: I4afaecd8dc29390b1ee2a6a77f9ca0cba333ef92
jenkins-bot [Tue, 10 Feb 2015 16:21:40 +0000 (16:21 +0000)]
Merge "Add AvailableRightsTest for User::getAllRights completeness"
jenkins-bot [Tue, 10 Feb 2015 15:59:40 +0000 (15:59 +0000)]
Merge "mediawiki.user: Simplify getRegistration() code branches"
jenkins-bot [Tue, 10 Feb 2015 15:55:17 +0000 (15:55 +0000)]
Merge "mediawiki.util: Document optional first parameter of getUrl()"
jenkins-bot [Tue, 10 Feb 2015 15:55:08 +0000 (15:55 +0000)]
Merge "mediawiki.util: Clean up getUrl() test cases"
Timo Tijhof [Tue, 10 Feb 2015 06:21:33 +0000 (06:21 +0000)]
mediawiki.user: Simplify getRegistration() code branches
Change-Id: Iec3663dca276f16e107192a75193b91da230b502
jenkins-bot [Tue, 10 Feb 2015 15:06:08 +0000 (15:06 +0000)]
Merge "Update QUnit from v1.16.0 to v1.17.1"
jenkins-bot [Tue, 10 Feb 2015 15:06:01 +0000 (15:06 +0000)]
Merge "resources: Move QUnit to resources/lib/qunitjs"
Marius Hoch [Mon, 9 Feb 2015 22:50:35 +0000 (23:50 +0100)]
Add AvailableRightsTest for User::getAllRights completeness
Because extensions often don't add their rights to $wgAvailableRights
or via the 'UserGetAllRights' hook, thus User::getAllRights is incomplete.
Change-Id: Id9ae9eff71e822ec5c038c1c1f990ac36f05cea8
jenkins-bot [Tue, 10 Feb 2015 10:54:43 +0000 (10:54 +0000)]
Merge "Common interface for ImportStreamSource and ImportStringSource."
jenkins-bot [Tue, 10 Feb 2015 10:49:48 +0000 (10:49 +0000)]
Merge "Separate startUp() call from main script of mediawiki module"
daniel [Tue, 10 Feb 2015 10:34:09 +0000 (11:34 +0100)]
Common interface for ImportStreamSource and ImportStringSource.
ImportStringSource is handy for testing, but was unusable due to type hints
against ImportStreamSource. Introducing a common interface implemented by both
fixes this.
Change-Id: I820ffd8312789c26f55c18b6c46be191a550870a
jenkins-bot [Tue, 10 Feb 2015 08:29:47 +0000 (08:29 +0000)]
Merge "Make thumb.php respond with HTTP 400 (not 500) on invalid parameters"
Timo Tijhof [Tue, 10 Feb 2015 06:40:16 +0000 (06:40 +0000)]
Update QUnit from v1.16.0 to v1.17.1
* Code
https://code.jquery.com/qunit/qunit-1.17.1.js
https://code.jquery.com/qunit/qunit-1.17.1.css
* Changes
https://github.com/jquery/qunit/blob/1.17.1/History.md
Change-Id: I8078f88dcb92ee4626de80a8f0fe6596b76affd1
jenkins-bot [Tue, 10 Feb 2015 06:38:41 +0000 (06:38 +0000)]
Merge "composer.json: Specify a specific version of PHPUnit to use (~4.5)"
Timo Tijhof [Tue, 10 Feb 2015 06:38:24 +0000 (06:38 +0000)]
resources: Move QUnit to resources/lib/qunitjs
This never belonged in resources/lib/jquery as it isn't a jQuery plugin.
It's its own package and library.
In fact, while it is a jQuery Foundation project, it does not even
depend on jQuery core (e.g. like Sizzle, and PEP).
Change-Id: Ibb00f47f4c9444870832ba8d327853f335708ae7
Tim Starling [Thu, 5 Feb 2015 05:07:05 +0000 (16:07 +1100)]
Workaround for HHVM bug in readline()
https://github.com/facebook/hhvm/issues/4776
Change-Id: I9d3e6817cee2fa2c11e02989a4b11915f0c708f5
Kunal Mehta [Tue, 10 Feb 2015 04:22:16 +0000 (20:22 -0800)]
composer.json: Specify a specific version of PHPUnit to use (~4.5)
Using * will use the latest compatible version, which could potentially
introduce breaking changes. ~4.5 is equivalent to >=4.5,<5.0
Change-Id: I65bf0998cc028707f607ce7adaf45e27b1e6bca1
Timo Tijhof [Tue, 10 Feb 2015 03:40:07 +0000 (03:40 +0000)]
mediawiki.util: Document optional first parameter of getUrl()
There was already a test for it, but the documentation didn't
reflect it. Elaborate test to also cover case of default title
with additional query parameters.
Change-Id: I147054fc89a1a79c4aa8d3cfa861926515080a94
Timo Tijhof [Tue, 10 Feb 2015 03:39:24 +0000 (03:39 +0000)]
mediawiki.util: Clean up getUrl() test cases
Change-Id: I87e2ef7c45de349060ae671778fc7dcddd1bb2c2
jenkins-bot [Tue, 10 Feb 2015 03:03:10 +0000 (03:03 +0000)]
Merge "Generate valid HTML code on error pages"
jenkins-bot [Tue, 10 Feb 2015 01:52:42 +0000 (01:52 +0000)]
Merge "build: Bump various devDependencies"
James D. Forrester [Tue, 10 Feb 2015 00:47:48 +0000 (16:47 -0800)]
build: Bump various devDependencies
grunt 0.4.2 -> 0.4.5
grunt-contrib-jshint 0.10.0 -> 0.11.0
grunt-jscs 0.8.1 -> 1.5.0
grunt-karma 0.9.0 -> 0.10.1
karma-firefox-launcher 0.1.3 -> 0.1.4
qunitjs 1.15.0 -> 1.17.1
Some minor fixes to pass new jscs rules; big ones postponed for now.
Change-Id: I5f2348c3cf96cf5aa20eeb9083300155b3920c5b
Aaron Schulz [Wed, 21 Jan 2015 01:23:21 +0000 (17:23 -0800)]
Split StatusValue out of Status class and put it in /libs
* Deprecated useless FileRepoStatus class
Change-Id: I015635a9bf080ef6d98b2cff49b949c4378a859f
jenkins-bot [Mon, 9 Feb 2015 23:26:41 +0000 (23:26 +0000)]
Merge "Trival: Comment speling"
jenkins-bot [Mon, 9 Feb 2015 23:21:09 +0000 (23:21 +0000)]
Merge "registration: Add resource template-like functionality to extension.json"
Gabriel Wicke [Mon, 9 Feb 2015 04:06:07 +0000 (20:06 -0800)]
Trival: Comment speling
Change-Id: I17f50b5f26f5e8c1c9687c040c64699720ea6167
Kunal Mehta [Fri, 6 Feb 2015 09:46:05 +0000 (01:46 -0800)]
registration: Add resource template-like functionality to extension.json
This allows for extensions to specify common arguments to ResourceLoader
module definitions by only specifying them once.
The only supported values are "localBasePath" (which is relative to the
current directory), "remoteSkinPath", and "remoteExtPath". If a module
is using a custom class or is already specifying paths, the default paths
will not be added.
Tests are included to cover existing functionality and newly added
functionality. The convertExtensionToRegistration.php script was also
extended to try and guess what the default paths should be.
Bug: T88786
Change-Id: I802461796e8d8584dacf3b0c811b5ba97a4a8f7f
Translation updater bot [Mon, 9 Feb 2015 20:08:43 +0000 (21:08 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I3e3b21c3c18a8a6ae1862c263134f637acef9719
jenkins-bot [Mon, 9 Feb 2015 19:13:39 +0000 (19:13 +0000)]
Merge "HTMLForm: Support hide-if for HTMLCheckMatrix"
Fomafix [Mon, 9 Feb 2015 12:04:05 +0000 (12:04 +0000)]
Generate valid HTML code on error pages
For img_auth.php see
http://validator.w3.org/check?uri=https%3A%2F%2Fwww.mediawiki.org%2Fw%2Fimg_auth.php;No200=1
For profileinfo.php consistently use "/>" for self-closing elements.
Change-Id: I7e6aad0e7a2a745836adc430e3b2f3be5f31b6bb
jenkins-bot [Mon, 9 Feb 2015 00:10:17 +0000 (00:10 +0000)]
Merge "registration: Fix regression in ExtensionMessagesFiles handling"
Translation updater bot [Sun, 8 Feb 2015 20:23:27 +0000 (21:23 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie8bca0b8e5832b189f299ee1534e468df969fe36
jenkins-bot [Sun, 8 Feb 2015 06:14:28 +0000 (06:14 +0000)]
Merge "Documentation of compressOld.php"
Translation updater bot [Sat, 7 Feb 2015 20:27:32 +0000 (21:27 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2ca7ae2e6545647817f47b96aa037f4c85ae848e
Geoffrey Mon [Sat, 7 Feb 2015 15:56:20 +0000 (10:56 -0500)]
Resources.php: Fix phpcs-strict
Make line 1076 multiline to shorten it and
pass the phpcs-strict test.
Change-Id: I9a26d8b562cfa33881cbc6fb7447bdd53e4a71c5
Brad Jorsch [Sat, 7 Feb 2015 13:55:58 +0000 (08:55 -0500)]
HTMLForm: Support hide-if for HTMLCheckMatrix
It outputs multiple table rows, and each one needs the class and data
attribute.
Change-Id: I6667c3ea0e10167d941cb214d76889b389af79a3
Kunal Mehta [Fri, 6 Feb 2015 23:02:26 +0000 (15:02 -0800)]
registration: Fix regression in ExtensionMessagesFiles handling
In
f2daeaa7494b404, the handling of MessageDirs was fixed to properly
handle arrays, except that broke ExtensionMessagesFiles which doesn't
support arrays. Since both settings are pretty much different, I split
them into separate functions.
Bug: T88858
Change-Id: I48765af2489d2ef1e30adb1d7c5a5a8f23bf522d
jenkins-bot [Fri, 6 Feb 2015 21:58:02 +0000 (21:58 +0000)]
Merge "Fix type hint in HistoryAction::getArticle"
Translation updater bot [Fri, 6 Feb 2015 19:29:26 +0000 (20:29 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic8663ea8b5ad5b4e56b349de0c6d35c51cb5da40
Brion Vibber [Fri, 6 Feb 2015 18:55:27 +0000 (18:55 +0000)]
Merge "Account for HiDPI variants in thumb.php rate limiting"
Brion VIBBER [Fri, 6 Feb 2015 18:47:31 +0000 (18:47 +0000)]
Merge "Move wfThumbIsStandard() to GlobalFunctions and add tests"
Thiemo Mättig [Fri, 6 Feb 2015 15:54:25 +0000 (16:54 +0100)]
Fix type hint in HistoryAction::getArticle
See the type hint of the accessed Action::$page variable.
Change-Id: I10e4e27773bcca507c10cf526d193bf0a1cc97ac
jenkins-bot [Fri, 6 Feb 2015 15:07:22 +0000 (15:07 +0000)]
Merge "mediawiki.page.gallery: Clean up $galleries variable"
ayush_garg [Thu, 5 Feb 2015 13:13:43 +0000 (18:43 +0530)]
Documentation of compressOld.php
Change-Id: Ib6e4914379568bfae32007f6e76968791798b08f
jenkins-bot [Fri, 6 Feb 2015 10:13:00 +0000 (10:13 +0000)]
Merge "Database: Cast to int in estimateRowCount(), selectRowCount()"
Kevin Israel [Thu, 22 Jan 2015 15:36:18 +0000 (10:36 -0500)]
Database: Cast to int in estimateRowCount(), selectRowCount()
Doc comments state that these methods return ints. In order to ensure
that, values must be cast to int before they are returned.
With respect to selectRowCount(), follows-up
65f81d284386.
Change-Id: I108221ce4ad1b5b103b015fe875de54e04781741
Aaron Schulz [Sun, 25 Jan 2015 07:50:19 +0000 (23:50 -0800)]
Removed old SqlBagOStuff alias
Change-Id: I6fdd8791713ce9ed67473065332266c217284974
jenkins-bot [Thu, 5 Feb 2015 22:43:41 +0000 (22:43 +0000)]
Merge "Properly escape the messages in CategoryViewer.php"
Translation updater bot [Thu, 5 Feb 2015 21:41:05 +0000 (22:41 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I3b2be6f19b721e842fda17f0e4ae9ddb7269f08a
Jackmcbarn [Thu, 5 Feb 2015 21:38:02 +0000 (21:38 +0000)]
Properly escape the messages in CategoryViewer.php
This mostly reverts commit
8fe8035da20d0f5861b51f196c7443dda06301ba,
and redoes it without escaping the parser output.
Change-Id: I87da10e63b55c1a6c83dd497e30f65ad224e052b
jenkins-bot [Thu, 5 Feb 2015 20:26:34 +0000 (20:26 +0000)]
Merge "Check $auth parameter in Title::isValidMoveOperation()"
Timo Tijhof [Thu, 29 Jan 2015 23:01:06 +0000 (15:01 -0800)]
mediawiki.page.gallery: Clean up $galleries variable
Follows-up
a50c7c4181.
Instead of initialising it to an empty object and executing wasteful
code in the other functions, keep it undefined until it is defined
and use it conditionally.
Also:
* Add comment to justify() documentating what the 'this' context is.
* Return early in resize handle if $galleries hasn't been initialised yet.
Change-Id: Ib93f87e71dacfd1aad8bbb7d5559e999f4f00eb3
Bartosz Dziewoński [Thu, 5 Feb 2015 18:46:30 +0000 (19:46 +0100)]
Use transparent rather than white background for ImageMagick SVG thumbnails
Default value of $wgSVGConverters['ImageMagick'] now uses transparent
background with white fallback color, rather than just white background.
This is done by using #
ffffff00 ("transparent white") as background
color (the PNG file format supports saving color for transparent
pixels).
I could find no historical records for why it was done this way;
possibly the intent was to display white rather than black background
in IE 6 (which doesn't support PNG transparency) or in other contexts
where transparent background is impossible.
Bug: T76475
Change-Id: Ief0c7d71c8cc157e256fc84b1b7be3c23cc5fd9b