mw.toolbar: Clean up code and jsduckify
* Removed remnants of the 7th 'selectText' parameter. This
was still tossed around in a few places, but in the function
it ends up in (toolbar.insertTags) it is no longer used.
* Per code conventions, don't use jQuery's magic attrMap
argument, instead call the (in this case attr) method directly.
* Optimise way we get the reference to the detached Array#slice,
access 'slice' on local array instead of global variabile
lookup for 'Array' and accessing prototype (learned from jQuery core).
* Link "mw.toolbar.addButton" is invalid in jsduck, members
of modules are accessed by a hash sign. Should be
"mw.toolbar#addButton" or even just #addButton in this case.
* Eliminated scrollEditBox function by inlining its contents into the
$( document ).ready handler.
Change-Id: I867f2bcfd97e00a498a963e5d9730e5b0d36dcae