Mark A. Hershberger [Sun, 18 Dec 2011 01:46:25 +0000 (01:46 +0000)]
followup r88898 -- move BeforeInitialize hook to where it can be
called in a way that matches the documented parameters
As it was, when an extension tried to use BeforeInitialize with the
documented parameters this resulted in an exception:
Detected bug in an extension! Hook HookFunctionName has invalid
call signature; Parameter 2 to HookFunctionName() expected to be a
reference, value given
Mark A. Hershberger [Sun, 18 Dec 2011 01:32:11 +0000 (01:32 +0000)]
w/s
Aaron Schulz [Sat, 17 Dec 2011 23:14:39 +0000 (23:14 +0000)]
Kill some useless code in r106514
Sam Reed [Sat, 17 Dec 2011 19:55:49 +0000 (19:55 +0000)]
Per bug 28901, and Duplicatebug on r105831, only list the Article ID if it has already been loaded
Not a long term fix, but saves potentially a lot of database queries to lookup article ids, until the other issues on bug 28901 are tidied up
Sam Reed [Sat, 17 Dec 2011 19:10:33 +0000 (19:10 +0000)]
More example conversions/additions
Ping r106439
Alexandre Emsenhuber [Sat, 17 Dec 2011 18:52:52 +0000 (18:52 +0000)]
Pass the User object to Title::userCan()
Robin Pepermans [Sat, 17 Dec 2011 18:31:25 +0000 (18:31 +0000)]
Follow-up r92924: move the CSS/JS for e-mail validation to Special:ChangeEmail.
Also merge the different LTR/RTL styles, it is flipped anyway.
Aaron Schulz [Sat, 17 Dec 2011 18:27:38 +0000 (18:27 +0000)]
Expose rev_sha1/ar_sha1 to API (bug 21860)
Leons Petrazickis [Sat, 17 Dec 2011 15:59:21 +0000 (15:59 +0000)]
Fixes to address MaxSem's comment on r106480 regarding DB2 tables.sql syntax, indentation, and capitalization:
* Made all table and column names lowercase for consistency
* Removed " from around some "identifiers". Not necessary for DB2.
* Applied consistent indentation to all table declarations
* Applied consistent indentation to all index declarations
* Moved all PRIMARY KEY clauses to their own line for consistency and max line length
* Moved all ON clauses to their own line for consistency and max line length
* Fixed vertical alignment for column names and data types, remove all other vertical alignment
* Removed commented out references to SEQUENCE values, as they are used in neither DB2 nor MySQL schemas.
* Consistent spacing around parens () and commas ,
* Capitalized all data types.
* Note: tables.sql is approaching DB2's 32k limit. It will need to be split into two files soon.
Alexandre Emsenhuber [Sat, 17 Dec 2011 13:24:40 +0000 (13:24 +0000)]
Use local context to get messages
Alexandre Emsenhuber [Sat, 17 Dec 2011 13:10:48 +0000 (13:10 +0000)]
Per Aaron, fix typo in r102187
Aaron Schulz [Sat, 17 Dec 2011 05:02:15 +0000 (05:02 +0000)]
FU r98698: Show any PHP warnings in tryRespondFromFileCache() in debug mode
Jeroen De Dauw [Fri, 16 Dec 2011 23:13:10 +0000 (23:13 +0000)]
follow up to r106456 - use one setting instead two, which apparently made my commit into a fixme
Platonides [Fri, 16 Dec 2011 22:33:02 +0000 (22:33 +0000)]
Fix parser error in r106480.
PHP Parse error: syntax error, unexpected T_ARRAY, expecting ')' in includes/installer/Ibm_db2Updater.php on line 55
Leons Petrazickis [Fri, 16 Dec 2011 21:17:20 +0000 (21:17 +0000)]
Fixes to DB2 support:
* Database schema update to reflect 1.18 and 1.19 changes.
* Better support for numRows() and dataSeek() functions on DB2 result sets.
* Updates to DB2 installer and updater classes.
* Developed by Andre, Diego, and other students at Minho University and reviewed by me.
* See r85885, r85896.
Alexandre Emsenhuber [Fri, 16 Dec 2011 20:57:15 +0000 (20:57 +0000)]
Fix for r106476: forgot to remove debugging code
Alexandre Emsenhuber [Fri, 16 Dec 2011 20:55:54 +0000 (20:55 +0000)]
Per Aaron, fix for r105764: only set the timestamp if it's set in the cached ParserOutput object
Russ Nelson [Fri, 16 Dec 2011 20:01:08 +0000 (20:01 +0000)]
clean up temp files. Fixes r99546 only better this time.
Russ Nelson [Fri, 16 Dec 2011 19:59:58 +0000 (19:59 +0000)]
clean up temp files. Fixes r99546
Alexandre Emsenhuber [Fri, 16 Dec 2011 18:55:20 +0000 (18:55 +0000)]
Use WikiPage instead of Article to call doEdit()
Jeroen De Dauw [Fri, 16 Dec 2011 18:32:45 +0000 (18:32 +0000)]
introduce a new setting that allows extension authors to whitelist deprecated funtion usage for functions they do not wish to update due to backward compat reasons for a while
Jeroen De Dauw [Fri, 16 Dec 2011 18:17:04 +0000 (18:17 +0000)]
follow up to r106094
Mark A. Hershberger [Fri, 16 Dec 2011 17:19:45 +0000 (17:19 +0000)]
followup r103467 - Make sure we pass a user object when we call LoginAuthenticateAudit with self::ILLEGAL
Sam Reed [Fri, 16 Dec 2011 15:45:16 +0000 (15:45 +0000)]
Convert a few more descriptions
Ping r106439
Sam Reed [Fri, 16 Dec 2011 15:28:35 +0000 (15:28 +0000)]
Prep work for * (bug 33147) API examples should explain what they do
Now formatted in the autogenerated documentation
Format for paraminfo adds a description attribute to output
query allimages descriptions are tranformed, need to do/add to other ones
Niklas Laxström [Fri, 16 Dec 2011 10:58:20 +0000 (10:58 +0000)]
Stylize
Niklas Laxström [Fri, 16 Dec 2011 09:29:18 +0000 (09:29 +0000)]
Stylize
Niklas Laxström [Fri, 16 Dec 2011 09:22:07 +0000 (09:22 +0000)]
r98539 - make a note of change in comments
Niklas Laxström [Fri, 16 Dec 2011 08:56:57 +0000 (08:56 +0000)]
Foooollowup r106373 - update comment
Jeroen De Dauw [Fri, 16 Dec 2011 00:24:00 +0000 (00:24 +0000)]
follow up to r106393 - re-add these notices, since now they wont show for people that change the depr limit to see them
Jeroen De Dauw [Thu, 15 Dec 2011 23:40:02 +0000 (23:40 +0000)]
default deprecation notice limit to 1.17, so 1.18 and 1.19 notices are not shown unless this setting is modified. fullow up to r106070 r105985. see here for motivation: lists.wikimedia.org/pipermail/wikitech-l/2011-December/056959.html
Platonides [Thu, 15 Dec 2011 22:42:16 +0000 (22:42 +0000)]
Added type hints
Platonides [Thu, 15 Dec 2011 21:53:02 +0000 (21:53 +0000)]
Follow-up r106189. The $wgUser are no longer needed.
Platonides [Thu, 15 Dec 2011 21:21:30 +0000 (21:21 +0000)]
Simplify a bit the code of r106025
Platonides [Thu, 15 Dec 2011 21:12:27 +0000 (21:12 +0000)]
Use the canonical name of the setting
Platonides [Thu, 15 Dec 2011 20:43:58 +0000 (20:43 +0000)]
Remove unneeded global
https://gerrit.wikimedia.org/r/#change,1571
Raimond Spekking [Thu, 15 Dec 2011 20:19:43 +0000 (20:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Thu, 15 Dec 2011 18:57:53 +0000 (18:57 +0000)]
* (bug 33101) Viewing a User or User talk of username resembling IP ending with .xxx causes Internal error
Patch by Brad Jorsch
Also simplify double return null in method
Patrick Reilly [Thu, 15 Dec 2011 18:29:47 +0000 (18:29 +0000)]
add noprint to mobileview
Sam Reed [Thu, 15 Dec 2011 17:21:56 +0000 (17:21 +0000)]
Use a revision return method for revisions, follows up r105828
Chad Horohoe [Thu, 15 Dec 2011 16:52:51 +0000 (16:52 +0000)]
Get rid of a few more $wgTitles
Jeroen De Dauw [Thu, 15 Dec 2011 16:23:33 +0000 (16:23 +0000)]
follow up to r106272, alphabetical order so Nikerabbit doesnt go mad :)
Sam Reed [Thu, 15 Dec 2011 14:56:09 +0000 (14:56 +0000)]
Add a TODO with regards to existing mysql4 schemas..
Brian Wolff [Thu, 15 Dec 2011 07:17:29 +0000 (07:17 +0000)]
Throw an exception if Parser::disableCache is called before mOutput initialized (Aka when not parsing something).
So far I've encountered 2 extensions that give fatal errors from calling $wgParser->disableOutput() from hooks that are called at points where parsing is not taking place! Exception with a backtrace is much nicer than "Fatal error: Call to a member function disableCache() on a non-object..."
John Du Hart [Thu, 15 Dec 2011 02:26:14 +0000 (02:26 +0000)]
Followup r105122 & r105123, fixes and improvements per CR
Using Language::getSize per Nikerabbit
Cleanup HTML generation per brion (yay)
Neil Kandalgaonkar [Thu, 15 Dec 2011 02:06:51 +0000 (02:06 +0000)]
update messages for feedback
Neil Kandalgaonkar [Thu, 15 Dec 2011 02:06:47 +0000 (02:06 +0000)]
put bugzilla link and description into one string (description of form closer to the form itself). Fix misplaced comma.
Brion Vibber [Thu, 15 Dec 2011 01:02:25 +0000 (01:02 +0000)]
* (bug 32512) Include 'associated namespace' checkbox on Special:Contributions
patch by MrBlueSky - https://bugzilla.wikimedia.org/attachment.cgi?id=9705&action=diff
This also restructures some pieces of the form in order to better accomodate the extra checkbox (as well as those like 'deleted only' that not everybody sees)
Brion Vibber [Thu, 15 Dec 2011 00:38:09 +0000 (00:38 +0000)]
Remove stray trailing commas on last items in array literals -- this breaks IE 6/7/8
Followup r105560
Jeroen De Dauw [Wed, 14 Dec 2011 22:48:48 +0000 (22:48 +0000)]
move logging pages to logging dir
Raimond Spekking [Wed, 14 Dec 2011 20:09:13 +0000 (20:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Jeroen De Dauw [Wed, 14 Dec 2011 18:49:39 +0000 (18:49 +0000)]
follow up to r106215 r106218 106219 unless my search failed again, this ought to be the last one
Jeroen De Dauw [Wed, 14 Dec 2011 18:33:51 +0000 (18:33 +0000)]
follow up to r106215 r106218 forgot one >_>
Jeroen De Dauw [Wed, 14 Dec 2011 18:32:36 +0000 (18:32 +0000)]
follow up to r106215, pass user
Siebrand Mazeland [Wed, 14 Dec 2011 17:54:13 +0000 (17:54 +0000)]
WikiPage::viewUpdates() -> WikiPage::doViewUpdates()
Siebrand Mazeland [Wed, 14 Dec 2011 13:01:27 +0000 (13:01 +0000)]
Remove users of deprecated User::getSkin().
Antoine Musso [Wed, 14 Dec 2011 13:00:30 +0000 (13:00 +0000)]
Comment out wfDeprecated() call in User::getSkin(), there's over 300 uses in /trunk
reverts r106174
Antoine Musso [Wed, 14 Dec 2011 12:59:05 +0000 (12:59 +0000)]
revert r106183 : type / not setting followup
Sam Reed [Wed, 14 Dec 2011 12:54:35 +0000 (12:54 +0000)]
Comment out wfDeprecated() call in User::getSkin(), there's over 300 uses in /trunk
Follows up some (cba to find) rev
Sam Reed [Wed, 14 Dec 2011 12:52:20 +0000 (12:52 +0000)]
Fix one usage of User::getSkin() in phase3
Raimond Spekking [Wed, 14 Dec 2011 11:50:50 +0000 (11:50 +0000)]
Self revert r106076 which was a revert of r106070.
Raimond Spekking [Wed, 14 Dec 2011 11:49:09 +0000 (11:49 +0000)]
Self revert r106080 which was a revert of r106070.
Neil Kandalgaonkar [Wed, 14 Dec 2011 01:26:28 +0000 (01:26 +0000)]
add bug reports to feedback
Brion Vibber [Wed, 14 Dec 2011 00:50:06 +0000 (00:50 +0000)]
Fix for r106144 -- wrong syntax
Brion Vibber [Wed, 14 Dec 2011 00:38:21 +0000 (00:38 +0000)]
Add BeforePageRedirect hook to OutputPage, allowing extensions to override redirect output.
This is needed by MobileFrontend to normalize some redirects to the mobile site, such as on login.
Brion Vibber [Wed, 14 Dec 2011 00:32:56 +0000 (00:32 +0000)]
* (bug 32461) Add two-digit short form year for Persian calendar ({{#time:xiy}})
Patch by Platonides https://bugzilla.wikimedia.org/attachment.cgi?id=9490&action=diff
Plus test case. Note the test case uses Latin-style digits because it's testing English; in fa you'd get the persian digits as in the examples on the bug.
Brion Vibber [Tue, 13 Dec 2011 23:54:27 +0000 (23:54 +0000)]
Update mediawiki & viewvc links on Special:Version to https
Jeroen De Dauw [Tue, 13 Dec 2011 22:24:38 +0000 (22:24 +0000)]
fix depracted method usage
Jeroen De Dauw [Tue, 13 Dec 2011 21:37:19 +0000 (21:37 +0000)]
comment out another to soon placed warning
Jeroen De Dauw [Tue, 13 Dec 2011 21:34:16 +0000 (21:34 +0000)]
revert r106095, fix apparently not this simple
Antoine Musso [Tue, 13 Dec 2011 21:31:38 +0000 (21:31 +0000)]
make xdebug messages above everything
This way we can actually read the message. Please note this actually hide
the content behind but I feel it is better to see the backtrace.
TODO: maybe add a debug.css stylesheets wich is only loaded for developers?
Jeroen De Dauw [Tue, 13 Dec 2011 21:19:10 +0000 (21:19 +0000)]
new method was added in the same rel, so wait before showing the notice. follow up to r106070
Jeroen De Dauw [Tue, 13 Dec 2011 21:17:32 +0000 (21:17 +0000)]
logName -> getName
Jeroen De Dauw [Tue, 13 Dec 2011 21:16:57 +0000 (21:16 +0000)]
fix depracted method usage
Raimond Spekking [Tue, 13 Dec 2011 20:50:04 +0000 (20:50 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Jeroen De Dauw [Tue, 13 Dec 2011 20:45:35 +0000 (20:45 +0000)]
make docs more clear, method can only be used as is since 1.18, not 1.16
Raimond Spekking [Tue, 13 Dec 2011 20:35:02 +0000 (20:35 +0000)]
Add section header for r105954/r105963
Raimond Spekking [Tue, 13 Dec 2011 20:23:19 +0000 (20:23 +0000)]
Partly revert r106070 for now: Flooding of translatewiki.net log/channel:
PHP Notice: Use of SpecialPage::getPage was deprecated in MediaWiki 1.18. [Called from SFFormLinker::getFormEditLinkForPage in /www/w/extensions/SemanticForms/includes/SF_FormLinker.php at line 207] in /www/w/includes/GlobalFunctions.php on line 3520
Brion Vibber [Tue, 13 Dec 2011 20:20:03 +0000 (20:20 +0000)]
Followup r106070, r86347: copy some doc comments that apply to multiple functions so doxygen will pick them up
Raimond Spekking [Tue, 13 Dec 2011 20:10:30 +0000 (20:10 +0000)]
Partly revert r106070 for now: Flooding of translatewiki.net log/channel:
PHP Notice: Use of User::getSkin was deprecated in MediaWiki 1.18. [Called from TalkpageView::show in /www/w/extensions/LiquidThreads/pages/TalkpageView.php at line 251] in /www/w/includes/GlobalFunctions.php on line 3520
PHP Notice: Use of User::getSkin was deprecated in MediaWiki 1.18. [Called from MessageTable::contents in /www/w/extensions/Translate/utils/MessageTable.php at line 98] in /www/w/includes/GlobalFunctions.php on line 3520
PHP Notice: Use of User::getSkin was deprecated in MediaWiki 1.18. [Called from TranslationHelpers::ajaxEditLink in /www/w/extensions/Translate/utils/TranslationHelpers.php at line 1186] in /www/w/includes/GlobalFunctions.php on line 3520
PHP Notice: Use of User::getSkin was deprecated in MediaWiki 1.18. [Called from ThreadPermalinkView::getSubtitle in /www/w/extensions/LiquidThreads/pages/ThreadPermalinkView.php at line 153] in /www/w/includes/GlobalFunctions.php on line 3520
and maybe more
Jeroen De Dauw [Tue, 13 Dec 2011 20:01:24 +0000 (20:01 +0000)]
fix deprecated method usage
Brion Vibber [Tue, 13 Dec 2011 19:58:44 +0000 (19:58 +0000)]
bug 33035: Followup r105925: set to null rather than unset so we don't get an undefined property error later
Apparently the unset() in Language::setCode() could cause the later is_null check in getHtmlCode() to fail, though I could not reproduce it myself.
Jeroen De Dauw [Tue, 13 Dec 2011 19:51:54 +0000 (19:51 +0000)]
fix deprecated method usage
Jeroen De Dauw [Tue, 13 Dec 2011 19:51:03 +0000 (19:51 +0000)]
added missing deprecation notices
Sam Reed [Tue, 13 Dec 2011 16:58:52 +0000 (16:58 +0000)]
Followup r106046, pull ar_sha1 in getRevision
Sam Reed [Tue, 13 Dec 2011 16:57:02 +0000 (16:57 +0000)]
Fix:
PHP Notice: Undefined property: stdClass::$ar_sha1 in Revision.php on line 127
Sam Reed [Tue, 13 Dec 2011 16:51:24 +0000 (16:51 +0000)]
Add a newline, the below isn't too readable
Fixing protocol-relative entries in the externallinks table...
10020030040050060070080090010001100120013001400150016001700180019002000Done, 2007 rows updated.
Robin Pepermans [Tue, 13 Dec 2011 16:48:57 +0000 (16:48 +0000)]
Add correct margin for dd when user language direction is different from intended direction, similar to ul/ol styles
Jeroen De Dauw [Tue, 13 Dec 2011 16:42:56 +0000 (16:42 +0000)]
Follow up to r106037; fix location of check
Jeroen De Dauw [Tue, 13 Dec 2011 15:49:52 +0000 (15:49 +0000)]
Follow up to r105979;
Sam Reed [Tue, 13 Dec 2011 15:47:04 +0000 (15:47 +0000)]
Seriously, don't use "wgOut" as a function parameter name
Sam Reed [Tue, 13 Dec 2011 15:40:15 +0000 (15:40 +0000)]
Public for all
Mark A. Hershberger [Tue, 13 Dec 2011 15:06:30 +0000 (15:06 +0000)]
Bug 16794 - $wgSharedDB PostgreSQL support
Updated fix from Luca Fulchir
Robin Pepermans [Tue, 13 Dec 2011 11:54:02 +0000 (11:54 +0000)]
Removed Title::isValidCssJsSubpage(), deprecated since 1.17 (77309), and updated all remaining usage in extensions
Robin Pepermans [Tue, 13 Dec 2011 11:05:30 +0000 (11:05 +0000)]
update all core usage of deprecated Title::userCanRead()
Raimond Spekking [Tue, 13 Dec 2011 10:47:31 +0000 (10:47 +0000)]
Fix PHP Notice: Use of Title::userCanRead was deprecated in MediaWiki 1.19. [Called from SpecialSearch::showHit in /www/w/includes/specials/SpecialSearch.php at line 549] in /www/w/includes/GlobalFunctions.php on line 3520
in consequence of r105985
Raimond Spekking [Tue, 13 Dec 2011 10:40:32 +0000 (10:40 +0000)]
Partly revert r105985 for now: Flooding of translatewiki.net log/channel:
PHP Notice: Use of wfUILang was deprecated in MediaWiki 1.18. [Called from TalkpageView::show in /www/w/extensions/LiquidThreads/pages/TalkpageView.php at line 289] in /www/w/includes/GlobalFunctions.php on line 3520
Raimond Spekking [Tue, 13 Dec 2011 10:36:16 +0000 (10:36 +0000)]
Partly revert r105985 for now: Flooding of translatewiki.net log/channel:
PHP Notice: Use of Linker::makeLinkObj was deprecated in MediaWiki 1.16. [Called from call_user_func_array in (internal function)] in /www/w/includes/GlobalFunctions.php on line 3520
PHP Notice: Use of Linker::makeKnownLinkObj was deprecated in MediaWiki 1.16. [Called from call_user_func_array in (internal function)] in /www/w/includes/GlobalFunctions.php on line 3520
Neil Kandalgaonkar [Tue, 13 Dec 2011 10:26:49 +0000 (10:26 +0000)]
change args for feedback and api -- all optional, in array.
Antoine Musso [Tue, 13 Dec 2011 09:52:39 +0000 (09:52 +0000)]
bring back Linker::tooltip()
Was marked deprecated with r42702 although that helper makes code a bit
nicer:
Linker::tooltip( 'message' );
Xml::expandAttributes( array(
'title' => Linker::titleAttrib( 'message' )
) );
(the later would give you 'title=""' when 'tooltip-message' message does
not exist.